Refactor partNode creation from a KMMessage into a static method on partNode and port users to it. In the process of this, I found out that KMMessage, KMSaveAttachmentCommand and KMReaderWin all used very slightly different methods to instantiate the root item. I think most of them were wrong:
KMMessage's way (originally spread over two methods...) leaks mainBody...
KMReaderWins' way adds firstBodyPart as a child of itself...
KMSaveAttachmentsCommand doesn't adjust the mimetypes.
So that's why this is experimental: I've combined the various ways with majority vote: two adjusted the mimetypes, so mimetypes are adjusted. Only one added a part as child of it's own, so that's no longer being done, etc.
--and--
Replace broken, complicated logic with clean and simple one. Parsing is cheap in mimelib. That gives us the full MIME headers also in the top-level container partNode, which is needed in ae_branch to get at the protocol-Parameter of mp/signed parts...
svn path=/trunk/kdepim/; revision=281270
flag. Instead, explicitly set the message to read (set \seen flag) on the
server when it is marked as read locally. The reasons being:
o the local and remote status don't go out of sync leading to incorrect
unread counts
o it makes using the same imap account with multiple clients possible
o fixes a couple of bugs with the external reader window as a side effect
CCMAIL: 71596-done@bugs.kde.org
CCMAIL: 65005-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=277411
o readding the action to the menu
o making sure there is an actual slot behind the action
o preventing the command from being prematurely deleted
o making sure the KMMessage object used has a size and a serial number
CCMAIL: 71385-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=275585
outdated VCardConverter class to the recommended VCardTool,
make the VCard Viewer dialog non-modal,
avoid hiding the Import button by disabling it when no vcard
was found or after it has been imported into the addressbook
reviewed by Ingo, thanks go to Tokoe
CCMAIL: 70389-fixed@bugs.kde.org
svn path=/trunk/kdepim/; revision=275570
"image/* or application/postscript" rather than "image/* or application/
anything but postscript". This prevents kmail from trying to display
things like patches that are wrongly reported to be application/
octet-stream as images.
Remove duplicate crash guard.
svn path=/trunk/kdepim/; revision=274931
- when you clicked the first time on a msg the signaturestate was unknown and the msg was loaded completely
so I include the unknown state
- the temporary files from attachments are readonly because of a bugfix - this is bad because we need to replace them
so I set the file to writeable, replace it and set it back to readonly
and - it is magic - the download of attachments works again :-)
svn path=/trunk/kdepim/; revision=270715
With this extension the switch to html works again. I still have to figure out why getMsg is called that often.
svn path=/trunk/kdepim/; revision=269079
The result is that msgs with only one part (text) are not updated anymore and multipart msgs only once or twice.
The remaining bit of a flicker with multipart is only due to the fact that the msg has to be repainted
so I doubt that there is much we can do about that.
svn path=/trunk/kdepim/; revision=269051
saving attachements.
Ingo, does that need to be caught further up?
0x4021e497 in KMFolder::crlf2lf(char*, unsigned) (str=0x0, strLen=0) at kmail/kmfolder.cpp:1105
1105 if ( *source == '\r' && *( source + 1 ) == '\n' )
(gdb) bt
#0 0x4021e497 in KMFolder::crlf2lf(char*, unsigned) (str=0x0, strLen=0) at kmail/kmfolder.cpp:1105
#1 0x4022a287 in KMReaderWin::writeMessagePartToTempFile(KMMessagePart*, int) (this=0x8350c30, aMsgPart=0x86cd7ac, aPartNum=3)
at kmail/kmreaderwin.cpp:1323
#2 0x4031feff in KMail::ObjectTreeParser::writePartIcon(KMMessagePart*, int, bool) (this=0xbfffdc90, msgPart=0x86cd7ac, partNum=3, inlineImage=false)
at kmail/objecttreeparser.cpp:1660
#3 0x403194ae in KMail::ObjectTreeParser::defaultHandling(partNode*, KMail::ProcessResult&) (this=0xbfffdc90, node=0x86cd798, result=@0xbfffdc40)
at kmail/objecttreeparser.cpp:280
svn path=/trunk/kdepim/; revision=266274
imap support but also Outlook's new killer feature: The mighty "message
pane to the right of the list of message" view. They'll add the "you
forgot the attachment" thingie any day now ;).
svn path=/trunk/kdepim/; revision=261354
We now set the standard font which should be used by KHTML explicitely instead of setting it via the CSS because KHTML doesn't pick up the font that the user selected if it's defined via CSS. Instead KHTML seems to use the first font that matches the font-family name.
svn path=/trunk/kdepim/; revision=257272
#define kernel KMKernel::self()
to
#define kmkernel KMKernel::self()
because 'kernel' was a much to general term. We really shouldn't repeat the mistakes of the X developers.
I noticed this problem when I played around with KImageEffects. kimageeffects.h contains 'kernel' as parameter of some methods and so the compilation had to fail. We won't need KImageEffects in the near future, but at least we are now prepared and a clash with another 'kernel' can't happen anymore.
svn path=/trunk/kdepim/; revision=252621
list as before or to the right of it or hide it completely. When the reader
window is disabled, messages that are selected are not downloaded (for
imap) and are not marked as read.
CCMAIL: 63647-done@bugs.kde.org
CCMAIL: 16345-done@bugs.kde.org
CCMAIL: 43176-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=249504
(I still have to do this for the direct click on the attachment)
- fix saving of one attachment (filename was not displayed because the mimeheader was missing)
save all attachments works as expected but doesn't update the parts in the readerwin, I still need to fix this
svn path=/trunk/kdepim/; revision=249206
has redraw problems with smart MTV mode in separate reader, though)
- Extract config profile loading from the Appearance page into a new
dialog: Better user experience and less special code in appearance
page to make sure ProfileTab::apply() is called first...
- Merge the groupware and folder config pages into a misc page
(the folder tag should probably be split into "folder" and
"behaviour")
- various small cleanups:
o s/QString()/QString::null/
o unused #includes in .h files
o added const'ness to tmps
o removed some tmps
o etc
svn path=/trunk/kdepim/; revision=242473
Ingo Klcker
Pascal Ltourneau
Marc Mutz
Till Adam
Carsten Burghardt
Tobias Koenig
Andreas Gungl
Waldo Bastian
Aaron J. Seigo
Stephan Kulow
Eugene Zelenko