- kmail/imapjob.cpp:240
- kmail/imapjob.cpp:262 (similar)
If account is NULL as indicated by line 226, then line 240 crashes.
- kmail/imapjob.cpp:104
If msg_parent is NULL as indicated by line 90, then line 104 crashes.
svn path=/branches/KDE/3.5/kdepim/; revision=530060
the helper function crlf2lf there, which was formerly a class static in
FolderStorage. Remove the now obsolete forward Folder -> Folderstorage
and port all users.
svn path=/trunk/KDE/kdepim/; revision=435216
We do not need any other msgHeaderChanged calls as I see it.
The searchcommand was actually a bit buggy: the local search part of combined imap-local
searches was simply ignored when a message was updated. This is fixed now. Happy searching.
svn path=/trunk/KDE/kdepim/; revision=425074
previously not, three individual searches of the mail are triggered,
from updateAttachementState, updateSignatureState and
updateEncryptionState. Unfortunately they are precisely triggered from
ImapJob::slotGetMessageData which calls msg->fromByteArray with the data
it received from the server as a result of the message being fetched
after selection. During that fromByteArray the message has no UID
header, since the raw mail returned from the server doesn't, and
therefore KMMessage::UID() returns 0, which causes the first (and only
the first) of the three searches mentioned above to fail. The others
succeed, since they are executed asynchronously and already find
the restored uid in KMMessage::UID() when to get to asking for it. This
results in the message being removed from the search folder and
immediately re-added, which makes imap based search folders virtually
unusable.
Should only be a problem in trunk, I think, since only there are search
folders hooked up to messageHeaderChanged(). Right, Carsten?
Now I can read my kdepim commits search folder again. Rainy Saturday well
spent, I guess. Back to Kolab. ;)
CCMAIL: burghardt@kde.org
svn path=/trunk/KDE/kdepim/; revision=422163
For several messages the progress shows only the overall status but this can only
be changed in the progressmanager api which is probably a past-3.4 task.
CCMAIL: 97920@bugs.kde.org
svn path=/trunk/kdepim/; revision=391417
folder was get'ed for every single mail. Now the folderstorage has an
addMsg( QPtrList<KMMessage> ) method and the imapjob can handle put operations
with a msgList. And the thingy has a nice progressitem now.
svn path=/trunk/kdepim/; revision=385105
- the search folder should of course also check added messages correctly
- finish the progressitem when the move to an imap folder fails
svn path=/trunk/kdepim/; revision=358300
a progress item that is no longer there because the target audience of
the message has not been quick enough in clicking away the even larger
empowering and educational "your connection just died" dialog.
CCMAIL: coolo@kde.org
svn path=/trunk/kdepim/; revision=351323
convert CR/LF to LF when downloading the message from IMAP.
This ensures that it's always \r\n on server, \n on client (both in memory and on disk).
Before that, it was \r\n in kmail's memory, until restarting it, since KMFolderMailDir
would then turn it into \n !
svn path=/trunk/kdepim/; revision=348182
convert CR/LF to LF when downloading the message from IMAP.
This ensures that it's always \r\n on server, \n on client (both in memory and on disk).
Before that, it was \r\n in kmail's memory, until restarting it, since KMFolderMailDir
would then turn it into \n !
Fix approved by Till.
svn path=/branches/KDE_3_3_BRANCH/kdepim/; revision=348179
and the ListJob takes care of the kids. I extended the slotAbortRequested so that it works correctly.
Anybody willing to port this to dimap?
svn path=/trunk/kdepim/; revision=320011
to libkdepim. Removed dependency on KMMainWidget by using a signal from ProgressDialog.
This also fixes the bug Till reported, where closing the progressdialog with
the cross wouldn't make the arrow look up again.
svn path=/trunk/kdepim/; revision=316885
ProgressItems. Add some Q_ASSERTS a la David. Remove the now unused
method. Make message up- and download cancellable.
One remaining issue: displayProgress() was (ab)used to reset the idle
timeout, which eventually disconnects the slave. Where should this
resetting be done now? In the ImapJob dtor, maybe?
svn path=/trunk/kdepim/; revision=313541
and Subject of the message, so that it's possible to know which one it's about.
CCMAIL: 60384-done@bugs.kde.org, 81309@bugs.kde.org
svn path=/trunk/kdepim/; revision=310391
instead of "on exit" (which made it non-working in kontact, with session management etc.)
GUI: removed the "Warn before expiring messages" and "On Exit: Expire old messages" options.
Tasks are filed with the jobscheduler, and the job for that task is started
only if the folder isn't opened - so this needed some special handling of search
folder (asking them to try releasing a given folder) and some fixes relative to
open() and close() calls, in kmfoldercachedimap and kmfoldersearch in particular.
Don: please check the kmfoldersearch.cpp changes, in particular the added close()
CCMAIL: sanders@kde.org
svn path=/trunk/kdepim/; revision=310272
base class. Port all users of slotSlaveError to that, so we now have
continue/cancel for errors with online imap as well. Also give context
for error messages to make them a little more descriptive. Make sure that
the jobs are removed only in non-error paths, because the error handler
does that as well now.
svn path=/trunk/kdepim/; revision=306243
job continue in the background but delete it, it's not needed anymore.
Make sure the imapjob dtor cleans up associated KIO jobs if they are still
around and resets the progress thingie etc.
We can't really keep the server from answering already sent queries
completely, but we can discard as much of the infrastructure as possible,
to keep things snappy.
svn path=/trunk/kdepim/; revision=300844
Stephan Kulow
Will Stephenson
Till Adam
Ingo Klcker
David Faure
Allen Winter
Ismail Onur Filiz
Tom Albers
Reinhold Kainhofer
Carsten Burghardt
Holger Freyther
Laurent Montel