into an imap folder.
As per the "PATCH: KMFolderImap::slotGetMessagesData discrepancy"
discussion on the kmail-devel list.
I've tested it for weeks now without noticing any problems.
svn path=/trunk/kdepim/; revision=365366
when simply opening mail folders) : don't look for the serial numbers
of messages that haven't been inserted into a folder yet, it can't find one,
and it's slow every time. Note that assign() is only called on construction
(or soon after), never on totally-unrelated instances.
svn path=/trunk/kdepim/; revision=361937
and related things to KConfigXT. This must have been a lot of very non-
interesting grunt work, but it's a very much appreciated, so thanks a
bunch, dude. :)
Please everyone keep your eyes open for regressions, I've tried to review
it carefully, but it's big and something might have crept in.
svn path=/trunk/kdepim/; revision=361463
identity when replying in a folder with an identity set. Normally you
would not notice this, as the mails in the folder will normally have
been sent to that identity email anyhow, but if not, you'd notice, as Tom
did, and since he's been doing so much valuable bug work, it's my pleasure
to correct this.
This exposes a problem with the folder properties dialog, which sets a
folder identity always, on ok/apply, even if it's the default one, which
means when people change default identity all folders will be wrong, if
they have ever been edited. We shall have to fix that.
svn path=/trunk/kdepim/; revision=356396
when initiated via menu or hotkey (the redirect filter action
has already been fixed for 3.3).
See http://bugs.kde.org/show_bug.cgi?id=88473 and duplicates.
The dialog which collects the addresses needs further
improvements though.
svn path=/trunk/kdepim/; revision=350099
CVS commit by tilladam:
Fix issue 139 by using the mechanism we use for setting the replied and
forwarded status after a mail has been sent succesfully to move the mail
that originally triggered the sending of the accept/decline mail, whose
serial number is remembered in a link header to the trash folder configured
for that account. In other words, if you click to accept an invitation, and
then send the generated reply, the invitation mail will automagically go
away.
svn path=/trunk/kdepim/; revision=347299
strategy (iconic or inline) of the body part. Make the bodypartnode
implementation of the interface set it according to the readerwindow's
display strategy. Now bodypartformatter plugins can honor the display
strategy of the readerwindow they are invoked by.
svn path=/trunk/kdepim/; revision=346748
when loading attachments on demand. Please check if that fixes the attachment thingy.
CCMAIL: 85288@bugs.kde.org
svn path=/trunk/kdepim/; revision=334925
Now we sent redirected messages which are conform to RFC 2822.
Thanks to Ingo for pointing me into the right direction.
CCMAIL: 51283-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=333330
If we do KMMessage::fromDwString(), we get to the calls that set the various
state flags from header fields. If those header fields are not there, then
setMDNSentState( 0 ) will be called. But 0 isn't a value in the resp. enum.
Catch this case and make it set the mdn sent state to unkown instead.
svn path=/trunk/kdepim/; revision=330149
(better than <foo.h>, especially when systems could have an identity.h somewhere)
A kconfig_update script moves the identities from kmailrc to emailidentities
svn path=/trunk/kdepim/; revision=311347
folder after sending instead of the indentity sent-mail folder. This
overrides the identity setting, which I think makes sense. We'll have to
see if it causes trouble in some way.
There is no gui for this yet, as I would appreciate the input of Aaron
"Folder Properties" Seigo as to how to add yet another option to that
dialog without making it even taller than it already is. So to try this
you'll have to add a PutRepliesInSameFolder=true to the config section
corresponding to the folder you want to set it for.
This commit message is now officially longer than the whole patch. :)
svn path=/trunk/kdepim/; revision=302497
work anymore correctly because the messages were treated as if the user
wanted to edit a HTML message. This was fixed by introducing a new
private header X-KMail-Markup which is set to "true" for HTML messages
which the user creates with KMail.
- Fix another HTML editting regression: Plain text messages with a HTML
attachment were treated as multipart/alternative messages. This was fixed
by checking whether the parent of the text/html body part is a mp/alt bp.
- useHTMLEditor -> mUseHTMLEditor (member variables must start with an 'm')
- Remove superfluous toggleMarkup calls from the c'tor since this is done
in setMsg and since it was anyway much too simple (and therefore wrong).
- Move some local variables to where they are really used.
- Remove kdDebug which dumped the whole message.
- Show the HTML toolbar if toggleMarkup( true ) is called so that the
toolbar is visible if the user edits a HTML message.
svn path=/trunk/kdepim/; revision=299377
Implementing automagic mailing list handling: KMail can now detect whether
a folder stores a mailing list in which case it will try to determine its post,
subscribe, unsubscribe, archive and help addresses.
Aaron could you figure out where the kaction's invoking post,subscribe... could
be put?
CCMAIL: aseigo@kde.org
svn path=/trunk/kdepim/; revision=295216
You don't need getMsg anymore for the UID and LOD can check the size without loading the header.
I updated the online imap folder but dimap should also use the new code.
svn path=/trunk/kdepim/; revision=288206
- Bug 72808: reply to myself is broken / empty To: address field
- Bug 62919: reply all should not use From when ReplyTo is set (except for mailing list messages)
svn path=/trunk/kdepim/; revision=284206
candidate_for_3_2_1: We want the type as string, not the complete raw content-type header. Fix the only real caller and remove the other calls to this method, whose values were assigned to unused variables
svn path=/trunk/kdepim/; revision=281272
Refactor partNode creation from a KMMessage into a static method on partNode and port users to it. In the process of this, I found out that KMMessage, KMSaveAttachmentCommand and KMReaderWin all used very slightly different methods to instantiate the root item. I think most of them were wrong:
KMMessage's way (originally spread over two methods...) leaks mainBody...
KMReaderWins' way adds firstBodyPart as a child of itself...
KMSaveAttachmentsCommand doesn't adjust the mimetypes.
So that's why this is experimental: I've combined the various ways with majority vote: two adjusted the mimetypes, so mimetypes are adjusted. Only one added a part as child of it's own, so that's no longer being done, etc.
--and--
Replace broken, complicated logic with clean and simple one. Parsing is cheap in mimelib. That gives us the full MIME headers also in the top-level container partNode, which is needed in ae_branch to get at the protocol-Parameter of mp/signed parts...
svn path=/trunk/kdepim/; revision=281270
Don Sanders
David Faure
Till Adam
Ingo Klcker
Marc Mutz
Laurent Montel
Andreas Gungl
Bo Thorsen
Karl-Heinz Zimmer
Carsten Burghardt
Stephan Binner
Zack Rusin