in the attempt to remove it from the tree of subject threading messages
failing and the detached child looking for a new parent finding the old
parent as the new parent, which in turn results in the child being deleted
with the old (and new) parent, which is not a good idea, since it is
still referenced.
(This is only fixing the symptom for now, not the real issue)
BUG: 94043
svn path=/trunk/kdepim/; revision=375955
mainwidget triggering moves on msgbase and msg pointers which it then
proceeded to invalidate by inadvertent calls to getMsg() via
headers->currentMsg() while updating the folder and message actions. Fix
that by triggering the action update from the completion handler of the
message moving code in KMHeaders.
This very probably fixes several reported crash bugs, but since they all
have inconclusive backtraces, I'm leaving them open for now. We'll see.
svn path=/trunk/kdepim/; revision=375412
Additionally, checking for config updates is sped up by only checking the application of new config updates instead of checking all config updates.
FEATURE: 79938
GUI:
svn path=/trunk/kdepim/; revision=372098
"move whole thread to trash" and "delete whole thread" with shortcuts
ctrl-Delete and ctrl-shift-Delete. I've slightly modified it to be
consistent with the other thread actions disabling/enabling and menu
structure.
Thanks, Kurt.
FEATURE: 89003
GUI:
svn path=/trunk/kdepim/; revision=368332
happens when a mail that was supposed to be downloaded could not be,
because it was no longer on the server (deleted by another client).
svn path=/trunk/kdepim/; revision=366604
BUG: 77515
Allow "Mark Message" when in drafts folder
BUG: 81711
Show "Copy" and "Select All" when text selected in message view.
BUG: 84248
Make header popup and message popup more consistent. Move delete options to bottom of menu.
svn path=/trunk/kdepim/; revision=362800
- no need to emit messageListUpdated() in msgAdded, since 3.3's KListView has it's own signal for that
- don't emit selected(0) when the message that was just highlighted has the transferInProgress flag set. That results in it not being displayed in the reader window if you quickly pass over it, so it's load gets triggered, and then go back to it
As far as I can tell there is nothing that should conceptually prevent us from telling the rest of the world that the headers list selected a message if that message is in transfer. If calling code has a problem with that, it needs to be fixed. I think this is from the time when transferInProgress was used as a crude message locking tool for imap operations.
svn path=/trunk/kdepim/; revision=360939
during filtering, as it has side effects and it's better to avoid doing
the updates in the first place. Use prepare/finishMove to do re-selection,
which centralizes that logic.
svn path=/trunk/kdepim/; revision=360773
Alt-left/right changes the current mail without selecting it, which is
very handy with online imap, since the skipped over mails won't be
downloaded. Alt-space selects the current message. This is symmetrical
to the ctrl-left/right/space handling in the folder tree.
FEATURE:
GUI:
CCMAIL: l.lunak@kde.org
svn path=/trunk/kdepim/; revision=357329
no need to reapply the search line after filtering each message (due to messageListUpdated()
being connected to KListViewSearchLine::updateSearch()).
Ingo: do you consider this safe enough to be backported?
svn path=/trunk/kdepim/; revision=356314
kmailrc, I like the status to show, and conversly, not show when it's FALSE.
(Note: I did not investigate how this impacts the "default" KMail setup when
a clean first-start happens.)
svn path=/trunk/kdepim/; revision=352912
Adapt the popup-menu text for the receiver column to show "Sender" if the other sender/receiver column currently shows "Receiver"
svn path=/trunk/kdepim/; revision=348881
- jump to first new (old default)
- jump to first new or unread (old checkbox jump to unread)
- jump to last selected (new)
svn path=/trunk/kdepim/; revision=338393
in KMHeaders used to use msgDict->getMsgSerNum( folder, index ) which fails
for search folders. Use msg->getMsgSerNum() instead. Remove now unused
parameter from the key generation.
Thanks, Scott, for insisting that this is broken, even though we all were
convinced it wasn't. :)
svn path=/trunk/kdepim/; revision=333830
highlightMessage is called twice - the msg is transferInProgress==true - the message is not displayed
Fix: do not bounce the selection and make it identical to setCurrentItemByIndex
svn path=/trunk/kdepim/; revision=331270
set the sorting in KListview *after* clearing, not before. setSorting actually
sorts the current items immediately, so this was trying to call key() on the OLD
items with mFolder set to the NEW folder => mismatch.
This might be a QListView behavior change, otherwise it would be hard to explain that
we missed this for so long.
OKayed by till on IRC.
svn path=/trunk/kdepim/; revision=329271