Using a const iterator to iterate over a list of changing items is not a good idea.
Fun fact: The iterator loop contained another nested iterator, with the exact same name. And it even worked.
svn path=/trunk/KDE/kdepim/; revision=689231
- for ( it = dir->begin(); (node = *it ) && it != dir->end(); ++it ) {
is really wrong, it dereferences the end iterator!
Plus apply patch from Laurent to use KIMAP::encodeImapFolderName instead of non-ported utf7-codec.
svn path=/trunk/KDE/kdepim/; revision=683868
compile++
SVN commit 645427 by coolo:
fix folder reference counting at least for the most
easy use of search folders
svn path=/branches/kdepim/enterprise/kdepim/; revision=667965
which I've been developing with the help of some adventurous users. Thanks!
This tracks all deletions that happen through user actions and adds a check
to the sync making sure that only things that were explicitely deleted
are removed during sync. If unsure, the sync now re-downloads (duplicates)
instead of removing mails, which should be safer. Also adds a lot of
conditional debugging and refactors open/close to duplicate less code.
Will has a ported version of this for 3.x, which will go into pim+ shortly.
svn path=/branches/kdepim/enterprise/kdepim/; revision=662047
This obviously reintroduces issue661, "forwarding emails can produce bad signature", which will have to be fixed another way once I get more infos about it.
Also remove getMsgString from all folder classes, since it's now unused; getDwString is used instead.
svn path=/branches/kdepim/enterprise/kdepim/; revision=650094
fix folder reference counting at least for the most
easy use of search folders
and cleaning up indentation and style while I'm at it.
svn path=/trunk/KDE/kdepim/; revision=645498
QMAX/QMIN -> qMax/qMin
I don't know what to do about Q_LONG and Q_ULONG because of the following code in qglobal.h:
#if defined(Q_OS_WIN64)
typedef __int64 Q_LONG; /* word up to 64 bit signed */
typedef unsigned __int64 Q_ULONG; /* word up to 64 bit unsigned */
#else
typedef long Q_LONG; /* word up to 64 bit signed */
typedef unsigned long Q_ULONG; /* word up to 64 bit unsigned */
#endif
Should I simply convert to (unsigned) long?
svn path=/trunk/KDE/kdepim/; revision=468393
on, by setting the involved folderstorage's search pointers to 0 and
checking them. Can't use a QGuardedPtr, since the searchpatterns aren't
QObjects. Const-ify patterns and some detabification.
svn path=/trunk/KDE/kdepim/; revision=432984
it, if there is no physical folder yet. Code creating (instantiating)
KMFolders does not need to care. Remove the ugly "bool imap" parameter
from create() and do proper reimplementation instead. Remove create()
forward from KMFolder -> FolderStorage.
This fixes "no such file or folder" warnings when creating or syncing
down new folders.
In case you missed it, today is Zack's birthday, so show the man some
love, will ya?
svn path=/trunk/KDE/kdepim/; revision=430989
here: http://lists.kde.org/?l=kmail-devel&m=111945756024656&w=2
I've changed the KMMsgDict::instance() to return a pointer instead of a
reference, compared to the patch I posted, after valid criticism from
Marc that the pattern is generally used with a pointer, in KDE, so it's
better not to surprise people here.
svn path=/trunk/KDE/kdepim/; revision=428560
Thomas McGuire
Laurent Montel
David Faure
Ingo Klcker
Pradeepto Bhattacharya
Till Adam
Allen Winter
Stephan Kulow
Matthias Kretz
Reinhold Kainhofer
Ismail Onur Filiz
Andreas Gungl
Lus Pedro Coelho