Don't update if you don't want to fix it. If you still do, disable kmail from compilation.
And never try to run it on important data. ;)
svn path=/branches/work/akonadi-ports/kdepim/; revision=1036843
Fix online IMAP filters not working in various situations.
Patch by Matthias Gehre <M.Gehre@gmx.de>, thanks very much!
CCBUG: 171061
CCBUG: 174430
CCBUG: 182208
CCBUG: 186264
svn path=/branches/KDE/4.2/kdepim/; revision=960606
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/KDE/4.2/kdepim
........
r909042 | kloecker | 2009-01-10 22:51:26 +0100 (Sat, 10 Jan 2009) | 3 lines
Backported revision 908961 from trunk
Also emit the filtered() signal if a message was already filtered (indicated by the presence of the X-KMail-Filtered header), so that it is taken out of the list of unfiltered messages by KMAcctImap. Without this messages filtered by another instance of KMail were downloaded again and again each time the IMAP inbox containing those messages was opened.
........
svn path=/branches/kdepim/enterprise4/kdepim/; revision=914257
Also emit the filtered() signal if a message was already filtered (indicated by the presence of the X-KMail-Filtered header), so that it is taken out of the list of unfiltered messages by KMAcctImap. Without this messages filtered by another instance of KMail were downloaded again and again each time the IMAP inbox containing those messages was opened.
svn path=/branches/KDE/4.2/kdepim/; revision=909042
This brings a reworked folder tree and and a new message list, which is much more powerful than the old one.
New features include grouping, multiline items and the ability to customize just about everything of the look of the message list.
Also, we have a tabbed interface for opening more than one folder at once now.
An important aspect of the new message list is that drawing speed is now fast again (there was a regression in Q3ListView that
made huge folders a real pain to navigate, reading commit folders was not a nice thing to do).
There are probably more things which I forgot to list here.
Also, this is big step forward in getting rid of Qt3Support in KMail, now just some tiny bits are left.
Many thanks to SoC student Szymon Stefanek for his awesome work on his project! I can't stress enough how great this
achivment is. He even added very good API documentation to his classes :)
This requires the lastest version of qt-copy, otherwise you'll get mysterious crashes in Qt painting code from time to time.
We hope that this patch will be added to the next Qt 4.4.x version.
And finally, this merge also brings many regressions, which is not unnatural for such a big change.
In the remaining time before the KDE 4.2 release, we'll have to work on those to get it polished and regression-free.
Help here is always needed, and is a good opportunity to start working on KMail, since many regressions are low hanging fruit.
It also means the message list and the folder tree need a bit of testing.
If you find bugs, report them under the "new message list" and "new folder tree" component of the bug tracker, thanks.
I also plan to setup a wiki page with known regressions.
CCMAIL: kde-pim@kde.org
GUI:
CCBUG: 117808
BUG: 163469
FEATURE: 18170
FEATURE: 32400
FEATURE: 42107
FEATURE: 45526
FEATURE: 81272
FEATURE: 90142
FEATURE: 107450
(and probably many others)
svn path=/trunk/KDE/kdepim/; revision=881321
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/KDE/4.1/kdepim
........
r870423 | tmcguire | 2008-10-12 16:12:02 +0200 (Sun, 12 Oct 2008) | 5 lines
Backport r868195 by tmcguire from trunk to the 4.1 branch:
Fix some suspicious code issues, found by Christoph Bartoschek, thanks!
........
svn path=/branches/kdepim/enterprise4/kdepim/; revision=870469
Move that code a bit more down, so that folder is also known when the
message has no target folder.
Thanks to my assert which detected that and for dimsuz for reporting.
svn path=/branches/KDE/4.1/kdepim/; revision=836581
Some fixes for online IMAP filtering:
- In the action scheduler, don't error out when the filtered message
couldn't be moved back to the target folder. Instead, ignore the error
(but don't delete the orginal message). This fixes filtering
stopping on GMail accounts once a message was encountered that was not
moved to another folder, but stayed in the same folder (GMail prevents moving
in this case, since it thinks it is a duplicate message)
- When moving the filtered message with the action scheduler from the
temporary filter folder to the target folder, the original message wouldn't
get deleted properly.
The reason for this was that the move command thought the move failed because
a message with another serial number arrived.
Fix this by remembering the serial number (based on the message ID) when using
the action scheduler for filtering.
This fixes filters which move messages to other folders: Now the message is properly
removed from the source folder again.
- add comments and kDebug output
This does _not_ solve the following problem:
When using GMail and online IMAP, filter actions which modify the message will not have
any effect, since GMails duplicate message prevention prevents the filtered message to
be moved back to the IMAP folder.
This will not be fixed, I see no way to work around this. GMail should fix their IMAP
server instead.
Please test, I'm not sure if this is safe to backport.
CCBUG: 166150
svn path=/branches/KDE/4.1/kdepim/; revision=836580
svn+ssh://tmcguire@svn.kde.org/home/kde/trunk/KDE/kdepim
........
r834270 | tmcguire | 2008-07-18 16:28:38 +0200 (Fri, 18 Jul 2008) | 4 lines
Move that code a bit more down, so that folder is also known when the
message has no target folder.
Thanks to my assert which detected that and for dimsuz for reporting.
........
svn path=/branches/kdepim/enterprise4/kdepim/; revision=835022
svn+ssh://tmcguire@svn.kde.org/home/kde/trunk/KDE/kdepim
........
r833475 | tmcguire | 2008-07-16 23:07:56 +0200 (Wed, 16 Jul 2008) | 32 lines
Some fixes for online IMAP filtering:
- In the action scheduler, don't error out when the filtered message
couldn't be moved back to the target folder. Instead, ignore the error
(but don't delete the orginal message). This fixes filtering
stopping on GMail accounts once a message was encountered that was not
moved to another folder, but stayed in the same folder (GMail prevents moving
in this case, since it thinks it is a duplicate message)
- When moving the filtered message with the action scheduler from the
temporary filter folder to the target folder, the original message wouldn't
get deleted properly.
The reason for this was that the move command thought the move failed because
a message with another serial number arrived.
Fix this by remembering the serial number (based on the message ID) when using
the action scheduler for filtering.
This fixes filters which move messages to other folders: Now the message is properly
removed from the source folder again.
- add comments and kDebug output
This does _not_ solve the following problem:
When using GMail and online IMAP, filter actions which modify the message will not have
any effect, since GMails duplicate message prevention prevents the filtered message to
be moved back to the IMAP folder.
This will not be fixed, I see no way to work around this. GMail should fix their IMAP
server instead.
Please test, I'm not sure if this is safe to backport.
CCBUG: 166150
........
svn path=/branches/kdepim/enterprise4/kdepim/; revision=835021
- In the action scheduler, don't error out when the filtered message
couldn't be moved back to the target folder. Instead, ignore the error
(but don't delete the orginal message). This fixes filtering
stopping on GMail accounts once a message was encountered that was not
moved to another folder, but stayed in the same folder (GMail prevents moving
in this case, since it thinks it is a duplicate message)
- When moving the filtered message with the action scheduler from the
temporary filter folder to the target folder, the original message wouldn't
get deleted properly.
The reason for this was that the move command thought the move failed because
a message with another serial number arrived.
Fix this by remembering the serial number (based on the message ID) when using
the action scheduler for filtering.
This fixes filters which move messages to other folders: Now the message is properly
removed from the source folder again.
- add comments and kDebug output
This does _not_ solve the following problem:
When using GMail and online IMAP, filter actions which modify the message will not have
any effect, since GMails duplicate message prevention prevents the filtered message to
be moved back to the IMAP folder.
This will not be fixed, I see no way to work around this. GMail should fix their IMAP
server instead.
Please test, I'm not sure if this is safe to backport.
CCBUG: 166150
svn path=/trunk/KDE/kdepim/; revision=833475
svn+ssh://svn.kde.org/home/kde/trunk/KDE/kdepim
........
r817668 | winterz | 2008-06-06 17:10:17 +0200 (Fri, 06 Jun 2008) | 3 lines
fix running kjots standalone killing kontact.
as usual, dfaure (aka "The Guru") solved this for us.
........
r817696 | winterz | 2008-06-06 18:42:15 +0200 (Fri, 06 Jun 2008) | 6 lines
port newInstance() to DBus interface.
rewrite a bit to make it more consistent the other plugins.
we still have a bug though: starting akregator standalone while kontact
is running brings the Summary view forward, not the Akregator plugin.
........
r817875 | scripty | 2008-06-06 23:51:55 +0200 (Fri, 06 Jun 2008) | 1 line
SVN_SILENT made messages (.desktop file)
........
r817923 | winterz | 2008-06-07 02:53:17 +0200 (Sat, 07 Jun 2008) | 13 lines
Add UniqueAppHandler support (but it doesn't work correctly yet).
Make "New Task" from the menu work.
i18n("New Task")
fix invisibleToolbarActions
other general cleanups
Thorsten: several problems remain, including:
no ktimetracker toolbar when embedded into kontact
no ktimetracker timer in the systray when embedded into kontact
we need a DBus interface to use in the newInstance()
........
r817931 | knight | 2008-06-07 05:05:10 +0200 (Sat, 07 Jun 2008) | 4 lines
Use current locale settings when formatting the publishing date of
an article for display in the article list, with fancy rendition
of dates less than one week old (eg. "Today <time>", "Yesterday <time>")
........
r818015 | ereslibre | 2008-06-07 14:37:09 +0200 (Sat, 07 Jun 2008) | 7 lines
Tool tips are shown now. Is a pity KFileItemDelegate tries to draw different tooltips. Will talk with Fredrik to see if we can get normal tooltips using KFileItemDelegate. Anyway, QStyledItemDelegate
doesn't get us in any regressions, and works as expected.
Tool tips are only shown if the mode of view is "Icons Only".
........
r818025 | winterz | 2008-06-07 15:47:03 +0200 (Sat, 07 Jun 2008) | 3 lines
disable the newsticker summary plugin.
........
r818045 | winterz | 2008-06-07 16:51:23 +0200 (Sat, 07 Jun 2008) | 4 lines
it might help the newstickerplugin if it had the correct version.
still, we keep this plugin disabled for KDE 4.1
........
r818049 | winterz | 2008-06-07 16:53:43 +0200 (Sat, 07 Jun 2008) | 5 lines
I don't see any reason to keep a KDE 3.2 version of the akregator plugin.
but maybe I'm wrong. Frank?
........
r818068 | winterz | 2008-06-07 17:48:21 +0200 (Sat, 07 Jun 2008) | 2 lines
change the weight so feeds shows up under to-do list, but above usenet.
........
r818080 | winterz | 2008-06-07 18:30:57 +0200 (Sat, 07 Jun 2008) | 7 lines
fix KJots "about" data when embedded into Kontact.
Steve: you really need to combine this and the kjots/main.cpp about data
data into 1 about and make this available to the standalone and part.
you might look at korganizer/aboutdata for example
........
r818102 | tmcguire | 2008-06-07 20:17:06 +0200 (Sat, 07 Jun 2008) | 4 lines
Store local subscription info immediately. Might help with bug 163268
........
r818122 | tmcguire | 2008-06-07 21:28:39 +0200 (Sat, 07 Jun 2008) | 7 lines
Don't crash in a debug function.
This might also fix bug 156319, although the backtrace misses the
last function it it.
........
r818123 | tmcguire | 2008-06-07 21:34:03 +0200 (Sat, 07 Jun 2008) | 3 lines
tabs--
SVN_SILENT
........
r818126 | tmcguire | 2008-06-07 22:01:16 +0200 (Sat, 07 Jun 2008) | 6 lines
When the config file says the folders patch is .kde/share/apps/kmail/mail, but that
doesn't exist, try .kde4/share/apps/kmail/mail instead, as some distros change KDEHOME
to .kde4.
I myself made that error when migrating my data, and some others as well.
........
r818181 | toma | 2008-06-08 03:24:44 +0200 (Sun, 08 Jun 2008) | 2 lines
Reinstate the integrity() function from mailody3, ported to akonadi. This should make the resource fetch the mail based on uidnext and uidvalidity checks. Basically means that it can now do the 'checkmail' properly and efficiently. Too bad Akonadi does not seem to call retrieveItems( const Akonadi::Collection & col ) on the intervals. I might be missing something.
........
r818274 | tstaerk | 2008-06-08 09:02:15 +0200 (Sun, 08 Jun 2008) | 5 lines
Renaming KArm to ktimetracker. Now that this is consistent, also the
"new task" functionality works.
BUGS:162725
CCBUGS:125862
........
r818294 | tstaerk | 2008-06-08 10:49:55 +0200 (Sun, 08 Jun 2008) | 1 line
Allow the user to name a task as he likes.
........
r818298 | tstaerk | 2008-06-08 11:05:48 +0200 (Sun, 08 Jun 2008) | 5 lines
Renaming KArm to ktimetracker. As this is now consistent, also the
toolbars work.
BUGS:162724 162726
CCBUGS:125862
........
r818299 | tstaerk | 2008-06-08 11:12:47 +0200 (Sun, 08 Jun 2008) | 1 line
Have the icons in the 'main bar'
........
r818339 | osterfeld | 2008-06-08 13:09:03 +0200 (Sun, 08 Jun 2008) | 1 line
return data for EditRole
........
r818341 | toma | 2008-06-08 13:13:30 +0200 (Sun, 08 Jun 2008) | 2 lines
When there is an error in selecting the mailbox, don't lock up.
........
r818344 | gberg | 2008-06-08 13:31:10 +0200 (Sun, 08 Jun 2008) | 1 line
Fix issue with text not wrapping on first page of anti-spam wizard.
........
r818346 | osterfeld | 2008-06-08 13:42:41 +0200 (Sun, 08 Jun 2008) | 2 lines
add sort role, to fix sorting of fancy dates
remove old ArticleListView impl
........
r818352 | toma | 2008-06-08 14:04:34 +0200 (Sun, 08 Jun 2008) | 2 lines
Add a noselect attribute. This way we can prevent accessing a folder which has this property on the server. This prevents useless server roundtrips.
........
r818355 | gberg | 2008-06-08 14:08:51 +0200 (Sun, 08 Jun 2008) | 1 line
Fix image in the anti-spam and anti-virus wizards so they don't move and the frame doesn't resize around them when resizing the dialog.
........
r818362 | tmcguire | 2008-06-08 14:24:51 +0200 (Sun, 08 Jun 2008) | 2 lines
Also disable the filter actions in the toolbar when no message is selected.
........
r818365 | osterfeld | 2008-06-08 14:28:16 +0200 (Sun, 08 Jun 2008) | 1 line
fix author column: store author name, email, url separatedly instead of storing it as HTML
........
r818383 | toma | 2008-06-08 15:12:31 +0200 (Sun, 08 Jun 2008) | 2 lines
In the past we did nothing if the message count in mailody matched the amount on the imap server. Now we need to emit a signal that we are done. Another lockup bytes the dust.
........
r818395 | tmcguire | 2008-06-08 15:48:06 +0200 (Sun, 08 Jun 2008) | 7 lines
Don't assert when the password entered is empty.
The password dialog is still shown too many times, but at least
it doesn't crash anymore.
........
r818405 | tmcguire | 2008-06-08 16:10:38 +0200 (Sun, 08 Jun 2008) | 4 lines
Make sure "Starting..." and "Opening Url.." disappear from the status bar again
after two seconds.
........
r818418 | winterz | 2008-06-08 16:26:16 +0200 (Sun, 08 Jun 2008) | 2 lines
not "context", but "comment" property
........
r818421 | msoeken | 2008-06-08 16:29:55 +0200 (Sun, 08 Jun 2008) | 2 lines
Use QStyledItemDelegate and QStyle::drawControl to correctly paint the background of the percentage column.
........
r818437 | tmcguire | 2008-06-08 17:01:20 +0200 (Sun, 08 Jun 2008) | 4 lines
- Make sure that the toolbar filter actions are also disabled right after starting up
- Remove some code that doesn't seem to do anything meaningful
- Put the last line of one function back as the last line
........
r818438 | krake | 2008-06-08 17:03:14 +0200 (Sun, 08 Jun 2008) | 3 lines
Put phone number widgets into a scrollarea and make sure the area can display the initial three without scrollbar.
Fixes an issue discovered during Krush day 2 (widgets being reduced in height when new phone numbers are added)
........
r818440 | tmcguire | 2008-06-08 17:10:58 +0200 (Sun, 08 Jun 2008) | 2 lines
Install the RC file, looks like this was removed by accident in r813516.
........
r818452 | mleupold | 2008-06-08 17:42:39 +0200 (Sun, 08 Jun 2008) | 2 lines
Made the dialog smaller to fit the KCMultiDialog's size on small resolutions.
........
r818456 | aacid | 2008-06-08 17:59:39 +0200 (Sun, 08 Jun 2008) | 2 lines
remove typo spotted by Soenke Dibbern
........
r818459 | tmcguire | 2008-06-08 18:10:26 +0200 (Sun, 08 Jun 2008) | 4 lines
Slightly better place to update the actions, now also works after running the
anti spam wizard.
Also, update all actions, not just those in the toolbar.
........
r818460 | krake | 2008-06-08 18:11:22 +0200 (Sun, 08 Jun 2008) | 2 lines
Fixing enable/disable state tracking depending on selection.
........
r818468 | osterfeld | 2008-06-08 18:30:21 +0200 (Sun, 08 Jun 2008) | 2 lines
convert to plaintext also when updating the title cache
........
r818469 | tmcguire | 2008-06-08 18:30:27 +0200 (Sun, 08 Jun 2008) | 4 lines
Don't crash when inline-forwarding multiple mails.
........
r818491 | mleupold | 2008-06-08 18:59:57 +0200 (Sun, 08 Jun 2008) | 2 lines
Made the Composer config dialog smaller to fit small resolutions.
........
r818511 | skelly | 2008-06-08 19:34:04 +0200 (Sun, 08 Jun 2008) | 3 lines
Move the about data in KJots to a standalone class instead of repeating the information.
........
r818517 | tstaerk | 2008-06-08 19:40:39 +0200 (Sun, 08 Jun 2008) | 4 lines
Understand the starttime in an iCalendar file.
BUGS:163526
........
r818532 | krake | 2008-06-08 20:33:46 +0200 (Sun, 08 Jun 2008) | 13 lines
QList::erase changes end() so caching it resulted in a crash.
Reported during Krush day as
"katastrophe 14:14, 8 June 2008 (CEST) crash if you make a new distribution list and change its name, then click ok"
Actually already crashes when creating a new distribution list and keeping the default name.
Most likely introduced during Qt4 porting, e.g. different behavior or Qt3's QValueList and Qt4's QList regarding erase() and/or end()
so it could be somewhere else as well.
........
r818574 | toma | 2008-06-08 22:36:51 +0200 (Sun, 08 Jun 2008) | 2 lines
dont deadlock on entering a folder with no new messages.
........
r818605 | ereslibre | 2008-06-09 01:02:05 +0200 (Mon, 09 Jun 2008) | 6 lines
The sidebar needed lots of intrinsec logic for working properly. This fixes the problem of a huge sidebar when the environment is clean (aka. "new user" test). This also fixes some problems with
layouts. Now the sidebar will automagically adopt the needed size, and the only thing one can do with the slider is to hide or show it. I have double reviewed it is correct with the kde pim coding
style, but if something is wrong, please tell me.
........
r818606 | winterz | 2008-06-09 01:10:28 +0200 (Mon, 09 Jun 2008) | 2 lines
minor style changes (line length <= 100)
........
r818612 | djarvie | 2008-06-09 02:20:36 +0200 (Mon, 09 Jun 2008) | 1 line
Prevent quitIf() calling quitIf()
........
svn path=/branches/kdepim/enterprise4/kdepim/; revision=818683
svn+ssh://svn.kde.org/home/kde/trunk/KDE/kdepim
........
r816688 | thrainer | 2008-06-04 17:38:42 +0200 (Wed, 04 Jun 2008) | 4 lines
Style.
SVN_SILENT:
........
r816720 | winterz | 2008-06-04 18:51:41 +0200 (Wed, 04 Jun 2008) | 6 lines
init() before the ActionManager is initialized.
must do this because the componentData needs to be set beforehand
so we don't get warning messages like:
"KActionCollection::setComponentData: this does not work on a KActionCollection
containing actions!"
........
r816746 | bbroeksema | 2008-06-04 20:24:01 +0200 (Wed, 04 Jun 2008) | 2 lines
HHCategory is actually saved to the mapping file now. Added test for it.
........
r816750 | tmcguire | 2008-06-04 20:35:05 +0200 (Wed, 04 Jun 2008) | 3 lines
KTextEdit -> KRichTextWidget
C++ needs a 'super' keyword like in Java...
........
r816762 | bbroeksema | 2008-06-04 21:10:22 +0200 (Wed, 04 Jun 2008) | 3 lines
PC categories are now also saved in the mapping files.
Added some tests for it.
........
r816803 | tstaerk | 2008-06-04 22:05:18 +0200 (Wed, 04 Jun 2008) | 1 line
Show the user what unit the duration is in.
........
r816878 | winterz | 2008-06-04 23:21:41 +0200 (Wed, 04 Jun 2008) | 6 lines
Raphael's new sidebar port to Qt4 itemviews.
This does include a couple of very short, new strings.
But I received no objections from the translators.
........
r816888 | ereslibre | 2008-06-04 23:44:17 +0200 (Wed, 04 Jun 2008) | 2 lines
Fix canDecodeMimeData on plugins. This way for example, we can't drop an URL dragged from Konqui to Contacts plugin.
........
r816891 | rjarosz | 2008-06-04 23:49:29 +0200 (Wed, 04 Jun 2008) | 3 lines
Dispatcher::registerComponent can't take SLOT(slotName) as slotName argument.
........
r816901 | tmcguire | 2008-06-05 00:13:08 +0200 (Thu, 05 Jun 2008) | 11 lines
- Return the correct return code when not all messages could be moved in KMMoveCommand
- In the action scheduler, don't delete the original mail if the filtered copy couldn't
be moved back
This is a hotfix for IMAP, which will eat messages if one of the filters has online IMAP
target folder (in which case the action scheduler will be used).
The real problem is of course that the move command fails in the frist place, will have to
figure that out later.
........
r817026 | scripty | 2008-06-05 04:27:16 +0200 (Thu, 05 Jun 2008) | 1 line
SVN_SILENT made messages (.desktop file)
........
svn path=/branches/kdepim/enterprise4/kdepim/; revision=817055
- In the action scheduler, don't delete the original mail if the filtered copy couldn't
be moved back
This is a hotfix for IMAP, which will eat messages if one of the filters has online IMAP
target folder (in which case the action scheduler will be used).
The real problem is of course that the move command fails in the frist place, will have to
figure that out later.
svn path=/trunk/KDE/kdepim/; revision=816901
Listen to the closed() and expunged() signals of the temporary filter folder (mSrcFolder), so that we can re-open the folder whenever it was closed.
This fixes the problem that filtering with online IMAP stopped after the first message had been processed.
CCBUGS: 126182
svn path=/trunk/KDE/kdepim/; revision=776110
https://vkrause@svn.kde.org/home/kde/branches/KDE/3.5/kdepim
........
r773384 | kloecker | 2008-02-10 23:44:50 +0100 (Sun, 10 Feb 2008) | 6 lines
Listen to the closed() and expunged() signals of the temporary filter folder (mSrcFolder), so that we can re-open the folder whenever it was closed.
This fixes the problem that filtering with online IMAP stopped after the first message had been processed.
CCBUGS: 126182
........
svn path=/branches/kdepim/enterprise/kdepim/; revision=773733
This fixes the problem that filtering with online IMAP stopped after the first message had been processed.
CCBUGS: 126182
svn path=/branches/KDE/3.5/kdepim/; revision=773384
for the new kDebug/kError/kWarning/kFatal syntax.
You can use the following command to find 'old' code:
egrep -r -A 5 '(kDebug|kError|kWarning|kFatal).*' * | grep -v ".svn" | grep "<< *endl;"
svn path=/trunk/KDE/kdepim/; revision=695781
Laurent Montel
Andras Mantia
Thomas McGuire
Allen Winter
Andrew Coles
Ingo Klcker
Olivier Goffart
Marc Mutz
Jarosaw Staniek
Volker Krause
Frank Osterfeld
Andreas Hartmetz
Tobias Koenig
Daniel Molkentin
Pradeepto Bhattacharya
Dirk Mueller