and the ListJob takes care of the kids. I extended the slotAbortRequested so that it works correctly.
Anybody willing to port this to dimap?
svn path=/trunk/kdepim/; revision=320011
to libkdepim. Removed dependency on KMMainWidget by using a signal from ProgressDialog.
This also fixes the bug Till reported, where closing the progressdialog with
the cross wouldn't make the arrow look up again.
svn path=/trunk/kdepim/; revision=316885
ProgressItems. Add some Q_ASSERTS a la David. Remove the now unused
method. Make message up- and download cancellable.
One remaining issue: displayProgress() was (ab)used to reset the idle
timeout, which eventually disconnects the slave. Where should this
resetting be done now? In the ImapJob dtor, maybe?
svn path=/trunk/kdepim/; revision=313541
and Subject of the message, so that it's possible to know which one it's about.
CCMAIL: 60384-done@bugs.kde.org, 81309@bugs.kde.org
svn path=/trunk/kdepim/; revision=310391
instead of "on exit" (which made it non-working in kontact, with session management etc.)
GUI: removed the "Warn before expiring messages" and "On Exit: Expire old messages" options.
Tasks are filed with the jobscheduler, and the job for that task is started
only if the folder isn't opened - so this needed some special handling of search
folder (asking them to try releasing a given folder) and some fixes relative to
open() and close() calls, in kmfoldercachedimap and kmfoldersearch in particular.
Don: please check the kmfoldersearch.cpp changes, in particular the added close()
CCMAIL: sanders@kde.org
svn path=/trunk/kdepim/; revision=310272
base class. Port all users of slotSlaveError to that, so we now have
continue/cancel for errors with online imap as well. Also give context
for error messages to make them a little more descriptive. Make sure that
the jobs are removed only in non-error paths, because the error handler
does that as well now.
svn path=/trunk/kdepim/; revision=306243
job continue in the background but delete it, it's not needed anymore.
Make sure the imapjob dtor cleans up associated KIO jobs if they are still
around and resets the progress thingie etc.
We can't really keep the server from answering already sent queries
completely, but we can discard as much of the infrastructure as possible,
to keep things snappy.
svn path=/trunk/kdepim/; revision=300844
o Enable the expiry settings in the folder properties for imap and dimap
folders.
o Add some folderjob infrastructure to imapjob and cachedimapjob along the
way.
o Fix a few folderstorage crashes waiting to happen.
Only manual expiry of imap/dimap folders is hooked in, but we could just
as well hook the imap and dimap foldermanagers into the autoexpiry on
shutdown thingie. For dimap that should be as safe or unsafe as for maildir
and for imap it's as save or unsafe as deleting a bunch of messages and
immediately closing KMail. Opinions?
This commit is dedicated to the hardest working man in show business,
S. Kulow whose birthday it is today.
Let's give it up for the man:
o/` For he's a jolly good RD, for he's a jolly good RD, for he's a jolly
good RD ... which nobody can't deny .. o|`
CCMAIL: 48189-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=290404
account are killed. Happens on disconnect, for example.
Jens, thanks for reporting this.
CCMAIL: 75064-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=288326
You don't need getMsg anymore for the UID and LOD can check the size without loading the header.
I updated the online imap folder but dimap should also use the new code.
svn path=/trunk/kdepim/; revision=288206
in getMsg broke things. As the msgLength is not saved in the index I have to take a different approach to override LOD for
small messages: after the header was downloaded we check the size again and then fall back to loading "TEXT".
CCMAIL: 72432-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=279791
flag. Instead, explicitly set the message to read (set \seen flag) on the
server when it is marked as read locally. The reasons being:
o the local and remote status don't go out of sync leading to incorrect
unread counts
o it makes using the same imap account with multiple clients possible
o fixes a couple of bugs with the external reader window as a side effect
CCMAIL: 71596-done@bugs.kde.org
CCMAIL: 65005-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=277411
For these messages the additional server roundtrips slow things down. Nice side effect: the msg size is displayed correctly
in the mimetree. Messages that are already in your folder will be loaded with lod the first time because the size is unknown.
After that (and for all new messages) this should work as expected.
Happy New Year :-)
svn path=/trunk/kdepim/; revision=275786
full server roundtrip for each mail but processing them in chunks according
to their target set of flags. This is especially noticeable with "mark all
as read" on a large folder. That goes from minutes to seconds.
svn path=/trunk/kdepim/; revision=275461
The result is that msgs with only one part (text) are not updated anymore and multipart msgs only once or twice.
The remaining bit of a flicker with multipart is only due to the fact that the msg has to be repainted
so I doubt that there is much we can do about that.
svn path=/trunk/kdepim/; revision=269051
active readerwindow to ask that for the attachmentstrategy but pass it
along with the folder job, so it is available when the mime structure
comes in with load on demand. Remove unused KMKernel::activeReaderWindow
which doesn't work in kontact anyhow.
CCMAIL: 67644-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=268877
o make imapjobs refcount the folders they operate on via open/close instead
of relying on the account to keep track of open folders and close them
in displayProgress()
o keep not only the destination but also the source folder in each imapjob
so they can be closed if need be
o remove tempOpenFolder() itself and all its uses
svn path=/trunk/kdepim/; revision=244918
calling open() once and close() in all code paths, including error paths.
Also make sure that folders are closed if a job is canceled.
svn path=/trunk/kdepim/; revision=244640
- Delete messages during transfer
- Minor cleanups
- Do not display headers when you skip over messages
CCMAIL: 62943-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=243659
Carsten Burghardt
David Faure
Till Adam
Laurent Montel
Ingo Klcker
Marc Mutz
Zack Rusin