Warning: If you have been using rev. 689148 or higher, you need to manually run kconf_update before starting KMail or you will lose your account settings. See kmail.upd for details.
svn path=/trunk/KDE/kdepim/; revision=689633
Now, we use enums instead of strings.
Add the names of the types to KAccount. They can now be translated.
Also, provide an update script for easy config migration.
BUG: 90509
svn path=/trunk/KDE/kdepim/; revision=689148
SVN commit 665551 by coolo:
somehow the fix was forgotten - patch by dirk:
with the recent utf8 decoder fix in Qt (CVE-2007-0242), kmail
fails to restore passwords with '!' correctly from kconfig.
svn path=/branches/kdepim/enterprise/kdepim/; revision=669329
KShellProcess -> K3ShellProcess
KProcIO -> K3ProcIO
KProcessController -> K3ProcessController
not deprecating, as we don't have a replacement yet.
not moving yet, as kdelibs still has heavy dependencies on it.
agreed upon with dfaure.
svn path=/trunk/KDE/kdepim/; revision=646732
assert( mFolder ); // George says "better to crash then lose mail"
The configuration dialog creates temporary copies of the account when modifying one;
but it doesn't delete that copy when closing with Cancel. What's more, the copied account
started its own timer for interval-mail-checking, and when that timer fired, KMAcctCachedImap
would crash due to mFolder=0. So:
1) delete things in the dtor to avoid the account memleak
2) don't start the mailcheck timer when simply setting the checkinterval of an account,
only when the account is added to the AccountManager for real.
(#117935)
svn path=/trunk/KDE/kdepim/; revision=631941
assert( mFolder ); // George says "better to crash then lose mail"
The configuration dialog creates temporary copies of the account when modifying one;
but it doesn't delete that copy when closing with Cancel. What's more, the copied account
started its own timer for interval-mail-checking, and when that timer fired, KMAcctCachedImap
would crash due to mFolder=0. So:
1) delete things in the dtor to avoid the account memleak
2) don't start the mailcheck timer when simply setting the checkinterval of an account,
only when the account is added to the AccountManager for real.
BUG: 117935
svn path=/branches/KDE/3.5/kdepim/; revision=631934
account manager into NetworkAccount, and add a virtual
mailCheckCanProceed() which defaults to true and which aforementioned
NetworkAccount reimplements to return false if the maximum number of
connections is exceeded and (after Matt has added his bit) when we are
in offline mode. The map is static in NetworkAccount, since there could
be more than one account on the same server, so per account is not what
we want.
svn path=/trunk/KDE/kdepim/; revision=437969
incoming messages from IMAP accounts, that is messages that are delivered
into an IMAP inbox folder.
Sundry details:
I've modified these files:
kmfilterdlg.h kmfilterdlg.cpp
To add the advanced tab that allows per account filters
kmfilter.h kmfilter.cpp
I've added some new functions to KMFilter
setApplicability( AccountType )
AccountType applicability()
setApplyOnAccount( uint id, bool aApply )
bool applyOnAccount( uint id )
and an enum
enum AccountType { All, ButImap, Checked }
kmfiltermgr.h kmfiltermgr.cpp
I modified KMFilterMgr::process
to take two optional parameters
bool account = false
uint accountId = 0
and changed the implementation so that when these
params are set per account filtering is applied.
kmaccount.cpp
Trivially to use the new per account filtering.
kmacctimap.h kmacctimap.cpp
For 3 main reasons
1) In the case (it checks) that a filter applies to this
imap account, then incoming mails headers are
downloaded when mail checking occurs. Rather than waiting
until the folder is selected in the GUI.
Because it's really silly to have to select the inbox
folder to manually force filtering to kick in.
2) To load/save a list of unfiltered messages in the
constructor/destructor respectively.
3) To filter messages (I've sort of duplicated a little code
from kmheaders.cpp for this, my apologies).
kmfolderimap.cpp
1) To tell mAccount to filter new mail as the headers arrive.
This is basically the patch I've sent to bug:50997 several times and
has been available for testing for some time.
I'll now focus on allowing IMAP folders to be the target of the
Move Into Folder filter action, and less blocking filtering
(useful for piping into a spam tool).
CCMAIL:73758-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=408531
to libkdepim. Removed dependency on KMMainWidget by using a signal from ProgressDialog.
This also fixes the bug Till reported, where closing the progressdialog with
the cross wouldn't make the arrow look up again.
svn path=/trunk/kdepim/; revision=316885