were "saved" to kmailrc, but kmailrc wasn't synced, so in case of a kmail crash, X crash, power failure, kernel oops...
the settings would be lost, and on the next kmail restart very strange errors would happen when syncing
(can't create folder, folder already there, folder missing, etc.)
The solution: sync(). But while being at it I implemented buffering of sync requests
which was a TODO in kmkernel, but did it in GlobalSettings as Till suggested;
which in turn means we need our own GlobalSettings inheriting GlobalSettingsBase,
and the code lacked ::self()-> in many places to allow that.
svn path=/branches/kdepim/proko2/kdepim/; revision=432536
SVN commit 424363 by tilladam:
Don't allow operations to be performed on items which are already
being operated on. Namely holding down the Del key was triggering
multiple Deletes/Moves for the same message pointer, which for any
but the first command was dangeling. Quite obvious, in retrospect...
svn path=/branches/kdepim/proko2/kdepim/; revision=424365
This is another important step to fix the crashes when filtering
threaded folders.
Thanks to Till for his patience in helping me to track this down.
svn path=/trunk/kdepim/; revision=401723
* The todo status, now has the same behaviour that "Important Status":
- Customize font.
- Customize colour.
- Have a column independent in headerlist.
svn path=/trunk/kdepim/; revision=399802
remain stable during the lifetime of a message. In other words, don't
crash when changing the subject header of a message which is part of
the current subject threading trees. Pfew, this one was a bugger to fix.
BUGS: 94043
svn path=/trunk/kdepim/; revision=390027
by using a heap allocated SortCacheItem to represent the list view root
during threading even after the initial building of the trees. Add debugging
helpers for printing out the tress. (Yes, I'm hunting the filtering crash
with Andreas.)
svn path=/trunk/kdepim/; revision=388289
dialog and include it in the RMB menu of the foldertree. To make the check if the menu
should be shown a bit easier the folderstorage got a new "isMoveable()" function.
I noticed that moving of imap folders crashes again when the messages are moved (sigh)
but this is not related so I'll fix it afterwards.
svn path=/trunk/kdepim/; revision=385541
Fix at least one of the reasons for the infamous "suddenly the
headers list is empty", also known as the "QGArray::at: Absolute index
n out of range" issue, by making sure that the quick search is only
updated after a new list view item has been completed added, not right
after the KListViewItem ctor, where we don't have valid folder index
entries in the header list items yet, which the status quick search needs.
svn path=/branches/KDE_3_3_BRANCH/kdepim/; revision=382067
Fix at least one of the reasons for the infamous "suddenly the
headers list is empty", also known as the "QGArray::at: Absolute index
n out of range" issue, by making sure that the quick search is only
updated after a new list view item has been completed added, not right
after the KListViewItem ctor, where we don't have valid folder index
entries in the header list items yet, which the status quick search needs.
svn path=/branches/proko2/kdepim/; revision=382046
headers list is empty", also known as the "QGArray::at: Absolute index
n out of range" issue, by making sure that the quick search is only
updated after a new list view item has been completed added, not right
after the KListViewItem ctor, where we don't have valid folder index
entries in the header list items yet, which the status quick search needs.
CCMAIL: bastian@kde.org
svn path=/trunk/kdepim/; revision=380578
in the attempt to remove it from the tree of subject threading messages
failing and the detached child looking for a new parent finding the old
parent as the new parent, which in turn results in the child being deleted
with the old (and new) parent, which is not a good idea, since it is
still referenced.
(This is only fixing the symptom for now, not the real issue)
BUG: 94043
svn path=/trunk/kdepim/; revision=375955
mainwidget triggering moves on msgbase and msg pointers which it then
proceeded to invalidate by inadvertent calls to getMsg() via
headers->currentMsg() while updating the folder and message actions. Fix
that by triggering the action update from the completion handler of the
message moving code in KMHeaders.
This very probably fixes several reported crash bugs, but since they all
have inconclusive backtraces, I'm leaving them open for now. We'll see.
svn path=/trunk/kdepim/; revision=375412
Additionally, checking for config updates is sped up by only checking the application of new config updates instead of checking all config updates.
FEATURE: 79938
GUI:
svn path=/trunk/kdepim/; revision=372098
Adrian, would you consider an update, this is fairly annoying for users.
BUG: 94184
CCMAIL: adrian@suse.de
svn path=/branches/KDE_3_3_BRANCH/kdepim/; revision=370066
"move whole thread to trash" and "delete whole thread" with shortcuts
ctrl-Delete and ctrl-shift-Delete. I've slightly modified it to be
consistent with the other thread actions disabling/enabling and menu
structure.
Thanks, Kurt.
FEATURE: 89003
GUI:
svn path=/trunk/kdepim/; revision=368332
happens when a mail that was supposed to be downloaded could not be,
because it was no longer on the server (deleted by another client).
svn path=/trunk/kdepim/; revision=366604
BUG: 77515
Allow "Mark Message" when in drafts folder
BUG: 81711
Show "Copy" and "Select All" when text selected in message view.
BUG: 84248
Make header popup and message popup more consistent. Move delete options to bottom of menu.
svn path=/trunk/kdepim/; revision=362800
- no need to emit messageListUpdated() in msgAdded, since 3.3's KListView has it's own signal for that
- don't emit selected(0) when the message that was just highlighted has the transferInProgress flag set. That results in it not being displayed in the reader window if you quickly pass over it, so it's load gets triggered, and then go back to it
As far as I can tell there is nothing that should conceptually prevent us from telling the rest of the world that the headers list selected a message if that message is in transfer. If calling code has a problem with that, it needs to be fixed. I think this is from the time when transferInProgress was used as a crude message locking tool for imap operations.
svn path=/trunk/kdepim/; revision=360939
during filtering, as it has side effects and it's better to avoid doing
the updates in the first place. Use prepare/finishMove to do re-selection,
which centralizes that logic.
svn path=/trunk/kdepim/; revision=360773
Alt-left/right changes the current mail without selecting it, which is
very handy with online imap, since the skipped over mails won't be
downloaded. Alt-space selects the current message. This is symmetrical
to the ctrl-left/right/space handling in the folder tree.
FEATURE:
GUI:
CCMAIL: l.lunak@kde.org
svn path=/trunk/kdepim/; revision=357329
no need to reapply the search line after filtering each message (due to messageListUpdated()
being connected to KListViewSearchLine::updateSearch()).
Ingo: do you consider this safe enough to be backported?
svn path=/trunk/kdepim/; revision=356314
kmailrc, I like the status to show, and conversly, not show when it's FALSE.
(Note: I did not investigate how this impacts the "default" KMail setup when
a clean first-start happens.)
svn path=/trunk/kdepim/; revision=352912
David Faure
Till Adam
George Staikos
Andreas Gungl
Mario Teijeiro Otero
Carsten Burghardt
Volker Krause
Ingo Klcker
Stephan Binner
Paul Sprakes
Bo Thorsen
Martin Koller