Especially protocol() == "imap". Note that using ssl completely breaks those
checks then as the protocol is then "imaps". Also the string compares
are suboptimal there - use folderType() == KMFolderTypeSomeType.
svn path=/trunk/kdepim/; revision=238868
the job wasn't properly terminated, so the syncing 'state machine' was kind of stuck.
The underlying design issue is that KIO's connected slaves emit (via Scheduler) a
signal slaveError, totally unrelated to any job, and that killing the slave
kills the jobs _silently_ (without emitting result()).
As discussed with Waldo, the only way to handle this properly is to wait for the
slave to be connected (slaveConnected signal from Scheduler), before assigning
the slave to a job. I didn't rewrite all of kmail for it :) but I changed the
return value of makeConnection to be an enum: Error, Connected or Connecting.
This keeps compat with existing code which just checks it as a bool, but allows
KMFolderCachedImap to wait for the slaveConnected signal before proceeding.
Visually, this does the connection attempt at 0% progress instead of at 30%,
so it looks more logical :)
svn path=/trunk/kdepim/; revision=233801
kmacctmgr has 2 lists (currently checking and todo), the accounts care for the setting of the necessary flags.
All accounts show a transmission message, use -1 as newMailsProcessed argument to use your own message (e.g. in kmacctexppop)
svn path=/trunk/kdepim/; revision=210690
for me the "crash on reply" and "forward message crash" bugs and people
on IRC have been insisting on committing it. So yeah, asynchronous message
handling in KMail is in!!! May the God of Coding have mercy on us...
svn path=/trunk/kdenetwork/kmail/; revision=193386
show the user a wrong number of mails loaded. Currently, it shows just the
number of mails in the last account, but with this patch, it shows the
total number of mails.
I haven't tested pop3 or maildir, but they should work as the patch is quite
simple. I also didn't find a way to make it work with imap, so in case there's
an imap account, it just turns back to the current (broken) behaviour.
I waited 4 days for comments for this patch, so I think it's enough.
Btw, this fixes#38403
svn path=/trunk/kdenetwork/kmail/; revision=140766
- Don't parse /etc/services 20 times
- Don't call i18n("inbox") 250 times
- Don't look for an utf7 QTextCodec 200 times
svn path=/trunk/kdenetwork/kmail/; revision=134842
some servers have some issues with EXAMINE.
- Check for new mails with FETCH instead of STATUS. This doesn't require to
close the current mailbox and works around a bug in the Courier server.
- Don't execute useless commands, when listing the folder names
svn path=/trunk/kdenetwork/kmail/; revision=126333
- Don't check for an external application modified the cache file while KMail
was running
- Prevent a qWarning about an null hash key
- Remove a kdDebug call
Altogether IMAP header retrieving is now twice as fast as before.
svn path=/trunk/kdenetwork/kmail/; revision=118800