KConfigBase:
- remove separator argument from list entry reading/writing functions
- introduce {read,write}XdgListEntry()
- kill readPathListEntry(), add readPathEntry() overload
instead. the default value is not optional any more, as it defines the
return type. this is consistent with the readEntry() functions.
- rename clean() => markAsClean(), remove rollback()
- rename ConfigState => AccessMode, getConfigState() => accessMode()
- rename {entry,group}IsImmutable() => is{Entry,Group}Immutable()
- remove NLS alias to Localized
KConfig:
- remove setGroup() & group()
- reshuffle OpenFlag enum, introduce NoCascade for symmetry
- remove setExtraConfigFiles() alias to addConfigSources()
KConfigGroup:
- inherit KConfigBase::deleteGroup() overloads
- make convertToQVariant() private, it will probably change somehow
- KConfig & KConfigGroup: deprecate entryMap()
- remove bogus declarations: KConfigGroup::setReadDefaults(),
KConfig::readEntryUntranslated()
- apidox
- reshuffle the declarations in the headers
svn path=/trunk/KDE/kdepim/; revision=728852
Forward port of:
>SVN commit 633411 by adridg
>mIndexStreamPtrLength comes from struct stat, should be a size_t. It *is*
>a size (of the index file) after all. Also make the size information
>available in the KMFolderIndex API and add a touch of documentation.
>We need the size information to be able to judge if a KMMsgBase
>object has index information or not.
Forward port of:
>SVN commit 633413 by adridg
>Stop KMail from crashing all the time in PIM+;
>check if the data range in the index for this message would make sense at all.
>If not, no string part. Needs r. 633411 API changes.
This is another example why having some many branches is not a good idea.
Adriaan, Ismail: Are there more unported bugfixes in the 3.5.5+ branch?
CCMAIL: groot@kde.org
CCMAIL: onurf@su.sabanciuniv.edu
svn path=/trunk/KDE/kdepim/; revision=706981
for the new kDebug/kError/kWarning/kFatal syntax.
You can use the following command to find 'old' code:
egrep -r -A 5 '(kDebug|kError|kWarning|kFatal).*' * | grep -v ".svn" | grep "<< *endl;"
svn path=/trunk/KDE/kdepim/; revision=695781
but since the difficult part is over, I hope I will improve it over time.
Currently it has the following features:
- Ability to tag emails (with possibly more than one tag)
- Changing the appearance of message headers (font and text color) according to the message's tags.
- Configuration of tags through a new tab called "Message Tags" on the "Configure KMail->Appearance" configuration page.
- You can add toolbar buttons for easy tagging.
- You can assign shortcuts to tags.
- Tagging through the right-click menu.
- Quick filtering using the combobox for "status" filtering. See the screenshot.
Some short-term todos:
- Incorporate Nepomuk
- A column for tags in the header view
- Incorporate Ellen's usability comments
Some long-term todos:
- Filter action for automatic tagging
- Searching based on tags ( which enables having 'tag folders' through use of search folders )
I'm sorry that I didn't have enough time to test my current commit completely. In the last two days, I have been constantly compiling
kdelibs, kdepimlibs, kdebase to keep up with very frequent changes. I finally was able to compile all at once:)
BUGS: 50409
CCBUG: 15391, 122977
svn path=/trunk/KDE/kdepim/; revision=692089
SVN commit 654636 by mkoller:
BUG#50462
I dare to close this bug report with this commit.
It basically automatically recreates the index whenever a "should never
happen" situation occurs in getting data from the index and retries to get
the requested information.
I hope it works as advertised
svn path=/branches/kdepim/enterprise/kdepim/; revision=668925
The cause for this crash was an out-of-bounds array access.
The same problem is in KMail in 3.5 branch, but it doesn't crash. I think Qt4 introduced a new assert when accessing a QString.
svn path=/trunk/KDE/kdepim/; revision=667702
SVN commit 633071 by winterz:
merge SVN commit 632062 by adridg:
After updating KMail and throwing away index files, I encountered a file which has charset= set, and that triggered
a QGList warning when subscripting an empty string; adding this extra check for empty charsets stops crashing after
that warning.
SVN commit 633069 by winterz:
merge SVN commit 632089 by adridg:
TRUE and FALSE are C-isms, use C++ keywords instead
merge SVN commit 632360 by adridg:
Indentation style is spaces; there's crashes in here occasionally after removing index files, rather peculiar.
svn path=/branches/kdepim/enterprise/kdepim/; revision=667618
- Check the codec returned by KMMsgBase::codecForName() for being NULL and fallback to kmkernel->networkCodec() in this case.
svn path=/trunk/KDE/kdepim/; revision=656744
I dare to close this bug report with this commit.
It basically automatically recreates the index whenever a "should never
happen" situation occurs in getting data from the index and retries to get
the requested information.
I hope it works as advertised ;-)
svn path=/trunk/KDE/kdepim/; revision=654760
I dare to close this bug report with this commit.
It basically automatically recreates the index whenever a "should never
happen" situation occurs in getting data from the index and retries to get
the requested information.
I hope it works as advertised ;-)
svn path=/branches/KDE/3.5/kdepim/; revision=654636
Backport port of ...
SVN commit 645625 by pradeepto:
kolab/issue1583 - Fixing OL compatibility with attachments that have umlauts in the filename.
Volker's patch worked really awesome. Thanks Volker.
svn path=/branches/kdepim/proko2/kdepim/; revision=645630
forward port SVN commit 614058 by kainhofe
Make RFC 2231-encoded attachment names work. Patch approved by Ingo (the issues he had were corrected).
RFC 2231 defines an enhanced encoding for attachment filenames, and thunderbird
apparently implemented this encoding. RFC 2231 allows one field to be split
across multiple numbered entries of the form fieldname*0=....;
fieldname*1=...; fieldname*2=...; or fieldname*0=....; fieldname*1=...; fieldname*2=...;
All these entries first need to be concatenated to form the full value of the field.
Here's a real-life example:
--------------060807060608070200030605
Content-Type: application/vnd.ms-excel;
name*0*=ISO-8859-15''%41%46%42%D6%20%42%65%73%65%74%7A%75%6E%67%73%6C%69;
name*1*=%73%74%65%20%53%74%61%6E%64%20%32%30%30%36%2D%31%32%2D%31%39%2E;
name*2*=%78%6C%73
Content-Transfer-Encoding: base64
Content-Disposition: inline;
filename*0*=ISO-8859-15''%41%46%42%D6%20%42%65%73%65%74%7A%75%6E%67%73%6C;
filename*1*=%69%73%74%65%20%53%74%61%6E%64%20%32%30%30%36%2D%31%32%2D%31;
filename*2*=%39%2E%78%6C%73
As a result, KMail shows %39%2E%78%6C%73 as the file name in both the message
preview panel as well as in the mime tree.
With this patch, KMail correctly shows the proper filename.
The patch adds one static method to collect all parts of rfc 2231-encoded
params into one single string. That method is then used in two different
places for the name and the filename props.
One minor problem remains, though: As the mime library does not have support
for rfc2231 encoded attachments, the message is not shown with the attachment
icon in the message list.
svn path=/trunk/KDE/kdepim/; revision=641088
TRUE and FALSE are C-isms, use C++ keywords instead
merge SVN commit 632360 by adridg:
Indentation style is spaces; there's crashes in here occasionally after removing index files, rather peculiar.
svn path=/branches/KDE/3.5/kdepim/; revision=633069
RFC 2231 defines an enhanced encoding for attachment filenames, and thunderbird
apparently implemented this encoding. RFC 2231 allows one field to be split
across multiple numbered entries of the form fieldname*0=....;
fieldname*1=...; fieldname*2=...; or fieldname*0=....; fieldname*1=...; fieldname*2=...;
All these entries first need to be concatenated to form the full value of the field.
Here's a real-life example:
--------------060807060608070200030605
Content-Type: application/vnd.ms-excel;
name*0*=ISO-8859-15''%41%46%42%D6%20%42%65%73%65%74%7A%75%6E%67%73%6C%69;
name*1*=%73%74%65%20%53%74%61%6E%64%20%32%30%30%36%2D%31%32%2D%31%39%2E;
name*2*=%78%6C%73
Content-Transfer-Encoding: base64
Content-Disposition: inline;
filename*0*=ISO-8859-15''%41%46%42%D6%20%42%65%73%65%74%7A%75%6E%67%73%6C;
filename*1*=%69%73%74%65%20%53%74%61%6E%64%20%32%30%30%36%2D%31%32%2D%31;
filename*2*=%39%2E%78%6C%73
As a result, KMail shows %39%2E%78%6C%73 as the file name in both the message
preview panel as well as in the mime tree.
With this patch, KMail correctly shows the proper filename.
The patch adds one static method to collect all parts of rfc 2231-encoded
params into one single string. That method is then used in two different
places for the name and the filename props.
One minor problem remains, though: As the mime library does not have support
for rfc2231 encoded attachments, the message is not shown with the attachment
icon in the message list.
BUG:108091
BUG:113100
svn path=/branches/KDE/3.5/kdepim/; revision=622052
Suppose headers charset from content-type header if headers not
properly encoded. If content-type charset is "us-ascii", use "utf-8"
instead. Write maildir and mbox indexes in right encoding.
BUGS:98079
svn path=/branches/KDE/3.5/kdepim/; revision=614058
Backporting lots of stuff from 3.5
Better KPaintInfo struct.
New helper methods from 3.5
Changes to context menu in mainwidget.
TODO: test painting of the leftmost column on a different
machine.
#1 Check if ToDo Icon is present or not.
#2 Check if the painting is borked or not.
svn path=/branches/kdepim/proko2/kdepim/; revision=556100
530060:
--------------
Fix the following problems as indicated by Christoph Bartoschek in kde-pim:
- kmail/imapjob.cpp:240
- kmail/imapjob.cpp:262 (similar)
If account is NULL as indicated by line 226, then line 240 crashes.
- kmail/imapjob.cpp:104
If msg_parent is NULL as indicated by line 90, then line 104 crashes.
530074:
--------------
Second batch of fixes related to Christoph Bartoschek's report in kde-pim:
- kmail/kmfoldercachedimap.cpp:1749
If the if conditions in line 1741 and 1745 are both false, then line 1749 crashes.
- kmail/kmfoldertree.cpp:1480
If fti is NULL as indicated by line 1475, then line 1480 crashes.
- kmail/kmfoldertree.cpp:164
If mFolder is NULL as indicated by line 154, then line 154, 160 crash.
- kmail/kmfoldertree.cpp:143
If mFolder is NULL as indicated by line 136, then line 143 crashes.
- kmail/kmfoldertree.cpp:1549
If folder is NULL as indicated by line 1537, then line 1549 crashes.
The last bug is only partially fixed, the whole KMFolderTree::slotUpdateCounts(KMFolder * folder)
function could use a rewrite.
530119:
------------
Third batch of fixes related to Christoph Bartoschek's email in kde-pim:
- kmail/imapaccountbase.cpp:1102
If line 1092 gets executed and also 1102, then the second crashes.
- kmail/kmmsgdict.cpp:248
If folder is NULL as indicated by line 244, then line 248 crashes.
- kmail/kmmsgdict.cpp:214
If folder is NULL as indicated by line 208, then line 214,225, crashes.
- kmail/renamejob.cpp:64
If storage is NULL as indicated by line 57, then line 62 crashes.
Lines where the operator preference between & and == leads to an error.
- kmail/kmmsgbase.cpp:873
- kmail/kmfolderimap.cpp:876
If f is NULL as indicated by line 869, then line 876 crashes.
- kmail/kmsender.cpp:362
If sentFolder is NULL as indicated by line 340, then line 362, 367
crashes.
Thanks to Christoph for working on this.
svn path=/trunk/KDE/kdepim/; revision=532932
Jarosaw Staniek
Thomas McGuire
Oswald Buddenhagen
Frank Osterfeld
Tobias Koenig
Daniel Molkentin
Ismail Onur Filiz
Laurent Montel
Ingo Klcker
Pradeepto Bhattacharya
Allen Winter
Pino Toscano
Martin Koller
Aaron J. Seigo
Mathias Soeken
Matthias Kretz
David Faure
Reinhold Kainhofer
Tom Albers
Volker Krause