Merged revisions 877930 via svnmerge from
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim
........
r877930 | tilladam | 2008-10-30 19:06:09 +0100 (Thu, 30 Oct 2008) | 1 line
Small thing, big consequences. This missing trimmed() led to ' 35' being parsed to 0, by QString::toULong, which lost the UID in the index, which caused it to be treated as changed, uploaded, not found locally under the old UID, but not explicitely deleted and thus re-downloaded for safety reasons, in other words, random mail duplication. Epecially on index regeneration. And who knows where else. Should actually have been visible with the old index backend as well...
........
svn path=/branches/KDE/4.1/kdepim/; revision=877938
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim
........
r877930 | tilladam | 2008-10-30 19:06:09 +0100 (Thu, 30 Oct 2008) | 1 line
Small thing, big consequences. This missing trimmed() led to ' 35' being parsed to 0, by QString::toULong, which lost the UID in the index, which caused it to be treated as changed, uploaded, not found locally under the old UID, but not explicitely deleted and thus re-downloaded for safety reasons, in other words, random mail duplication. Epecially on index regeneration. And who knows where else. Should actually have been visible with the old index backend as well...
........
svn path=/trunk/KDE/kdepim/; revision=877936
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/KDE/4.1/kdepim
........
r870423 | tmcguire | 2008-10-12 16:12:02 +0200 (Sun, 12 Oct 2008) | 5 lines
Backport r868195 by tmcguire from trunk to the 4.1 branch:
Fix some suspicious code issues, found by Christoph Bartoschek, thanks!
........
svn path=/branches/kdepim/enterprise4/kdepim/; revision=870469
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim
........
r853982 | vkrause | 2008-08-28 17:31:55 +0200 (Thu, 28 Aug 2008) | 13 lines
Forwardport SVN commit 662047 by tilladam from enterprise branch:
Apply ported version of the mail loss debugging and explicit deletions patch,
which I've been developing with the help of some adventurous users. Thanks!
This tracks all deletions that happen through user actions and adds a check
to the sync making sure that only things that were explicitely deleted
are removed during sync. If unsure, the sync now re-downloads (duplicates)
instead of removing mails, which should be safer. Also adds a lot of
conditional debugging and refactors open/close to duplicate less code.
Will has a ported version of this for 3.x, which will go into pim+ shortly.
........
svn path=/trunk/KDE/kdepim/; revision=855193
Apply ported version of the mail loss debugging and explicit deletions patch,
which I've been developing with the help of some adventurous users. Thanks!
This tracks all deletions that happen through user actions and adds a check
to the sync making sure that only things that were explicitely deleted
are removed during sync. If unsure, the sync now re-downloads (duplicates)
instead of removing mails, which should be safer. Also adds a lot of
conditional debugging and refactors open/close to duplicate less code.
Will has a ported version of this for 3.x, which will go into pim+ shortly.
svn path=/branches/kdepim/enterprise4/kdepim/; revision=853982
Merged revisions 834985 via svnmerge from
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim
........
r834985 | tilladam | 2008-07-19 21:35:32 +0200 (Sat, 19 Jul 2008) | 1 line
Clean out unused code and add some more error handling.
........
svn path=/branches/KDE/4.1/kdepim/; revision=836076
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim
........
r834985 | tilladam | 2008-07-19 21:35:32 +0200 (Sat, 19 Jul 2008) | 1 line
Clean out unused code and add some more error handling.
........
svn path=/trunk/KDE/kdepim/; revision=836050
Merged revisions 829377 via svnmerge from
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim
........
r829377 | staniek | 2008-07-08 12:37:44 +0200 (Tue, 08 Jul 2008) | 4 lines
use QDir::NoDotAndDotDot flag when looking for files in maildir
(we never know how QDir::filePath() will be have on windows for paths like "foo/bar/."
........
svn path=/branches/KDE/4.1/kdepim/; revision=833923
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim
........
r829377 | staniek | 2008-07-08 12:37:44 +0200 (Tue, 08 Jul 2008) | 4 lines
use QDir::NoDotAndDotDot flag when looking for files in maildir
(we never know how QDir::filePath() will be have on windows for paths like "foo/bar/."
........
svn path=/trunk/KDE/kdepim/; revision=833908
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim
........
r813234 | vkrause | 2008-05-27 11:25:21 +0200 (Tue, 27 May 2008) | 3 lines
Make sure the folder is still open for the setStatus() call. This fixes
a crash while refreshing the DIMAP cache of a groupware sub-folder.
........
r813336 | vkrause | 2008-05-27 14:47:56 +0200 (Tue, 27 May 2008) | 3 lines
Prevent writing the sqlite index while the folder is closed and thus the
internal message list is empty.
........
r813759 | vkrause | 2008-05-28 19:12:22 +0200 (Wed, 28 May 2008) | 8 lines
Make sure we re-open the current folder after an forced close triggered
by FolderStorage::expunge().
This fixes a crash when switching between Kontact parts during a DIMAP
cache refresh. Also, the header view is now updated again during the
refresh.
Might help with Kolab issue 2697.
........
r816897 | staniek | 2008-06-04 23:57:59 +0200 (Wed, 04 Jun 2008) | 2 lines
SVN_SILENT proper filename
........
r817156 | staniek | 2008-06-05 13:58:28 +0200 (Thu, 05 Jun 2008) | 4 lines
Avoid implicit cast of -1 value (when "maximumAttachmentSize" is undefined) to uint.
This worked only by accident.
........
r817345 | tilladam | 2008-06-05 22:23:34 +0200 (Thu, 05 Jun 2008) | 2 lines
Disable the gnupg log watcher action in KMail on Windows, it's not available there.
........
r819078 | staniek | 2008-06-10 17:01:55 +0200 (Tue, 10 Jun 2008) | 10 lines
Fix positioning of the recipients editor;
do not move the child window when the parent (composer) window is moved
(unless the child looks like a popup, moving it is rather unexpected by users).
Avoid hiding parts of the window (needed especially when not using KWin),
so this is mostly Windows and MacOSX fix.
(reviewed)
........
r820276 | staniek | 2008-06-13 20:11:07 +0200 (Fri, 13 Jun 2008) | 4 lines
-better checks for results of QDialog::exec()
-better way to choose root dir path
........
r820278 | staniek | 2008-06-13 20:11:49 +0200 (Fri, 13 Jun 2008) | 2 lines
attach only if user accepted the file dialog
........
svn path=/trunk/KDE/kdepim/; revision=822563
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim
........
r812800 | tilladam | 2008-05-26 14:43:40 +0200 (Mon, 26 May 2008) | 2 lines
Don't try to write the index of a closed folder. This seems to have been a noop on the mmap'd index implementation, but wrecks havoc with the sqlite based one.
........
r812831 | vkrause | 2008-05-26 16:03:34 +0200 (Mon, 26 May 2008) | 2 lines
Make flags persistent when using the sqlite backend.
........
r812836 | osterfeld | 2008-05-26 16:07:26 +0200 (Mon, 26 May 2008) | 1 line
OS X: disable heuristic moving actions which contain "Configure" to the app menu->Preferences entry
........
r812916 | vkrause | 2008-05-26 18:04:33 +0200 (Mon, 26 May 2008) | 3 lines
Make sure we always write new messages into the index when using the
sqlite backend.
........
r813198 | vkrause | 2008-05-27 08:57:23 +0200 (Tue, 27 May 2008) | 3 lines
Fix index corruption after deleting a message and closing KMail without
changing folders before that (sqlite backend only).
........
svn path=/trunk/KDE/kdepim/; revision=821177
svn+ssh://tilladam@svn.kde.org/home/kde/trunk/KDE/kdepim
........
r812625 | tilladam | 2008-05-25 22:50:09 +0200 (Sun, 25 May 2008) | 5 lines
Make sure to reset the db id (in the sqlite index) otherwise
it will be reused in the target folder, on move, and overwrite the entry
for any existing entry at that row, thereby bringing the index out of sync
with reality.
........
svn path=/branches/kdepim/enterprise4/kdepim/; revision=812632
it will be reused in the target folder, on move, and overwrite the entry
for any existing entry at that row, thereby bringing the index out of sync
with reality.
svn path=/trunk/KDE/kdepim/; revision=812625
-use K_GLOBAL_STATIC for static data
-an attempt to fix possible crashes and "null messages appearing in folders like outbox"
Details:
M kmail/kmfolderindex_sqlite.cpp
M kmail/kmfolderindex.h
* executes "DELETE FROM messages WHERE id=.." for every for messages
with 0 serial number, especially for the outbox
* removed commented-out old impl.
M kmail/kmmessage.h
use K_GLOBAL_STATIC
M kmail/kmfoldermaildir.cpp
* minor change
M kmail/jobscheduler.cpp
M kmail/jobscheduler.h
* ~JobScheduler() use qDeleteAll() (and clear for sanity)
M kmail/networkaccount.cpp
* use K_GLOBAL_STATIC
* use value() to avoid inserting 0 values
* NetworkAccount::resetConnectionList(): use remove() instead of inserting 0
M kmail/kmmessage.cpp
* use K_GLOBAL_STATIC
M kmail/kmcommands.cpp
* KMMoveCommand::execute(): skip mesages with serial number == 0
-this avoids crashes when user tries to clean up a folder with "no subject" items
M kmail/kmmsgbase.cpp
* #ifdef code related to using_mmap when using sqlite mode
M kmail/networkaccount.h
* use QPointer<KIO::Slave> mSlave and bits for boolean members
svn path=/trunk/KDE/kdepim/; revision=809620
used for mbox storage
BTW, I think we should discuss further enabling displaying warnings about recreating outdated indices for maildir:
in sqlite mode, I've seen way too many of them, so perhaps there is a way to fix timestamps instead of displaying the warning
svn path=/trunk/KDE/kdepim/; revision=805511
to skip message "The index of folder .. seems to be out of date" for maildir folders
This can probbaly fix recently reported issues with displaying the message for maildir folders.
-int KMFolderIndex::writeMessages( KMMsgBase* msg, bool flush, FILE* indexStream ):
added overload with indexStream arg, which simplifies KMFolderIndex::writeIndex() code
and avoids dangerous side effects
(note: this apparently was not a source of problems, though)
CCMAIL:kde-pim@kde.org
svn path=/trunk/KDE/kdepim/; revision=805447
from
/branches/work/kmail-nommap (r799390..804487)
/branches/work/kdepim-nommap/kmail (r804484..804960)
The SQLite mode is currently enabled only on Windows (by KMAIL_SQLITE_INDEX define),
so on !Windows, the code for standard 'mmap' mode is compiled.
CCMAIL:kde-pim@kde.org
svn path=/trunk/KDE/kdepim/; revision=805075
- Add kWarning when index is rebuilt because it is out of date
- Add message box asking if the user really wants to manually
recreate the index
svn path=/trunk/KDE/kdepim/; revision=804158
Added a queuing mechanism to prevent several KDirSize jobs from running concurrently when several maildir folders are checked for their size.
CCBUGS: 149414
svn path=/trunk/KDE/kdepim/; revision=770314
Added a queuing mechanism to prevent several KDirSize jobs from running concurrently when several maildir folders are checked for their size.
CCBUGS: 149414
svn path=/branches/KDE/3.5/kdepim/; revision=766900
Patch by Jean-Christophe Dubois <jcd at tribudubois dot net>, thanks!
This is a backport of rev. 751307 from trunk!
svn path=/branches/kdepim/enterprise/kdepim/; revision=760353
Christophe Giboudeaux
Thomas McGuire
Till Adam
Bertjan Broeksema
Volker Krause
Jarosaw Staniek
Ingo Klcker
Allen Winter
Pradeepto Bhattacharya