Merged revisions 1023691-1023693,1023697,1023760,1023823,1023829,1023842,1023844,1023859,1023863,1023873,1023887-1023888,1023890-1023891,1023893,1023899-1023900,1023902,1023906,1023917-1023919,1023936,1023942,1023951,1024120 via svnmerge from
https://vkrause@svn.kde.org/home/kde/trunk/KDE/kdepim
........
r1023691 | dfaure | 2009-09-15 11:10:35 +0200 (Tue, 15 Sep 2009) | 2 lines
Forwardport: You must call plugActionList again in slotNewToolbarConfig, otherwise the action lists disappear. Fixes bug 207299.
........
r1023692 | tmcguire | 2009-09-15 11:13:16 +0200 (Tue, 15 Sep 2009) | 1 line
Remove unneeded code, this is done in setTimeEditorsEnabled() already, and even correctly (obeying allday setting)
........
r1023693 | tmcguire | 2009-09-15 11:14:13 +0200 (Tue, 15 Sep 2009) | 1 line
Didn't want to remove this in r1023692.
........
r1023697 | tmcguire | 2009-09-15 11:21:26 +0200 (Tue, 15 Sep 2009) | 4 lines
Set the correct time zone when setting the defaults.
This and my previous commits have the effect that when creating all day events, the time
zone is correctly shown as "Floating".
........
r1023760 | tokoe | 2009-09-15 12:27:13 +0200 (Tue, 15 Sep 2009) | 2 lines
Make the 'contacts' resource the default address book
........
r1023823 | cgiboudeaux | 2009-09-15 13:21:26 +0200 (Tue, 15 Sep 2009) | 1 line
Disable nie. Nothing uses it.
........
r1023829 | vkrause | 2009-09-15 13:27:57 +0200 (Tue, 15 Sep 2009) | 2 lines
Extract messages and use them in KMail.
........
r1023842 | cgiboudeaux | 2009-09-15 13:42:52 +0200 (Tue, 15 Sep 2009) | 1 line
Remove an obsolete check.
........
r1023844 | tokoe | 2009-09-15 13:43:39 +0200 (Tue, 15 Sep 2009) | 4 lines
Don't mix async and sync API...
BUG: 206299
........
r1023859 | tokoe | 2009-09-15 14:17:42 +0200 (Tue, 15 Sep 2009) | 5 lines
Parse a complete QDateTime object as we export time
information as well.
BUG: 207078
........
r1023863 | tokoe | 2009-09-15 14:25:28 +0200 (Tue, 15 Sep 2009) | 2 lines
Set the default address book when importing contacts
........
r1023873 | vkrause | 2009-09-15 14:46:50 +0200 (Tue, 15 Sep 2009) | 3 lines
Add a common base class for all Nepomuk feeder agents. Still more stuff
to factor out though, most prominently the initial fetching.
........
r1023887 | vkrause | 2009-09-15 15:20:05 +0200 (Tue, 15 Sep 2009) | 2 lines
Move the resource tester here, from playground/pim.
........
r1023888 | vkrause | 2009-09-15 15:26:07 +0200 (Tue, 15 Sep 2009) | 2 lines
Disable autostart agents.
........
r1023890 | vkrause | 2009-09-15 15:34:05 +0200 (Tue, 15 Sep 2009) | 2 lines
fix path
........
r1023891 | vkrause | 2009-09-15 15:38:48 +0200 (Tue, 15 Sep 2009) | 2 lines
fix yet another path
........
r1023893 | vkrause | 2009-09-15 15:47:43 +0200 (Tue, 15 Sep 2009) | 2 lines
Move iCal resource tests from playground/pim.
........
r1023899 | tokoe | 2009-09-15 16:18:33 +0200 (Tue, 15 Sep 2009) | 2 lines
link with gold
........
r1023900 | vkrause | 2009-09-15 16:19:43 +0200 (Tue, 15 Sep 2009) | 2 lines
Move Knut tests from playground/pim and make them pass again.
........
r1023902 | cgiboudeaux | 2009-09-15 16:25:34 +0200 (Tue, 15 Sep 2009) | 1 line
Goodbye nie.
........
r1023906 | vkrause | 2009-09-15 16:30:48 +0200 (Tue, 15 Sep 2009) | 5 lines
Move the IMAP and Kolab tests from playground/pim. They share quite some
stuff, therefore the IMAP one ends up here as well for now, until we
figured out how to deal with their dependencies. Also, both are disabled
by default, as they download huge QEmu images.
........
r1023917 | vkrause | 2009-09-15 17:03:31 +0200 (Tue, 15 Sep 2009) | 2 lines
New mails are no longer reported as seen.
........
r1023918 | tokoe | 2009-09-15 17:04:11 +0200 (Tue, 15 Sep 2009) | 2 lines
Add migration tool for the standard address book
........
r1023919 | vkrause | 2009-09-15 17:07:40 +0200 (Tue, 15 Sep 2009) | 2 lines
same here
........
r1023936 | cgiboudeaux | 2009-09-15 18:23:18 +0200 (Tue, 15 Sep 2009) | 1 line
We don't have to install these headers anymore.
........
r1023942 | cgiboudeaux | 2009-09-15 18:36:53 +0200 (Tue, 15 Sep 2009) | 1 line
Fix include.
........
r1023951 | cgiboudeaux | 2009-09-15 19:13:07 +0200 (Tue, 15 Sep 2009) | 1 line
KDE4_ -> KDEPIMLIBS_
........
r1024120 | robertm | 2009-09-16 05:52:18 +0200 (Wed, 16 Sep 2009) | 10 lines
Automatically start Akonadi when necessary
This adds some calls to the akonadisetupwidget that attempts to ensure that
Akonadi is available before any access to the Akonadi server. Unfortunately,
it is not a complete solution in that there is a slight possibility that
someone could deactivate the Akonadi server precisely between the check and the
access to the server. Lacking a better solution, however, this should suffice
for now.
........
svn path=/branches/work/akonadi-ports/kdepim/; revision=1024150
Merged revisions 1006327,1009651-1009655,1009718,1009900,1009912,1010797-1010800,1011669,1012389-1012391,1012860-1012861,1012896-1012897,1012899,1012986,1012993,1013179,1013202,1013217-1013218,1013222,1013227,1013306-1013307,1013321,1013634,1013642,1013660-1013661,1015357,1015455,1015826,1016388,1017775-1017776,1017789,1018128,1018244,1018261,1018764,1018768-1018769,1018898,1018907,1018922,1018924,1018950,1018958-1018959,1018965-1018966 via svnmerge from
https://vkrause@svn.kde.org/home/kde/branches/work/akonadi-ports/kdepim
........
r1006327 | ervin | 2009-08-03 15:29:39 +0200 (Mon, 03 Aug 2009) | 3 lines
Make the code a bit more independent from KMail. Don't depend on a
running KMKernel instance, or on KMail's GlobalSettings class.
........
r1009651 | ervin | 2009-08-10 17:10:13 +0200 (Mon, 10 Aug 2009) | 6 lines
* setMessageItemStatus() now also gets the item row in its parameters
* the model displayed in the view now reacts to headerDataChanged()
signals coming from the storage model (effectively allowing to change
that on demand, eg. when switching a folder for outbound/inbound
messages display)
........
r1009652 | ervin | 2009-08-10 17:11:56 +0200 (Mon, 10 Aug 2009) | 2 lines
Mark it (temporarily) as exported for use in a test app.
........
r1009653 | ervin | 2009-08-10 17:12:20 +0200 (Mon, 10 Aug 2009) | 2 lines
Add an akonadi based storage model.
........
r1009654 | ervin | 2009-08-10 17:13:07 +0200 (Mon, 10 Aug 2009) | 2 lines
Add the akonadi based storage model also to the build system.
........
r1009655 | ervin | 2009-08-10 17:13:43 +0200 (Mon, 10 Aug 2009) | 3 lines
Add a small test app to play with the message list on an akonadi based
storage model.
........
r1009718 | tilladam | 2009-08-10 20:10:52 +0200 (Mon, 10 Aug 2009) | 1 line
Find the boost includes.
........
r1009900 | tilladam | 2009-08-11 09:23:36 +0200 (Tue, 11 Aug 2009) | 1 line
Find the boost includes.
........
r1009912 | ervin | 2009-08-11 10:18:15 +0200 (Tue, 11 Aug 2009) | 2 lines
As advised by Thomas change the id depending on the selection.
........
r1010797 | ervin | 2009-08-13 15:23:30 +0200 (Thu, 13 Aug 2009) | 2 lines
Factor out currentMessageItem() in the base class.
........
r1010798 | ervin | 2009-08-13 15:24:35 +0200 (Thu, 13 Aug 2009) | 3 lines
Provide more information on our current state to the outside. In
particular the list of collections currently displayed by this model.
........
r1010799 | ervin | 2009-08-13 15:25:57 +0200 (Thu, 13 Aug 2009) | 5 lines
Add an implementation of Core::Widget for the Akonadi based
implementation. Context menu on items still missing, on hold until it
can be written in a KMail-independent fashion (requires finishing some
other frameworks).
........
r1010800 | ervin | 2009-08-13 15:26:39 +0200 (Thu, 13 Aug 2009) | 2 lines
Make the test app use our new widget.
........
r1012389 | ervin | 2009-08-17 17:38:09 +0200 (Mon, 17 Aug 2009) | 2 lines
Make sure we register the attribute only once.
........
r1012390 | ervin | 2009-08-17 17:39:33 +0200 (Mon, 17 Aug 2009) | 3 lines
Add a new tab widget pane to be used with the new message list views.
Should be on par feature wise with the old facilities.
........
r1012391 | ervin | 2009-08-17 17:39:55 +0200 (Mon, 17 Aug 2009) | 2 lines
Modify the test to only use the new Pane class now.
........
r1012860 | ervin | 2009-08-18 11:27:25 +0200 (Tue, 18 Aug 2009) | 2 lines
Relay the signals from Widget.
........
r1012861 | ervin | 2009-08-18 11:28:13 +0200 (Tue, 18 Aug 2009) | 2 lines
Use libmailreader in the test app, and plug it with the message list.
........
r1012896 | ervin | 2009-08-18 12:35:28 +0200 (Tue, 18 Aug 2009) | 2 lines
We'd better carry Akonadi::Items in the signals rather than MessagePtrs.
........
r1012897 | ervin | 2009-08-18 12:35:47 +0200 (Tue, 18 Aug 2009) | 2 lines
Port the test app to the interface change in signals.
........
r1012899 | ervin | 2009-08-18 12:37:32 +0200 (Tue, 18 Aug 2009) | 2 lines
messageForRow() is now useless in Widget.
........
r1012986 | ervin | 2009-08-18 16:01:54 +0200 (Tue, 18 Aug 2009) | 3 lines
Move the message list view framework and its akonadi implementation in a
separate library. The kmail implementation stays behind.
........
r1012993 | ervin | 2009-08-18 16:19:24 +0200 (Tue, 18 Aug 2009) | 2 lines
Header got moved and renamed.
........
r1013179 | ervin | 2009-08-19 09:19:27 +0200 (Wed, 19 Aug 2009) | 2 lines
Use the monitor to get only mails.
........
r1013202 | ervin | 2009-08-19 11:44:23 +0200 (Wed, 19 Aug 2009) | 2 lines
Remove empty directory.
........
r1013217 | ervin | 2009-08-19 12:28:12 +0200 (Wed, 19 Aug 2009) | 4 lines
Rename the namespaces so that we only have MessageList and
MessageList::Core namespaces. No reference to the KMail namespace
anymore.
........
r1013218 | ervin | 2009-08-19 12:30:45 +0200 (Wed, 19 Aug 2009) | 2 lines
Port to the namespaces changes in libmessagelist.
........
r1013222 | ervin | 2009-08-19 12:41:18 +0200 (Wed, 19 Aug 2009) | 2 lines
Make them build with the new namespace name.
........
r1013227 | ervin | 2009-08-19 12:46:23 +0200 (Wed, 19 Aug 2009) | 2 lines
Make it build with the new MessageList namespace.
........
r1013306 | ervin | 2009-08-19 15:56:19 +0200 (Wed, 19 Aug 2009) | 3 lines
Always keep the header view shown if we want to be able to switch
themes.
........
r1013307 | ervin | 2009-08-19 15:57:50 +0200 (Wed, 19 Aug 2009) | 3 lines
Handle properly the message list framework settings. It's now completely
decoupled from kmailrc and different apps can have different settings.
........
r1013321 | ervin | 2009-08-19 17:04:15 +0200 (Wed, 19 Aug 2009) | 3 lines
Get rid of this test app as its features got merged in
akonadimailreader.
........
r1013634 | ervin | 2009-08-20 12:38:37 +0200 (Thu, 20 Aug 2009) | 2 lines
Provide some more selection convenience in the Pane and Widget APIs.
........
r1013642 | ervin | 2009-08-20 13:01:35 +0200 (Thu, 20 Aug 2009) | 2 lines
Some public slots convenience.
........
r1013660 | ervin | 2009-08-20 13:52:23 +0200 (Thu, 20 Aug 2009) | 2 lines
Honor the "autohide tab bar" setting.
........
r1013661 | ervin | 2009-08-20 13:53:28 +0200 (Thu, 20 Aug 2009) | 3 lines
The settings.* files become messagelist_settings.* files to make them
easier to reuse as is in other projects.
........
r1015357 | ervin | 2009-08-25 13:02:22 +0200 (Tue, 25 Aug 2009) | 4 lines
Ooooh, we can in fact control both the visibility and the use of
d-pointer with KConfigXT. Really cool! I can make the settings sharing
more convenient now I think.
........
r1015455 | ervin | 2009-08-25 16:44:06 +0200 (Tue, 25 Aug 2009) | 4 lines
Put the Settings class back in the Core namespace.
(Requires the KDE4Macros.cmake change from r1015454 in trunk)
........
r1015826 | ervin | 2009-08-26 14:15:36 +0200 (Wed, 26 Aug 2009) | 2 lines
Use the new USE_RELATIVE_PATH option.
........
r1016388 | ervin | 2009-08-27 19:58:32 +0200 (Thu, 27 Aug 2009) | 4 lines
First round of cleanups to provide a nicer API and be ready for BC
constraints. This one is mainly about using d-pointers in the relevant
classes.
........
r1017775 | ervin | 2009-08-31 14:40:51 +0200 (Mon, 31 Aug 2009) | 4 lines
Don't export Core::Manager anymore, make the exported API smaller.
Provide some more API on ThemeComboBox and AggregationComboBox to
tackle the config tasks some of KMail code was routing through Manager.
........
r1017776 | ervin | 2009-08-31 14:42:38 +0200 (Mon, 31 Aug 2009) | 6 lines
Don't depend on MessageList::Core::Manager anymore.
This commit might break the "react to configure changes" behavior in the
message list view though. It's going to be fixed later on (as the topic
need investigation for akonadimailreader as well).
........
r1017789 | ervin | 2009-08-31 16:17:09 +0200 (Mon, 31 Aug 2009) | 2 lines
React properly to setting changes.
........
r1018128 | ervin | 2009-09-01 12:32:05 +0200 (Tue, 01 Sep 2009) | 2 lines
React to setting changes about the message list view.
........
r1018244 | ervin | 2009-09-01 16:04:48 +0200 (Tue, 01 Sep 2009) | 9 lines
Moving some classes out of Core. The idea being to have the following
situation:
- Core => Everything you need to implement your own model and views
(like the Akonadi implementation, the KMail one, etc.);
- Utils => The smaller utilities to integrate a messagelist into your
applications, mainly widgets and dialogs to edit the settings, themes
and aggregations.
........
r1018261 | ervin | 2009-09-01 16:18:51 +0200 (Tue, 01 Sep 2009) | 2 lines
Install all the headers needed from the outside.
........
r1018764 | tilladam | 2009-09-02 08:52:09 +0200 (Wed, 02 Sep 2009) | 3 lines
Move various private classes to toplevel (or namespace) scope.
This is necessary in order to avoid problems with not inherited
friendship by inner classes. This thing is a mighty mess of friendship.
........
r1018768 | ervin | 2009-09-02 09:00:10 +0200 (Wed, 02 Sep 2009) | 2 lines
Port KMail to the new Core/Utils split.
........
r1018769 | tilladam | 2009-09-02 09:00:12 +0200 (Wed, 02 Sep 2009) | 1 line
Make sure to include the messagelist library.
........
r1018898 | ervin | 2009-09-02 12:05:24 +0200 (Wed, 02 Sep 2009) | 2 lines
Don't forget to attach the config button to the combo box.
........
r1018907 | ervin | 2009-09-02 12:10:56 +0200 (Wed, 02 Sep 2009) | 14 lines
Kill all the friendship out of classes from utils.
Also the configure dialogs are not singleton anymore as:
1) it was a broken feature anyway (they're DeleteOnClose and the singleton
pointer wasn't reset, you were gambling with the application's life
everytime you called instance()... ahem);
2) really there's nothing magical about them, so no good reason to make
them singletons.
The accompanying convenience methods to trigger the configure dialogs got removed
from Manager. Again that was just trying to save a couple of
straightforward lines (create the dialog, set its state, call show() on
it, done).
........
r1018922 | ervin | 2009-09-02 12:27:45 +0200 (Wed, 02 Sep 2009) | 3 lines
Kill some more friendship. There's no reason to make those ctors private
anyway...
........
r1018924 | ervin | 2009-09-02 12:28:44 +0200 (Wed, 02 Sep 2009) | 2 lines
Damn, why did I use friend here??
........
r1018950 | ervin | 2009-09-02 13:21:27 +0200 (Wed, 02 Sep 2009) | 2 lines
Some more friendship we can avoid.
........
r1018958 | ervin | 2009-09-02 13:47:53 +0200 (Wed, 02 Sep 2009) | 4 lines
Move the "heart beat" timer out of the Manager. And make it shared only
between the Model instances. One less reason for Manager to fiddle in
other people business. ;-)
........
r1018959 | ervin | 2009-09-02 13:50:13 +0200 (Wed, 02 Sep 2009) | 2 lines
Some more heart beat timer cleanup.
........
r1018965 | ervin | 2009-09-02 13:55:21 +0200 (Wed, 02 Sep 2009) | 3 lines
Notify of theme and aggregation related changes using signal/slot
mechanism.
........
r1018966 | ervin | 2009-09-02 14:05:13 +0200 (Wed, 02 Sep 2009) | 2 lines
Unneeded.
........
svn path=/trunk/KDE/kdepim/; revision=1023738
* Use the new MessageComposer lib. It only handles plain text so far. If you want to use the old composer, define BUILD_NEW_COMPOSER to false at the top of CMakeLists.txt
svn path=/branches/work/akonadi-ports/kdepim/; revision=994696
kio_sieve:
- try STARTTLS even if the user didn't ask for it, and even if the
server didn't send the STARTTLS capability (it could have been
removed from by a man-in-the-middle).
- Stop when STARTTLS failed (or canUseTLS() == false), UNLESS the
x-allow-unencrypted query item is present, and it's value is "true".
kmail:
- set x-allow-unencrypted query item to "true" for sieve URLs iff the
account was not not configured to use either SSL or TLS.
svn path=/branches/kdepim/enterprise/kdepim/; revision=915156
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/KDE/4.1/kdepim
........
r890890 | tmcguire | 2008-11-30 17:03:04 +0100 (Sun, 30 Nov 2008) | 14 lines
Backport r888149 by tmcguire from trunk to the 4.1 branch:
An attempt to repair the encoding mess a bit, when attaching files:
- Don't set the charset to us-ascii if it couldn't be found
- Give up on KEncodingProber, it doesn't work reliable enough.
Instead, add an encoding combobox to the file dialog.
Now it is the user's fault if the encoding is not correct :)
- Don't attempt to set a charset for a non-textual mimetype
- Don't show an empty string for the mimetype
CCBUG: 64815
........
svn path=/branches/kdepim/enterprise4/kdepim/; revision=896785
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/KDE/4.1/kdepim
........
r890884 | tmcguire | 2008-11-30 16:48:42 +0100 (Sun, 30 Nov 2008) | 5 lines
Backport r887691 by mueller from trunk to the 4.1 branch:
make sure that startPart is in range
........
svn path=/branches/kdepim/enterprise4/kdepim/; revision=890945
An attempt to repair the encoding mess a bit, when attaching files:
- Don't set the charset to us-ascii if it couldn't be found
- Give up on KEncodingProber, it doesn't work reliable enough.
Instead, add an encoding combobox to the file dialog.
Now it is the user's fault if the encoding is not correct :)
- Don't attempt to set a charset for a non-textual mimetype
- Don't show an empty string for the mimetype
CCBUG: 64815
svn path=/branches/KDE/4.1/kdepim/; revision=890890
- Don't set the charset to us-ascii if it couldn't be found
- Give up on KEncodingProber, it doesn't work reliable enough.
Instead, add an encoding combobox to the file dialog.
Now it is the user's fault if the encoding is not correct :)
- Don't attempt to set a charset for a non-textual mimetype
- Don't show an empty string for the mimetype
BUG: 64815
svn path=/trunk/KDE/kdepim/; revision=888149
This brings a reworked folder tree and and a new message list, which is much more powerful than the old one.
New features include grouping, multiline items and the ability to customize just about everything of the look of the message list.
Also, we have a tabbed interface for opening more than one folder at once now.
An important aspect of the new message list is that drawing speed is now fast again (there was a regression in Q3ListView that
made huge folders a real pain to navigate, reading commit folders was not a nice thing to do).
There are probably more things which I forgot to list here.
Also, this is big step forward in getting rid of Qt3Support in KMail, now just some tiny bits are left.
Many thanks to SoC student Szymon Stefanek for his awesome work on his project! I can't stress enough how great this
achivment is. He even added very good API documentation to his classes :)
This requires the lastest version of qt-copy, otherwise you'll get mysterious crashes in Qt painting code from time to time.
We hope that this patch will be added to the next Qt 4.4.x version.
And finally, this merge also brings many regressions, which is not unnatural for such a big change.
In the remaining time before the KDE 4.2 release, we'll have to work on those to get it polished and regression-free.
Help here is always needed, and is a good opportunity to start working on KMail, since many regressions are low hanging fruit.
It also means the message list and the folder tree need a bit of testing.
If you find bugs, report them under the "new message list" and "new folder tree" component of the bug tracker, thanks.
I also plan to setup a wiki page with known regressions.
CCMAIL: kde-pim@kde.org
GUI:
CCBUG: 117808
BUG: 163469
FEATURE: 18170
FEATURE: 32400
FEATURE: 42107
FEATURE: 45526
FEATURE: 81272
FEATURE: 90142
FEATURE: 107450
(and probably many others)
svn path=/trunk/KDE/kdepim/; revision=881321
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/KDE/4.1/kdepim
........
r870426 | tmcguire | 2008-10-12 16:23:56 +0200 (Sun, 12 Oct 2008) | 17 lines
Backport r867007 by tmcguire from trunk to the 4.1 branch:
Fix the charset name being "ISO 8859-xx" instead of "ISO-8859-xx".
This is because KCharsets::encodingForName() prefers to return something "human-readable" now,
thank you very much. I wonder why this worked in 3.5, the hypen seems to be missing there as well.
The KCharsets code is too much magic to be understandable unfortunatley.
Apparently KMail has been sending invalid messages ever since 4.1 was released.
Urgh :(
I hope I didn't mix human- and machine-readable names anywhere, otherwise things will
break. This is also the reason I was too afraid to change this in kdelibs.
CCBUG: 171947
........
svn path=/branches/kdepim/enterprise4/kdepim/; revision=870472
Fix the charset name being "ISO 8859-xx" instead of "ISO-8859-xx".
This is because KCharsets::encodingForName() prefers to return something "human-readable" now,
thank you very much. I wonder why this worked in 3.5, the hypen seems to be missing there as well.
The KCharsets code is too much magic to be understandable unfortunatley.
Apparently KMail has been sending invalid messages ever since 4.1 was released.
Urgh :(
I hope I didn't mix human- and machine-readable names anywhere, otherwise things will
break. This is also the reason I was too afraid to change this in kdelibs.
CCBUG: 171947
svn path=/branches/KDE/4.1/kdepim/; revision=870426
This is because KCharsets::encodingForName() prefers to return something "human-readable" now,
thank you very much. I wonder why this worked in 3.5, the hypen seems to be missing there as well.
The KCharsets code is too much magic to be understandable unfortunatley.
Apparently KMail has been sending invalid messages ever since 4.1 was released.
Urgh :(
I hope I didn't mix human- and machine-readable names anywhere, otherwise things will
break. This is also the reason I was too afraid to change this in kdelibs.
BUG: 171947
svn path=/trunk/KDE/kdepim/; revision=867007
Some fixes for online IMAP filtering:
- In the action scheduler, don't error out when the filtered message
couldn't be moved back to the target folder. Instead, ignore the error
(but don't delete the orginal message). This fixes filtering
stopping on GMail accounts once a message was encountered that was not
moved to another folder, but stayed in the same folder (GMail prevents moving
in this case, since it thinks it is a duplicate message)
- When moving the filtered message with the action scheduler from the
temporary filter folder to the target folder, the original message wouldn't
get deleted properly.
The reason for this was that the move command thought the move failed because
a message with another serial number arrived.
Fix this by remembering the serial number (based on the message ID) when using
the action scheduler for filtering.
This fixes filters which move messages to other folders: Now the message is properly
removed from the source folder again.
- add comments and kDebug output
This does _not_ solve the following problem:
When using GMail and online IMAP, filter actions which modify the message will not have
any effect, since GMails duplicate message prevention prevents the filtered message to
be moved back to the IMAP folder.
This will not be fixed, I see no way to work around this. GMail should fix their IMAP
server instead.
Please test, I'm not sure if this is safe to backport.
CCBUG: 166150
svn path=/branches/KDE/4.1/kdepim/; revision=836580
svn+ssh://tmcguire@svn.kde.org/home/kde/trunk/KDE/kdepim
........
r833475 | tmcguire | 2008-07-16 23:07:56 +0200 (Wed, 16 Jul 2008) | 32 lines
Some fixes for online IMAP filtering:
- In the action scheduler, don't error out when the filtered message
couldn't be moved back to the target folder. Instead, ignore the error
(but don't delete the orginal message). This fixes filtering
stopping on GMail accounts once a message was encountered that was not
moved to another folder, but stayed in the same folder (GMail prevents moving
in this case, since it thinks it is a duplicate message)
- When moving the filtered message with the action scheduler from the
temporary filter folder to the target folder, the original message wouldn't
get deleted properly.
The reason for this was that the move command thought the move failed because
a message with another serial number arrived.
Fix this by remembering the serial number (based on the message ID) when using
the action scheduler for filtering.
This fixes filters which move messages to other folders: Now the message is properly
removed from the source folder again.
- add comments and kDebug output
This does _not_ solve the following problem:
When using GMail and online IMAP, filter actions which modify the message will not have
any effect, since GMails duplicate message prevention prevents the filtered message to
be moved back to the IMAP folder.
This will not be fixed, I see no way to work around this. GMail should fix their IMAP
server instead.
Please test, I'm not sure if this is safe to backport.
CCBUG: 166150
........
svn path=/branches/kdepim/enterprise4/kdepim/; revision=835021
- In the action scheduler, don't error out when the filtered message
couldn't be moved back to the target folder. Instead, ignore the error
(but don't delete the orginal message). This fixes filtering
stopping on GMail accounts once a message was encountered that was not
moved to another folder, but stayed in the same folder (GMail prevents moving
in this case, since it thinks it is a duplicate message)
- When moving the filtered message with the action scheduler from the
temporary filter folder to the target folder, the original message wouldn't
get deleted properly.
The reason for this was that the move command thought the move failed because
a message with another serial number arrived.
Fix this by remembering the serial number (based on the message ID) when using
the action scheduler for filtering.
This fixes filters which move messages to other folders: Now the message is properly
removed from the source folder again.
- add comments and kDebug output
This does _not_ solve the following problem:
When using GMail and online IMAP, filter actions which modify the message will not have
any effect, since GMails duplicate message prevention prevents the filtered message to
be moved back to the IMAP folder.
This will not be fixed, I see no way to work around this. GMail should fix their IMAP
server instead.
Please test, I'm not sure if this is safe to backport.
CCBUG: 166150
svn path=/trunk/KDE/kdepim/; revision=833475
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim
........
r814982 | mutz | 2008-05-31 22:44:41 +0200 (Sat, 31 May 2008) | 1 line
GpgME::Error::asString() is encoded in local8Bit. Also fixed one each of size() > 0 --> !empty() and foo[0] -> foo.front().
........
r820931 | osterfeld | 2008-06-15 21:57:50 +0200 (Sun, 15 Jun 2008) | 1 line
Do not crash if the header filed is empty (such as "fieldname*=")
........
r821539 | staniek | 2008-06-17 20:07:18 +0200 (Tue, 17 Jun 2008) | 8 lines
Attachment tree widget:
- usability++: provide popup menu with just one "Save All Attachments"
action when user clicks root node or the empty area;
- do not display actions like "save as" for the root node (avoids assertion)
- clicking on the root node reloads contents of the tree,
so select this item again afterwards
........
r822092 | tilladam | 2008-06-19 07:23:45 +0200 (Thu, 19 Jun 2008) | 2 lines
Don't crash by accessing the job after the event loop deletes it.
........
r822161 | osterfeld | 2008-06-19 13:16:11 +0200 (Thu, 19 Jun 2008) | 1 line
do not crash if the signature has no fingerprint
........
r822454 | staniek | 2008-06-20 11:38:03 +0200 (Fri, 20 Jun 2008) | 2 lines
explicitly use boolean as the condition
........
svn path=/trunk/KDE/kdepim/; revision=822593
-use K_GLOBAL_STATIC for static data
-an attempt to fix possible crashes and "null messages appearing in folders like outbox"
Details:
M kmail/kmfolderindex_sqlite.cpp
M kmail/kmfolderindex.h
* executes "DELETE FROM messages WHERE id=.." for every for messages
with 0 serial number, especially for the outbox
* removed commented-out old impl.
M kmail/kmmessage.h
use K_GLOBAL_STATIC
M kmail/kmfoldermaildir.cpp
* minor change
M kmail/jobscheduler.cpp
M kmail/jobscheduler.h
* ~JobScheduler() use qDeleteAll() (and clear for sanity)
M kmail/networkaccount.cpp
* use K_GLOBAL_STATIC
* use value() to avoid inserting 0 values
* NetworkAccount::resetConnectionList(): use remove() instead of inserting 0
M kmail/kmmessage.cpp
* use K_GLOBAL_STATIC
M kmail/kmcommands.cpp
* KMMoveCommand::execute(): skip mesages with serial number == 0
-this avoids crashes when user tries to clean up a folder with "no subject" items
M kmail/kmmsgbase.cpp
* #ifdef code related to using_mmap when using sqlite mode
M kmail/networkaccount.h
* use QPointer<KIO::Slave> mSlave and bits for boolean members
svn path=/trunk/KDE/kdepim/; revision=809620
- use QChar instead of QCharRef in swapEndian()
- build the serial cache of a folder when opening
it with the headerview
Now the remaining slowness comes from Qt, especially
from Q3ListView::paintBranches(), which sucks away most
of the CPU.
svn path=/trunk/KDE/kdepim/; revision=807757
- Enable some code again
- style fixes
Still totally broken, though.
Do not use a KMail version newer than the nommap branch merge.
svn path=/trunk/KDE/kdepim/; revision=805166
from
/branches/work/kmail-nommap (r799390..804487)
/branches/work/kdepim-nommap/kmail (r804484..804960)
The SQLite mode is currently enabled only on Windows (by KMAIL_SQLITE_INDEX define),
so on !Windows, the code for standard 'mmap' mode is compiled.
CCMAIL:kde-pim@kde.org
svn path=/trunk/KDE/kdepim/; revision=805075
Fixes incorrect display of a sender with umlauts, but missing RFC 2047 encoding
(yes, I'm looking at you, bugzilla!)
svn path=/trunk/KDE/kdepim/; revision=796628
That fixes incorrect spaces/tabs in the subject, a regression introduced
with my recent decodeRFC2047String removal.
svn path=/trunk/KDE/kdepim/; revision=793387
>SVN commit 788330 by tmcguire:
>Use decode/encodeRFC2047String from KMime instead of rolling our own.
The reason is that our encodeRFC2047String does not encode quoted words (e.g. the
address part of a mailbox), while the encodeRFC2047String from KMime does, and
I couldn't find a method in KMime which does not encode quoted words.
BUG: 159995
svn path=/trunk/KDE/kdepim/; revision=792011
FolderStorage::canAccess() now returns bool,
and thus also the same method in KMFolderSearch, KMFolderMaildir,
KMFolderMbox, KMFolder
- Maildir filenames: use '!' character separator instead of ':' for windows
(KMAIL_MAILDIR_FNAME_SEPARATOR macro),
as it is impossible to create a file containing ':' (regardless of the
used filesystem - it is a property of the FS API itself)
- KMFolderMaildir::canAccess() use QFileInfo instead of access() - solves
problem with undefined
X_OK flag on windows and is still enough efficient as there are no hundreds
of dirs in a maildir
- KMFolderIndex::recreateIndex() now returns bool
- KMFolderDir::reload() simplified
svn path=/trunk/KDE/kdepim/; revision=773959
Volker Krause
Thomas McGuire
Martin Koller
Constantin Berzan
Allen Winter
Szymon Stefanek
Marc Mutz
Dirk Mueller
Laurent Montel
Enrique Matas Snchez
Bertjan Broeksema
Frank Osterfeld
Jarosaw Staniek