#define kernel KMKernel::self()
to
#define kmkernel KMKernel::self()
because 'kernel' was a much to general term. We really shouldn't repeat the mistakes of the X developers.
I noticed this problem when I played around with KImageEffects. kimageeffects.h contains 'kernel' as parameter of some methods and so the compilation had to fail. We won't need KImageEffects in the near future, but at least we are now prepared and a clash with another 'kernel' can't happen anymore.
svn path=/trunk/kdepim/; revision=252621
will tell you when it failed (this makes deleting mails a single sys call
instead of two - in my NFS using case this makes a speedup of 2 :)
svn path=/trunk/kdepim/; revision=248035
1) Remove the limitation that a message can have only one status at a time.
2) Implement watch/ignore thread via message status flags.
ad 1:
- Message status is now kept as a bitfield, which means a message can now be
for example replied and forwarded as well as important at the same time.
- To keep the index format backward compatible and make the transition
painless, I've added a new index entry and added code to transfer the old
into the new format. That means that upgrading users should not notice
anything.
- I've tried to keep as much behavior as possible unchanged with regard to
what flag disables what other flag etc. There are two groups of flags:
read/unread/new/old influence each other, which means a message cannot be
new and read at the same time, for example, while the second group, namely
important, sent, queued, replied, and forwarded are toggled individually.
- Toggling a thread sets the messages status to the inverse of that of the
parent, which means that if you have a thread with some mails marked as
important and some not, the status is set according to that of the parent.
- Status is now kept when moving mails between folders in the same imap
account as well as between imap accounts.
ad 2:
- Watch and ignore are mutually exclusive, which means ignoring a thread
unsets its watched flag and the other way around.
- When sorting by status watched threads are at the top, ignored at the
bottom.
- Watch and ignore propagate via threading, which means that if a message
is threaded below a watched one, it becomes watched. Same for ignore.
- Moving a single mail out of a watched thread results in a new watched
thread of size 1 :)
- Similarly watch and ignore are possible on individual mail (threads
to be).
- Watching a thread does not currently mark new mails as important, nor
does ignoring delete new mails in the thread. These are possible
extensions, though, if we think them sensible.
svn path=/trunk/kdepim/; revision=235595
The problem was that the index generation code assumed that the colon after the header field name is followed by a space. Although this is usually the case the space is not required by RFC 2822 (it's not even mentioned by RFC 2822). So I removed the code that checks for the space and made KMail interpret everything after the colon as part of the header field body. Of course this leads to a superfluous leading space. I remove this with QCString::stripWhiteSpace() which of course removes all leading and trailing whitespace. I don't think that this is a problem.
Furthermore I moved the code which looks at the Message-Id, In-Reply-To and References headers to make sure that this code works on the complete header field body and not only at the first line. Especially the References header is very often folded.
svn path=/trunk/kdepim/; revision=227878
has it's own cursor stack.
I added kcursorsaver, that makes sure that the cursor is restored when the object
gets out of scope (just as KConfigGroupSaver)
Now kmkernel doesn't has to cope with cursors anymore
svn path=/trunk/kdepim/; revision=221747
This is a set of changes that is well test by myself and others.
The following bug fixes amongst others are included:
Compilation fix: the certificate dialog now compiles
Mjr bugfix: Prevent mail loss when kmail crashes while editing a
drafts message
Mjr bugfix: Fix erratic folder changing when clicking on the folder
tree
Mjr bugfix: Prevent mail loss when applying filters
The follow features have been implemented:
* KMail is now a KPart and can be embedded in the Kontact/Kaplan
container applications along with other KDE PIM applications.
* Remove duplicates function for removing duplicate messages in
a folder.
* Messages can be dragged and dropped on a composer window to
add those messages as attachments.
* Deletion in threaded mode is improved, child messages will no
longer be scattered when a parent is deleted.
* Multiple messages can now be selected in the search dialog.
* New context menu in the search dialog with Move, Copy, Reply
etc. actions for operating on selected messages.
* Search criteria in the search dialog now supports more types
of rules and a variable number of rules.
* Faster searching of large messsages.
* 'Search Folders' which are a KMail folder that stores a search
expression and is dynamically updated (also known as virtual
folders).
* The separate window for reading mail has a context menu with
Reply, Copy etc. actions for operating on the message
displayed.
* The separate window for reading mail has a tool bar.
* Startup of KMail is faster.
* Switching between folders is faster.
* The contents of all composer windows are saved to disk on
composer window creation and then periodically saved to
prevent mail loss in the result of a system crash.
* The state of KMail folders is saved to disk periodically to
prevent status information loss in the result of a system
crash.
Note after start KMail switching to folders for the first time will
slow as the format of the .sorted file has changed.
Enjoy!
svn path=/trunk/kdenetwork/kmail/; revision=195825
for me the "crash on reply" and "forward message crash" bugs and people
on IRC have been insisting on committing it. So yeah, asynchronous message
handling in KMail is in!!! May the God of Coding have mercy on us...
svn path=/trunk/kdenetwork/kmail/; revision=193386
- // it would be nice if QDir could delete recursively.. but since it
- // doesn't, we have to do this hack
- QCString cmd;
- cmd.sprintf("rm -rf '%s'", QFile::encodeName(location()).data());
- system(cmd.data());
-
- return 0;
+ if (KIO::NetAccess::del(KURL::fromPathOrURL(location())))
+ return 0;
+ return 1;
svn path=/trunk/kdenetwork/kmail/; revision=186186
Please note that this port includes a bug fix which should be ported back to make_it_cool. I've sent the bug fix to the mailing list.
svn path=/trunk/kdenetwork/kmail/; revision=184866
The reason for this bug was a wrong assumption about the return value of QFile::readline. Reading the docs helps. FYI the fix:
- if (!f.readLine(line, MAX_LINE))
+ // if the end of the file has been reached or if there was an error
+ if ( f.atEnd() || ( -1 == f.readLine(line, MAX_LINE) ) )
svn path=/trunk/kdenetwork/kmail/; revision=184624
- replace KMKernel::self() with kernel
- introduce KMTextBrowser for viewing raw messages or text-attachments
to fix memory leaks
svn path=/trunk/kdenetwork/kmail/; revision=175027
to write to the sent-mail folder but does have permission for the outbox.
Based on patch by Russell Miller <rmiller@duskglow.com>
svn path=/trunk/kdenetwork/kmail/; revision=157558
Activate them via View-menu or rmb-menu from the tree-header.
Changed the qpopup for the folder-context-menu to kpopup to be consistent with the rest.
svn path=/trunk/kdenetwork/kmail/; revision=153547
@@ -762,9 +762,9 @@ int KMFolderMaildir::removeContents()
{
// it would be nice if QDir could delete recursively.. but since it
// doesn't, we have to do this hack
- QString cmd;
+ QCString cmd;
cmd.sprintf("rm -rf '%s'", QFile::encodeName(location()).data());
- system(cmd.ascii());
+ system(cmd.data());
return 0;
}
svn path=/trunk/kdenetwork/kmail/; revision=141877
Ingo Klcker
Stephan Kulow
Carsten Burghardt
Daniel Molkentin
Don Sanders
Till Adam
Marc Mutz
Zack Rusin
Lauri Watts
Antonio Larrosa Jimenez
Volker Augustin
Andy Fawcett
Carsten Pfeiffer
Karl-Heinz Zimmer
Michael Haeckel
Waldo Bastian