a message id header (*sigh*) just because "" happens to equal "".
Amit, thanks for the test case.
CCMAIL: 67850-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=267069
press in the each folder by chanting the magic incantation:
setSelectionAnchor(currentItem());
in a few places.
CCMAIL: 66979-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=265303
This should fix a bug with ad hoc filters crashing when they move a message
to a different folder.
And also fix the bug/limitation that the move to folder action has to
come last in the list of filter actions for a filter.
This commit doesn't really use the action scheduler, code to use the
action scheduler in kmheaders and kmcommands is commented out.
I've been testing this code for a few weeks now. The changes to the
assignment operators in the kmmessage and kmmsgbase classes are the
changes I'm most concerned about here.
svn path=/trunk/kdepim/; revision=264912
list by relying on KListView to handle things instead of (brokenly) re-
implementing extended selection behavior ourselves.
CCMAIL: 55555-done@bugs.kde.org
CCMAIL: 55892-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=261876
º s/FALSE/false/g and s/TRUE/true/g
o remove unused mTrue and mFalse (what the hell were those for???)
o prefix member variables with m
o reorder stuff in the header file to group it somewhat
o add comments to be fleshed out later
svn path=/trunk/kdepim/; revision=261790
in during filtering and remove obsolete qlistview workaround.
Patch by Ladislav Strojil <Ladislav.Strojil@seznam.cz>
svn path=/trunk/kdepim/; revision=259319
current item. It loses that state if it is subsequently rethreaded because
it is a child of the removed message, since rethreading uses take() and
insert(). Remember the current item before reparenting and reset it
afterwards.
Thanks, Oded, for the excellent bug report.
CCMAIL: 66025-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=259023
account when sorting by status (doh) and making the sort key generation
a bit more intuitive. That is of course entirely subjective, so if someone
has better ideas how to order them, please speak up.
svn path=/trunk/kdepim/; revision=257730
is a KMMainWindow or kapp->config() otherwise. Will help fixing layout
and possibly other config related problems with the KMail part in Kontact.
While I was at it and complaining about the API, till jumped in saying:
<till> there are lots of public KActions and friend in kmmainwidget's
public api apparently for no good reason either
Your wish is my command, so this commit is also (and mostly) about API cleanup.
Okay'ed by Ingo.
svn path=/trunk/kdepim/; revision=256339
- Move some code to new KMHeaders::setStyleDependantFrameWidth method to avoid code duplication.
- reimplement KListView::styleChange so that the frame width is updated in case the style is changed.
- Untabification and trailing white space removal.
svn path=/trunk/kdepim/; revision=256253
messages from the headers list (move/delete operations) works to:
o figure out what message to select afterwards (the one below or above the
selected ones or none at all if all are being deleted)
o mark all selected messages as aboutToBeDeleted and non-selectable
o select the previously remembered message
o kick off the move action during which the aboutToBeDeleted messages remain
unselectable
That means it should now be impossible to select a message that is going
away or change a KMMsgBase pointer to a KMMessage pointer thereby
invalidating the list of messages currently being moved.
svn path=/trunk/kdepim/; revision=253428
command up to the target folder's msgAdded signals and ticking off each
serial number as it comes in. To make that possible, use the metaDataMap
for imap folders to restore serial numbers after the move (along with
status). Also connect to the folderCompleted(bool) signal of imap folders
to make sure we notice if not all messages make it to the other side.
Connect kmheaders to the abortRequested signal and make sure cancelling
moves behaves somewhat more gracefully and restores the state of messages
remaining in the folder, making them selectable and setting their transfer
status to false so they can be downloaded or moved again.
svn path=/trunk/kdepim/; revision=252676
#define kernel KMKernel::self()
to
#define kmkernel KMKernel::self()
because 'kernel' was a much to general term. We really shouldn't repeat the mistakes of the X developers.
I noticed this problem when I played around with KImageEffects. kimageeffects.h contains 'kernel' as parameter of some methods and so the compilation had to fail. We won't need KImageEffects in the near future, but at least we are now prepared and a clash with another 'kernel' can't happen anymore.
svn path=/trunk/kdepim/; revision=252621
rely on the MoveCommand to find a message to select that is not one of
the ones being moved. Prevents a crash with moves between folders on the
same account. Also make sure non-selectable items are not selected when
something other than QListView does the selecting.
svn path=/trunk/kdepim/; revision=252310
example to the trash) unselectable and paint a line through them, to
visually indicate that they are going away. This is especially noticable
in imap folders where the messages are removed one by one as they arrive
in the destination folder.
svn path=/trunk/kdepim/; revision=250967
command needed to know about the headers to figure out what message to
select once the move is done, but that can and should imho be done in the
headers themselves. There was a ToDo to that effect in there, so I guess
the original author agrees. :)
svn path=/trunk/kdepim/; revision=249824
list as before or to the right of it or hide it completely. When the reader
window is disabled, messages that are selected are not downloaded (for
imap) and are not marked as read.
CCMAIL: 63647-done@bugs.kde.org
CCMAIL: 16345-done@bugs.kde.org
CCMAIL: 43176-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=249504
Imap job folder ref counting should make manual ref counting previously used obsolete.
Is probably better to wait for global filter manager cleanup rather than calling it here.
svn path=/trunk/kdepim/; revision=245378
zation working around a qlistview bug the disappearance of which caused
the simple way of doing it to be much more efficient. So we do that now.
svn path=/trunk/kdepim/; revision=245359
level items (thread parents) newest on top but sort the messages inside
the thread by descending date. I am told people want to have the newest
threads on top but read the threads top to bottom, so it makes sense
to sort the thread different from the parent.
o speed up re-sorting in the current folder (by clicking on the column
headers) by implementing a custom compare function and making sure the
date and size fields are unique by appending the serial number of the
message. This prevents qlistview from looking at the next column to
decide preference and do expensive localeAwareCompare()'s
o additionally speed up sorting by not using localeAwareCompare() for dates
and sizes
svn path=/trunk/kdepim/; revision=245307
Till Adam
Ingo Klcker
Don Sanders
Ladislav Strojil
Adriaan de Groot
Marc Mutz
Daniel Molkentin
George Staikos
Carsten Burghardt
Stephan Kulow
Scott Wheeler
Dirk Mueller