#define kernel KMKernel::self()
to
#define kmkernel KMKernel::self()
because 'kernel' was a much to general term. We really shouldn't repeat the mistakes of the X developers.
I noticed this problem when I played around with KImageEffects. kimageeffects.h contains 'kernel' as parameter of some methods and so the compilation had to fail. We won't need KImageEffects in the near future, but at least we are now prepared and a clash with another 'kernel' can't happen anymore.
svn path=/trunk/kdepim/; revision=252621
1. There's a reason that u is tested for emptiness. Look at findUrlForAccount().
2. Apart from that fact that using Qt's version of Java's reflection API
makes safe refactoring impossible (b/c the compiler can't check it),
one also needs to take care to always use the fully qualified name.
Thus, (new ImapAccountBase())->inherits(ImapAccountBase)) is always
_false_.
If there's a problem with dynamic_cast<> here (other than that it's standard
and not the Qt-way), feel free to fix _that_ problem, but _please_ _test_
before you commit (or post the patch, although posting shouldn't replace testing). This little thing has cost me half an hour of debugging :-((
svn path=/trunk/kdepim/; revision=232715
There is also a type property but it a) returns a QString and b) is not implemented in
any of the subclasses. So what can this property be removed?
CCMAIL:kmail@kde.org
svn path=/trunk/kdepim/; revision=228438
Ingo Klcker
Marc Mutz
Laurent Montel
Dirk Mueller
Daniel Molkentin
Cornelius Schumacher
Matt Rogers
Zack Rusin
Andras Mantia