QMAX/QMIN -> qMax/qMin
I don't know what to do about Q_LONG and Q_ULONG because of the following code in qglobal.h:
#if defined(Q_OS_WIN64)
typedef __int64 Q_LONG; /* word up to 64 bit signed */
typedef unsigned __int64 Q_ULONG; /* word up to 64 bit unsigned */
#else
typedef long Q_LONG; /* word up to 64 bit signed */
typedef unsigned long Q_ULONG; /* word up to 64 bit unsigned */
#endif
Should I simply convert to (unsigned) long?
svn path=/trunk/KDE/kdepim/; revision=468393
sed 's/59 Temple Place - Suite 330, Boston, MA 02111-1307/51 Franklin Street, Fifth Floor, Boston, MA 02110-1301/'
PS: I didn't touch the kalarm dir, since david seems to update the address himself, and I don't want to create conflicts for him.
CCMAIL:lists@astrojar.org.uk
svn path=/trunk/KDE/kdepim/; revision=437921
the helper function crlf2lf there, which was formerly a class static in
FolderStorage. Remove the now obsolete forward Folder -> Folderstorage
and port all users.
svn path=/trunk/KDE/kdepim/; revision=435216
were "saved" to kmailrc, but kmailrc wasn't synced, so in case of a kmail crash, X crash, power failure, kernel oops...
the settings would be lost, and on the next kmail restart very strange errors would happen when syncing
(can't create folder, folder already there, folder missing, etc.)
The solution: sync(). But while being at it I implemented buffering of sync requests
which was a TODO in kmkernel, but did it in GlobalSettings as Till suggested;
which in turn means we need our own GlobalSettings inheriting GlobalSettingsBase,
and the code lacked ::self()-> in many places to allow that.
svn path=/branches/kdepim/proko2/kdepim/; revision=432536
propagate that as an icon change to the foldertree, which makes sure
that it has the current type, before rendering the icon. All this to
make the right icon appear on newly downloaded folders.
svn path=/branches/kdepim/proko2/kdepim/; revision=431511
it, if there is no physical folder yet. Code creating (instantiating)
KMFolders does not need to care. Remove the ugly "bool imap" parameter
from create() and do proper reimplementation instead. Remove create()
forward from KMFolder -> FolderStorage.
This fixes "no such file or folder" warnings when creating or syncing
down new folders.
In case you missed it, today is Zack's birthday, so show the man some
love, will ya?
svn path=/trunk/KDE/kdepim/; revision=430989
handling and index handling.
o Make it possible to have folders that optionally have no index
and/or don't export their serial numbers to the message dict. This
was partly possible before, but relying on all kinds of implicit (and
often wrong) assumptions as to the presence and state of various
datastructures and files on disk.
o [TRUE|FALSE] => [true|false] (sorry about mixing this in)
o group a bunch of bools and use a bit for each to save memory
o remove index related forwards folder -> folderstorage
o api dox additions
Fixed the crashes with local and maildir accounts in the process, I
think.
BUG: 108386
svn path=/trunk/KDE/kdepim/; revision=430817
right way to fix it, though, it would be better to have an explicit
"this is a folder without an index and without exported serial numbers"
flag of some kind. Ingo do you agree?
CCMAIL: kmail-devel@kde.org
svn path=/trunk/KDE/kdepim/; revision=429482
here: http://lists.kde.org/?l=kmail-devel&m=111945756024656&w=2
I've changed the KMMsgDict::instance() to return a pointer instead of a
reference, compared to the patch I posted, after valid criticism from
Marc that the pattern is generally used with a pointer, in KDE, so it's
better not to surprise people here.
svn path=/trunk/KDE/kdepim/; revision=428560
o remove access to the reverse per folder message dict entries from the
folder interface. It's in FolderStorage and accessed through there
svn path=/trunk/KDE/kdepim/; revision=427075
mDlg->folderTree()->mainWidget()->headers()->reset();
and use a signal/slot connection between the folder and the header
svn path=/trunk/KDE/kdepim/; revision=424283
to somewhere else in the tree. Works for all source folder types but not
for online imap or search target folders. Part of this is the result of
a merge of the "Move folder to" functionality in HEAD since some of the
infrastructure can be shared. The "move to" part is disabled, though,
since it appears to be somewhat buggy and lose metainformation, such
as folder types, for example. ContentsType (mail, event, etc) information
is retained for the copies. A few const correctness fixes here and there.
svn path=/branches/proko2/kdepim/; revision=404928
remain stable during the lifetime of a message. In other words, don't
crash when changing the subject header of a message which is part of
the current subject threading trees. Pfew, this one was a bugger to fix.
BUGS: 94043
svn path=/trunk/kdepim/; revision=390027
dialog and include it in the RMB menu of the foldertree. To make the check if the menu
should be shown a bit easier the folderstorage got a new "isMoveable()" function.
I noticed that moving of imap folders crashes again when the messages are moved (sigh)
but this is not related so I'll fix it afterwards.
svn path=/trunk/kdepim/; revision=385541
folder was get'ed for every single mail. Now the folderstorage has an
addMsg( QPtrList<KMMessage> ) method and the imapjob can handle put operations
with a msgList. And the thingy has a nice progressitem now.
svn path=/trunk/kdepim/; revision=385105
Add folder RMB menu entry "Assign shortcut" which brings up a dialog to
select a Keyboard shortcut for the folder. Once the folder has a shortcut
you can also assign an icon to it and put it in your toolbar, since its just
a KAction under the hood. Shouldn't be hard to make it possible to create
the action without assigning a key shortcut, but that can come later, and
I'm not sure it's even needed.
The dialog must be the worst looking piece of gui on the planet, but I
promise to beautify it with a little help from my friends asap.
So after all these years away from mutt I can switch to my Inbox with one
keystroke again. Yeah!
svn path=/trunk/kdepim/; revision=353222
compact right away, we have to wait until the expiry job is done.
Found by looking at the debug output for #83847, but the bug is elsewhere.
svn path=/trunk/kdepim/; revision=331136
the renaming happens in the foldertree immediately, but is stored in the account
(with persistence in kconfig) and done on the server at the next sync.
If that fails, the server is renamed back locally.
svn path=/trunk/kdepim/; revision=319628
* When the user requests compaction of a folder from the RMB, always compact
(even if !needsCompaction), and ensure the final statusbar message shows up
(due to kmheaders polluting it, I had to save/restore it in 2 places).
* When compacting outbox after sending mails, don't tell the user.
This made me stumble upon strange code in kmsender.cpp: if count<0, expunge.
Ingo and I agree that this was meant to be if count==0, expunge.
svn path=/trunk/kdepim/; revision=319419
mbox and maildir folders in the background.
This fixes compaction not happening in kontact at all, and not happening
either for cached imap folders in kmail. It also makes kmail exit faster.
svn path=/trunk/kdepim/; revision=314475
Change the KMFolderMgr::find methods a bit to actually find all folders.
Oh well, and assign ids to all folders.
svn path=/trunk/kdepim/; revision=313955
(better than <foo.h>, especially when systems could have an identity.h somewhere)
A kconfig_update script moves the identities from kmailrc to emailidentities
svn path=/trunk/kdepim/; revision=311347
Thanks to Till for the advice on how to do that (storing folder id and using a KMMoveCommand)
Added kmkernel::findFolderById() to avoid copy/pasting yet another time
the code that looks in the 3 foldermgrs; ported the existing code to that.
CCMAIL: 43218-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=311024
instead of "on exit" (which made it non-working in kontact, with session management etc.)
GUI: removed the "Warn before expiring messages" and "On Exit: Expire old messages" options.
Tasks are filed with the jobscheduler, and the job for that task is started
only if the folder isn't opened - so this needed some special handling of search
folder (asking them to try releasing a given folder) and some fixes relative to
open() and close() calls, in kmfoldercachedimap and kmfoldersearch in particular.
Don: please check the kmfoldersearch.cpp changes, in particular the added close()
CCMAIL: sanders@kde.org
svn path=/trunk/kdepim/; revision=310272
folder after sending instead of the indentity sent-mail folder. This
overrides the identity setting, which I think makes sense. We'll have to
see if it causes trouble in some way.
There is no gui for this yet, as I would appreciate the input of Aaron
"Folder Properties" Seigo as to how to add yet another option to that
dialog without making it even taller than it already is. So to try this
you'll have to add a PutRepliesInSameFolder=true to the config section
corresponding to the folder you want to set it for.
This commit message is now officially longer than the whole patch. :)
svn path=/trunk/kdepim/; revision=302497
Ingo Klcker
Laurent Montel
Reinhold Kainhofer
Till Adam
David Faure
Thomas Zander
Allen Winter
Carsten Burghardt
Bo Thorsen
Zack Rusin