This is because KCharsets::encodingForName() prefers to return something "human-readable" now,
thank you very much. I wonder why this worked in 3.5, the hypen seems to be missing there as well.
The KCharsets code is too much magic to be understandable unfortunatley.
Apparently KMail has been sending invalid messages ever since 4.1 was released.
Urgh :(
I hope I didn't mix human- and machine-readable names anywhere, otherwise things will
break. This is also the reason I was too afraid to change this in kdelibs.
BUG: 171947
svn path=/trunk/KDE/kdepim/; revision=867007
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim
........
r852073 | ervin | 2008-08-25 11:46:26 +0200 (Mon, 25 Aug 2008) | 3 lines
Fix a small alignment issue with the attachements in the enterprise
header style.
........
svn path=/trunk/KDE/kdepim/; revision=855152
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim
........
r851790 | tmcguire | 2008-08-24 18:07:50 +0200 (Sun, 24 Aug 2008) | 5 lines
Make opening attachment from the attachment list in the header also work, by using the
same method to write the attachment URLs as in the body of the mail.
This fixes the last issue I had with the enterprise headers.
CCMAIL: ervin@kde.org
........
svn path=/trunk/KDE/kdepim/; revision=851797
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim
........
r851758 | tmcguire | 2008-08-24 16:39:12 +0200 (Sun, 24 Aug 2008) | 5 lines
Give enough space for the attachments so that no horizontal scrollbar appears.
BUG: 169657
CCMAIL: ervin@kde.org
........
svn path=/trunk/KDE/kdepim/; revision=851796
same method to write the attachment URLs as in the body of the mail.
This fixes the last issue I had with the enterprise headers.
CCMAIL: ervin@kde.org
svn path=/branches/kdepim/enterprise4/kdepim/; revision=851790
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/KDE/4.1/kdepim
........
r851216 | tmcguire | 2008-08-23 12:12:29 +0200 (Sat, 23 Aug 2008) | 12 lines
Backport r847987 by tmcguire from trunk to the 4.1 branch:
Don't duplicate attachment handling code in the mime part tree.
This fixes crashes when viewing loaded-on-demand attachments via the mime tree,
since it would not set mAtmUpdate correctly, which prevents re-creating the part
tree when the part is retrived. Re-creating the part-tree would make the pointers
inside the map of the load parts command invalid and therefore trigger a crash.
CCBUG: 136145
........
svn path=/branches/kdepim/enterprise4/kdepim/; revision=851355
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/KDE/4.1/kdepim
........
r842186 | tmcguire | 2008-08-04 22:56:32 +0200 (Mon, 04 Aug 2008) | 6 lines
Backport r842185 by tmcguire to the 4.1 branch:
Don't know why I removed this in r837483...
Hide the mimeparttree in the attachment viewer again, since it is empty anyways.
........
svn path=/branches/kdepim/enterprise4/kdepim/; revision=851343
Don't duplicate attachment handling code in the mime part tree.
This fixes crashes when viewing loaded-on-demand attachments via the mime tree,
since it would not set mAtmUpdate correctly, which prevents re-creating the part
tree when the part is retrived. Re-creating the part-tree would make the pointers
inside the map of the load parts command invalid and therefore trigger a crash.
CCBUG: 136145
svn path=/branches/KDE/4.1/kdepim/; revision=851216
Sill some deprecated warnigns, I guess I'll fix them myself now.
--
Merged revisions 843622,850460,850469 via svnmerge from
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim
................
r843622 | ervin | 2008-08-07 15:09:51 +0200 (Thu, 07 Aug 2008) | 143 lines
New Enterprise header style, and show attachements as part of the
header.
Closes kolab/merge74 aka "Extended attachment view".
On a personal note I hope it'll make it upstream, those two smallish
features are simply gorgeous IMHO.
[SNIP]
................
r850460 | ervin | 2008-08-21 17:12:23 +0200 (Thu, 21 Aug 2008) | 10 lines
Some fixes as requested by Thomas:
1) Enterprise header's mail picture doesn't overlap subject anymore;
2) In fancy header mode the attachments button is now left aligned;
3) The list of attachment doesn't scroll anymore with the enterprise
header;
4) Enterprise header now plays well with dark color schemes and
encapsulated messages.
Fixing deprecated calls and coding style will follow.
................
r850469 | ervin | 2008-08-21 17:43:46 +0200 (Thu, 21 Aug 2008) | 3 lines
Addresses the style and indentation issues found by Thomas
(from revision 843622).
................
svn path=/trunk/KDE/kdepim/; revision=850566
1) Enterprise header's mail picture doesn't overlap subject anymore;
2) In fancy header mode the attachments button is now left aligned;
3) The list of attachment doesn't scroll anymore with the enterprise
header;
4) Enterprise header now plays well with dark color schemes and
encapsulated messages.
Fixing deprecated calls and coding style will follow.
svn path=/branches/kdepim/enterprise4/kdepim/; revision=850460
This fixes crashes when viewing loaded-on-demand attachments via the mime tree,
since it would not set mAtmUpdate correctly, which prevents re-creating the part
tree when the part is retrived. Re-creating the part-tree would make the pointers
inside the map of the load parts command invalid and therefore trigger a crash.
BUG: 136145
svn path=/trunk/KDE/kdepim/; revision=847987
Don't know why I removed this in r837483...
Hide the mimeparttree in the attachment viewer again, since it is empty anyways.
svn path=/branches/KDE/4.1/kdepim/; revision=842186
Reasons:
- It was buggy (the recipientseditor, mimeparttree etc didn't obey to it)
- It is already provided by the KDE colorscheme (unlike the other color options)
Also, the ApplicationPaletteChange event is no longer used, so listen to
PaletteChange events instead.
BUG:102906
BUG:167346
svn path=/trunk/KDE/kdepim/; revision=837712
- Make the custom color option for misspelled words work again
- When not using custom colors, use the default color for the HTML
status bar and the signed/encrypted labels again.
svn path=/trunk/KDE/kdepim/; revision=837684
Merged revisions 830406,831603 via svnmerge from
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim
........
r830406 | staniek | 2008-07-10 13:07:35 +0200 (Thu, 10 Jul 2008) | 24 lines
Printing emails on Windows
The code (before patching) works on Linux (?) only by accident,
I guess (probably thanks to different strategy of handling QTimers with 0 delay [2]).
Explanation: KMReaderWin::printMsg() _can_ be executed before the timer
handling slotWriteNextHtmlChunk() finishes. And it is, on Windows.
- added KHtmlPartHtmlWriter::finished() signal, connected to KMReaderWin::slotPrintMsg().
- previous KMReaderWin::printMsg() code splitted into two pieces:
1st - KMReaderWin::printMsg( KMMessage* aMsg ) - connects the finished()
signal and calls setMsg(),
2nd - KMReaderWin::slotPrintMsg() - is a response for finished() signal,
calls mViewer->view()->print() and deletesLater() the KMReaderWin.
- at KMPrintCommand level, we keep QPointer<KMReaderWin> s_printerWin
globally until the KMReaderWin object is destroyed;
- on KMPrintCommand::execute() we call s_printerWin->htmlWriter()->reset()
to stop any previous processing
- added KMReaderWin::mPartHtmlWriter which is needed for connecting it's
signal to a slot
(reviewed)
........
r831603 | staniek | 2008-07-13 00:54:47 +0200 (Sun, 13 Jul 2008) | 23 lines
Printing emails:
Possible fix for Windows issue, reported at
http://intevation.de/roundup/kolab/issue2647
The code (before patching) works on Linux (?) only by accident, I guess
(probably thanks to different strategy of handling QTimers with 0 delay:
mHtmlTimer.start( 0 )).
Explanation: KMReaderWin::printMsg() _can_ be executed before
the timer handling slotWriteNextHtmlChunk() finishes. And it is, on Windows.
Details:
- added KHtmlPartHtmlWriter::finished() signal, connected to KMReaderWin::slotPrintMsg().
- previous KMReaderWin::printMsg() code splitted into two pieces:
1st - KMReaderWin::printMsg( KMMessage* aMsg ) - connects the finished()
signal and calls setMsg(),
2nd - KMReaderWin::slotPrintMsg() - is a response for finished() signal,
calls mViewer->view()->print() and deletesLater() the KMReaderWin.
- added KMReaderWin::mPartHtmlWriter which is needed for connecting its
signal to a slot
........
svn path=/branches/KDE/4.1/kdepim/; revision=835459
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim
........
r830406 | staniek | 2008-07-10 13:07:35 +0200 (Thu, 10 Jul 2008) | 24 lines
Printing emails on Windows
The code (before patching) works on Linux (?) only by accident,
I guess (probably thanks to different strategy of handling QTimers with 0 delay [2]).
Explanation: KMReaderWin::printMsg() _can_ be executed before the timer
handling slotWriteNextHtmlChunk() finishes. And it is, on Windows.
- added KHtmlPartHtmlWriter::finished() signal, connected to KMReaderWin::slotPrintMsg().
- previous KMReaderWin::printMsg() code splitted into two pieces:
1st - KMReaderWin::printMsg( KMMessage* aMsg ) - connects the finished()
signal and calls setMsg(),
2nd - KMReaderWin::slotPrintMsg() - is a response for finished() signal,
calls mViewer->view()->print() and deletesLater() the KMReaderWin.
- at KMPrintCommand level, we keep QPointer<KMReaderWin> s_printerWin
globally until the KMReaderWin object is destroyed;
- on KMPrintCommand::execute() we call s_printerWin->htmlWriter()->reset()
to stop any previous processing
- added KMReaderWin::mPartHtmlWriter which is needed for connecting it's
signal to a slot
(reviewed)
........
r831603 | staniek | 2008-07-13 00:54:47 +0200 (Sun, 13 Jul 2008) | 23 lines
Printing emails:
Possible fix for Windows issue, reported at
http://intevation.de/roundup/kolab/issue2647
The code (before patching) works on Linux (?) only by accident, I guess
(probably thanks to different strategy of handling QTimers with 0 delay:
mHtmlTimer.start( 0 )).
Explanation: KMReaderWin::printMsg() _can_ be executed before
the timer handling slotWriteNextHtmlChunk() finishes. And it is, on Windows.
Details:
- added KHtmlPartHtmlWriter::finished() signal, connected to KMReaderWin::slotPrintMsg().
- previous KMReaderWin::printMsg() code splitted into two pieces:
1st - KMReaderWin::printMsg( KMMessage* aMsg ) - connects the finished()
signal and calls setMsg(),
2nd - KMReaderWin::slotPrintMsg() - is a response for finished() signal,
calls mViewer->view()->print() and deletesLater() the KMReaderWin.
- added KMReaderWin::mPartHtmlWriter which is needed for connecting its
signal to a slot
........
svn path=/trunk/KDE/kdepim/; revision=834651
Possible fix for Windows issue, reported at
http://intevation.de/roundup/kolab/issue2647
The code (before patching) works on Linux (?) only by accident, I guess
(probably thanks to different strategy of handling QTimers with 0 delay:
mHtmlTimer.start( 0 )).
Explanation: KMReaderWin::printMsg() _can_ be executed before
the timer handling slotWriteNextHtmlChunk() finishes. And it is, on Windows.
Details:
- added KHtmlPartHtmlWriter::finished() signal, connected to KMReaderWin::slotPrintMsg().
- previous KMReaderWin::printMsg() code splitted into two pieces:
1st - KMReaderWin::printMsg( KMMessage* aMsg ) - connects the finished()
signal and calls setMsg(),
2nd - KMReaderWin::slotPrintMsg() - is a response for finished() signal,
calls mViewer->view()->print() and deletesLater() the KMReaderWin.
- added KMReaderWin::mPartHtmlWriter which is needed for connecting its
signal to a slot
svn path=/branches/kdepim/enterprise4/kdepim/; revision=831603
The code (before patching) works on Linux (?) only by accident,
I guess (probably thanks to different strategy of handling QTimers with 0 delay [2]).
Explanation: KMReaderWin::printMsg() _can_ be executed before the timer
handling slotWriteNextHtmlChunk() finishes. And it is, on Windows.
- added KHtmlPartHtmlWriter::finished() signal, connected to KMReaderWin::slotPrintMsg().
- previous KMReaderWin::printMsg() code splitted into two pieces:
1st - KMReaderWin::printMsg( KMMessage* aMsg ) - connects the finished()
signal and calls setMsg(),
2nd - KMReaderWin::slotPrintMsg() - is a response for finished() signal,
calls mViewer->view()->print() and deletesLater() the KMReaderWin.
- at KMPrintCommand level, we keep QPointer<KMReaderWin> s_printerWin
globally until the KMReaderWin object is destroyed;
- on KMPrintCommand::execute() we call s_printerWin->htmlWriter()->reset()
to stop any previous processing
- added KMReaderWin::mPartHtmlWriter which is needed for connecting it's
signal to a slot
(reviewed)
svn path=/branches/kdepim/enterprise4/kdepim/; revision=830406
- Use QHostInfo instead of KNetwork
- Q3Accel->KAction
- many QAction->KAction, so the default shortcut appears correct
again in the configure shortcuts dialog
The port of Q3Accel to KAction has the side effect that the shortcut
to scroll the message up/down can now be configured.
CCBUG:96301
svn path=/trunk/KDE/kdepim/; revision=803951
it provides very common functionality. Named it KPIM::TreeWidget
and used also as base of KMMimePartTree in kmail to maximize code reusal.
Others might take advantage of it.
Avoid using numeric constants for column indexes in KMMimePartTree.
Use descriptive preprocessor constants instead.
Implemented sorting in KMMimePartTree: it's useful when many attachments
are present and one wants only the ones of a certain type.
By default the sort indicator is not shown and we keep the sort insertion
order. We also revert to this order each time the view is filled.
Some minor additions to documentation
Source cleanup: inverted the order of a couple of functions.
svn path=/trunk/KDE/kdepim/; revision=803140
* show/hide attachment button is not shown when email has no attachments (kolab issue 2529)
svn path=/branches/kdepim/enterprise/kdepim/; revision=785558
SVN commit 775972 by kloecker:
Prevent the message in the reader window from jumping back to the start of the message when the font or the font size is changed in the separate reader window.
SVN commit 776092 by kloecker:
Integrate kmail-avoid-crash-on-startup.diff patch from the openSUSE RPM.
CCMAIL: adrian@novell.com
svn path=/branches/kdepim/enterprise/kdepim/; revision=778005
SVN commit 775972 by kloecker:
Prevent the message in the reader window from jumping back to the start of the message when the font or the font size is changed in the separate reader window.
svn path=/trunk/KDE/kdepim/; revision=776140
Thomas McGuire
Bertjan Broeksema
Kevin Ottens
Jarosaw Staniek
Urs Wolfer
Alex Merry
Szymon Stefanek
Thomas Moenicke
Pradeepto Bhattacharya
Ingo Klcker
Allen Winter