and there's no systray icon. This allows KMail to actually exit when closing it,
instead of getting stuck forever on a server that doesn't answer...
Compared to the kmail-devel patch I changed the code in KMMainWin to ensure
it's called even when secondary windows are left opened, and to enable mail
checks again when re-creating a KMMainWin.
I found out that the dimap progress dialog is broken with multiple kmmainwins,
but that's an independent issue, which will go away when porting it to Till's
progress dialog anyway.
svn path=/trunk/kdepim/; revision=307314
we must make sure that folderComplete() is sent _last_, since it triggers the next
mail check. This fixes a bug where the next mail check would abort immediately.
This was part of the kmail-devel patch, I removed the stuff about showing the
progress dialog again.
svn path=/trunk/kdepim/; revision=306873
base class. Port all users of slotSlaveError to that, so we now have
continue/cancel for errors with online imap as well. Also give context
for error messages to make them a little more descriptive. Make sure that
the jobs are removed only in non-error paths, because the error handler
does that as well now.
svn path=/trunk/kdepim/; revision=306243
as the first argument and then calls a virtual protected
handleJobErrorInternal with the job->error and job->errorText as arguments.
Port all users of handleJobError.
Agreed upon with David.
svn path=/trunk/kdepim/; revision=306219
mail syncs and use KMAccount::checkingMail() which is the generic tool
for the job instead. We need to make sure that all invocations of
processNewMail are guarded, and that all error paths reset it. Since we
are currently in the process of making error handling a bit less chaotic,
we'll hopefully achieve that.
svn path=/trunk/kdepim/; revision=306085
* Wait for completion of the "upload status flags" before continuing (as discussed with Till)
Maybe this was the reason for some status-flags bugs, like coolo's? Would be lucky though.
* Use a CachedImapJob for listing messages, so that handleJobError works in both cases
(continue/cancel)
* Replaced all showErrorDialog()s with handleJobError in CachedImapJob
* Moved slotSlaveError to ImapAccountBase (but deprecated it), calls new virtual handleJobError
* More fixes for sync aborted in subfolders
All tested with a "list permissions only" folder, to trigger all sorts of errors.
svn path=/trunk/kdepim/; revision=305740
Give the user the choice, for non-critical errors.
Currently only done for get/delete/expunge/put, more code should be ported
to handleJobError().
Added error() and signal result() to FolderJob to allow KMFolderCachedImap
to skip the expunge step if deleting failed.
Earlier versions of this patch were posted to kmail-devel, but Till told me
to go ahead :-)
svn path=/trunk/kdepim/; revision=305206
don't crash and reset state so that no other mail check is blocked and
re-syncing once the slave is back works.
svn path=/trunk/kdepim/; revision=299938
explicitely disconnect it, because we are using it in connection oriented
mode. Ideally we should also reset all syncs and kill all jobs, but there
is no infrastructure to do that, and I can't be arsed tonight.
This hopefully fixes the following scenario:
- slave is connected
- link goes down
- sync is started, asks the slave to list directories
- slave eventually times out, tells us it was disonnected, we don't react
- slave returns an empty listing, since it was disconnected
- KMail: oh, no folders on the server, let's nuke what we have locally as
well
- nextsync
- oh, all mail was deleted, let's delete it on the server as well, shall
we?
=> pmax enters #kontact saying something along the lines of: I am not
happy, dear KMail developers, I just lost all my mail. Cookies--
svn path=/trunk/kdepim/; revision=297662
by the next round of queued mail checks as a result of a finishedCheck
signal.
Also don't emit checkDone() when that is not the case.
Those two should finally fix queuing dimap mailchecks.
svn path=/trunk/kdepim/; revision=293689
Actually delete the folder in this case and do not block the new-mail-checks.
Fix Yet Another Disappearing Inbox.
Can anybody please commit this to osnabrueck_branch?
CCMAIL: 72031-done@bugs.kde.org
CCMAIL: coolo@kde.org
svn path=/trunk/kdepim/; revision=278028
folders tempOpened by filters are closed prematurely. They are now only
closed when there is no more filter using the filter manager.
svn path=/trunk/kdepim/; revision=262221
signals from being emitted.
This should fix the sent folder count updating bug. If it does not for
you, please reopen.
Patch Ok'ed by Till (Don also agreed that quiet() can be removed).
CCMAIL: 63670-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=260199
#define kernel KMKernel::self()
to
#define kmkernel KMKernel::self()
because 'kernel' was a much to general term. We really shouldn't repeat the mistakes of the X developers.
I noticed this problem when I played around with KImageEffects. kimageeffects.h contains 'kernel' as parameter of some methods and so the compilation had to fail. We won't need KImageEffects in the near future, but at least we are now prepared and a clash with another 'kernel' can't happen anymore.
svn path=/trunk/kdepim/; revision=252621
- Delete messages during transfer
- Minor cleanups
- Do not display headers when you skip over messages
CCMAIL: 62943-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=243659
Especially protocol() == "imap". Note that using ssl completely breaks those
checks then as the protocol is then "imaps". Also the string compares
are suboptimal there - use folderType() == KMFolderTypeSomeType.
svn path=/trunk/kdepim/; revision=238868
the job wasn't properly terminated, so the syncing 'state machine' was kind of stuck.
The underlying design issue is that KIO's connected slaves emit (via Scheduler) a
signal slaveError, totally unrelated to any job, and that killing the slave
kills the jobs _silently_ (without emitting result()).
As discussed with Waldo, the only way to handle this properly is to wait for the
slave to be connected (slaveConnected signal from Scheduler), before assigning
the slave to a job. I didn't rewrite all of kmail for it :) but I changed the
return value of makeConnection to be an enum: Error, Connected or Connecting.
This keeps compat with existing code which just checks it as a bool, but allows
KMFolderCachedImap to wait for the slaveConnected signal before proceeding.
Visually, this does the connection attempt at 0% progress instead of at 30%,
so it looks more logical :)
svn path=/trunk/kdepim/; revision=233801
kmacctmgr has 2 lists (currently checking and todo), the accounts care for the setting of the necessary flags.
All accounts show a transmission message, use -1 as newMailsProcessed argument to use your own message (e.g. in kmacctexppop)
svn path=/trunk/kdepim/; revision=210690
for me the "crash on reply" and "forward message crash" bugs and people
on IRC have been insisting on committing it. So yeah, asynchronous message
handling in KMail is in!!! May the God of Coding have mercy on us...
svn path=/trunk/kdenetwork/kmail/; revision=193386
David Faure
Till Adam
Carsten Burghardt
Bo Thorsen
Ingo Klcker
Ladislav Strojil
Marc Mutz
Zack Rusin
Stephan Kulow
Waldo Bastian