Move the static next() implementation from attachmentcollector.cpp to be a public partNode method. Implements iteration in "document order".
Use both to make AttachmentCollector skip the first text part, which would otherwise lead to the reply text being attached to a reply :)
svn path=/trunk/kdepim/; revision=318219
Add isHeuristicalAttachment(), which returns true if either isAttachment() is true, or if either the name or filename parameters is non-empty.
svn path=/trunk/kdepim/; revision=318179
Small cleanup. Get rid of partNode::CryptoType, which wasn't used for anything. Determine the CryptPlug to use for mp/signed by looking at the protocol parameter instead of searching for app/{pgp,pkcs7}-signature children.
(without the CryptPlugFactory)
--and--
candidate_for_3_2_1: Don't interpret application/pkcs7-mime; smime-type=certs-only as a signed message, but show an icon instead (until we have integrated enough of gpgme to be able to show a nice summary of the import as inline HTML).
svn path=/trunk/kdepim/; revision=281273
Refactor partNode creation from a KMMessage into a static method on partNode and port users to it. In the process of this, I found out that KMMessage, KMSaveAttachmentCommand and KMReaderWin all used very slightly different methods to instantiate the root item. I think most of them were wrong:
KMMessage's way (originally spread over two methods...) leaks mainBody...
KMReaderWins' way adds firstBodyPart as a child of itself...
KMSaveAttachmentsCommand doesn't adjust the mimetypes.
So that's why this is experimental: I've combined the various ways with majority vote: two adjusted the mimetypes, so mimetypes are adjusted. Only one added a part as child of it's own, so that's no longer being done, etc.
--and--
Replace broken, complicated logic with clean and simple one. Parsing is cheap in mimelib. That gives us the full MIME headers also in the top-level container partNode, which is needed in ae_branch to get at the protocol-Parameter of mp/signed parts...
svn path=/trunk/kdepim/; revision=281270
Crash was caused by the following header
Content-disposition: attachment; filename=
when kmail tried to access s[0] where s is the empty string behind filename=. The obvious fix is to test for s.isEmpty().
CCMAIL: 47856-fixed@bugs.kde.org
svn path=/trunk/kdenetwork/kmail/; revision=187212
debug output (only for the moment) to the IMAP methods to find out why it's broken
(finally got a few IMAP accounts, hopefully today few fixes for it will land)
svn path=/trunk/kdenetwork/kmail/; revision=169280
( see: http://www.gnupg.org/aegypten/ )
b) Removed some misleading warnings
c) Added Marc Mutz's patch of kmmsgpart.cpp: Make sure
Quoted Printable processing goes analogous to base64
by using KMime now and have some little improvements
in ::body().
d) AEGYPTEN_BRANCH was using KDockWidgets, these have been
(temporarily) disabled in the HEAD branch: will be
activated once KDockWidget has better usability.
Result of this: At the moment the new KMMimePartTree
is invisible - will be fixed right now.
PLEASE use the bug tracker to report any errors that might
result from this merger - additionally you may send mails
directly to me.
Karl-Heinz Zimmer, Senior Software Engineer, Klaraelvdalens Datakonsult AB
<mailto:khz@klaralvdalens-datakonsult.se> <mailto:khz@kde.org>
svn path=/trunk/kdenetwork/kmail/; revision=151089
Ingo Klcker
Marc Mutz
Till Adam
Carsten Burghardt
Dirk Mueller
Daniel Molkentin
Stephan Kulow
Karl-Heinz Zimmer
Michael Haeckel
Zack Rusin
Till Krech
Carsten Pfeiffer
Steffen Hansen