- In the action scheduler, don't error out when the filtered message
couldn't be moved back to the target folder. Instead, ignore the error
(but don't delete the orginal message). This fixes filtering
stopping on GMail accounts once a message was encountered that was not
moved to another folder, but stayed in the same folder (GMail prevents moving
in this case, since it thinks it is a duplicate message)
- When moving the filtered message with the action scheduler from the
temporary filter folder to the target folder, the original message wouldn't
get deleted properly.
The reason for this was that the move command thought the move failed because
a message with another serial number arrived.
Fix this by remembering the serial number (based on the message ID) when using
the action scheduler for filtering.
This fixes filters which move messages to other folders: Now the message is properly
removed from the source folder again.
- add comments and kDebug output
This does _not_ solve the following problem:
When using GMail and online IMAP, filter actions which modify the message will not have
any effect, since GMails duplicate message prevention prevents the filtered message to
be moved back to the IMAP folder.
This will not be fixed, I see no way to work around this. GMail should fix their IMAP
server instead.
Please test, I'm not sure if this is safe to backport.
CCBUG: 166150
svn path=/trunk/KDE/kdepim/; revision=833475
were false positives.
There is one warning left, about slotInfoMessage
in QuotaJobs::GetQuotarootjo. This seems to be
real, as neither that slot nor the signal
connected to that slot seem to exist with that
signature.
It would be nice if someone with IMAP knowledge could
fix that.
svn path=/trunk/KDE/kdepim/; revision=747352
https://vkrause@svn.kde.org/home/kde/branches/kdepim/enterprise/kdepim
........
r708706 | vkrause | 2007-09-05 15:26:11 +0200 (Wed, 05 Sep 2007) | 5 lines
Don't handle the seen flag here, seenFlagToStatus() can do that a lot
better. Fixes seen flag reading on initial folder downloads.
Kolab issue 1376.
........
svn path=/branches/work/kdab-post-4.0/kdepim/; revision=708721
https://vkrause@svn.kde.org/home/kde/branches/work/~vkrause/enterprise
........
r703761 | vkrause | 2007-08-23 09:48:47 +0200 (Thu, 23 Aug 2007) | 3 lines
Read PERMANENTFLAGS response. Needed to determine if we can store custom
flags on the server.
........
r703947 | vkrause | 2007-08-23 19:39:29 +0200 (Thu, 23 Aug 2007) | 2 lines
Add support for non-standard kmail flags.
........
r703962 | vkrause | 2007-08-23 20:11:39 +0200 (Thu, 23 Aug 2007) | 2 lines
fix removing of non-standard kmail flags
........
r704171 | vkrause | 2007-08-24 09:55:39 +0200 (Fri, 24 Aug 2007) | 4 lines
- read/write non-standard kmail flags
- correctly update flags that have been removed on the server
(KDE bug #134656)
........
r704179 | vkrause | 2007-08-24 10:31:25 +0200 (Fri, 24 Aug 2007) | 3 lines
Read PERMANENTFLAGS response for online IMAP as well. Needed to determine
if we can store custom flags on the server.
........
r704186 | vkrause | 2007-08-24 11:06:30 +0200 (Fri, 24 Aug 2007) | 5 lines
- only store non-standard flags on the server if it actually supports
that
- trigger migration of local flags (todo, forwarded, ignored, watched)
to the server
........
svn path=/branches/kdepim/enterprise/kdepim/; revision=704199
https://vkrause@svn.kde.org/home/kde/branches/work/~vkrause/enterprise
........
r703856 | vkrause | 2007-08-23 14:57:25 +0200 (Thu, 23 Aug 2007) | 2 lines
Add migration infrastructure to transfer local flags to the server.
........
r703887 | vkrause | 2007-08-23 16:34:57 +0200 (Thu, 23 Aug 2007) | 5 lines
Configuration update script to trigger migration of local IMAP flags to
the server. This should solve a regression due to the recent changes to
store the seen flag on the server also for read-only folders where all
local flags were overwritten.
........
svn path=/branches/kdepim/enterprise/kdepim/; revision=703903
https://vkrause@svn.kde.org/home/kde/branches/work/~vkrause/enterprise
........
r702953 | vkrause | 2007-08-21 18:36:00 +0200 (Tue, 21 Aug 2007) | 3 lines
Store seen flag on the server even in read-only folders, given the 's'
ACL flag is set.
........
r703210 | vkrause | 2007-08-22 09:43:04 +0200 (Wed, 22 Aug 2007) | 2 lines
Read seen flag also for read-only folder with the 's' ACL bit set.
........
r703455 | vkrause | 2007-08-22 16:37:33 +0200 (Wed, 22 Aug 2007) | 2 lines
Read/write seen flags on read-only online IMAP folders.
........
svn path=/branches/kdepim/enterprise/kdepim/; revision=703473
for the new kDebug/kError/kWarning/kFatal syntax.
You can use the following command to find 'old' code:
egrep -r -A 5 '(kDebug|kError|kWarning|kFatal).*' * | grep -v ".svn" | grep "<< *endl;"
svn path=/trunk/KDE/kdepim/; revision=695781
- for ( it = dir->begin(); (node = *it ) && it != dir->end(); ++it ) {
is really wrong, it dereferences the end iterator!
Plus apply patch from Laurent to use KIMAP::encodeImapFolderName instead of non-ported utf7-codec.
svn path=/trunk/KDE/kdepim/; revision=683868
SVN commit 662110 by wstephens:
3.5+ version of Till's dimap mail loss fix, see r662047
For reference :
SVN commit 662047 by tilladam:
Apply ported version of the mail loss debugging and explicit deletions patch,
which I've been developing with the help of some adventurous users. Thanks!
This tracks all deletions that happen through user actions and adds a check
to the sync making sure that only things that were explicitely deleted
are removed during sync. If unsure, the sync now re-downloads (duplicates)
instead of removing mails, which should be safer. Also adds a lot of
conditional debugging and refactors open/close to duplicate less code.
Will has a ported version of this for 3.x, which will go into pim+ shortly.
SVN commit 678604 by tilladam:
Clear the cache of explicitely deleted uids early enough, right after successful
deletion on the server, so messages taken during getting of messages (because of
filtering) are properly remembered. Fixes kolab/issue1792.
svn path=/branches/KDE/3.5/kdepim/; revision=680182