SVN commit 654636 by mkoller:
BUG#50462
I dare to close this bug report with this commit.
It basically automatically recreates the index whenever a "should never
happen" situation occurs in getting data from the index and retries to get
the requested information.
I hope it works as advertised
svn path=/branches/kdepim/enterprise/kdepim/; revision=668925
SVN commit 633071 by winterz:
merge SVN commit 632062 by adridg:
After updating KMail and throwing away index files, I encountered a file which has charset= set, and that triggered
a QGList warning when subscripting an empty string; adding this extra check for empty charsets stops crashing after
that warning.
SVN commit 633069 by winterz:
merge SVN commit 632089 by adridg:
TRUE and FALSE are C-isms, use C++ keywords instead
merge SVN commit 632360 by adridg:
Indentation style is spaces; there's crashes in here occasionally after removing index files, rather peculiar.
svn path=/branches/kdepim/enterprise/kdepim/; revision=667618
I dare to close this bug report with this commit.
It basically automatically recreates the index whenever a "should never
happen" situation occurs in getting data from the index and retries to get
the requested information.
I hope it works as advertised ;-)
svn path=/branches/KDE/3.5/kdepim/; revision=654636
Backport port of ...
SVN commit 645625 by pradeepto:
kolab/issue1583 - Fixing OL compatibility with attachments that have umlauts in the filename.
Volker's patch worked really awesome. Thanks Volker.
svn path=/branches/kdepim/proko2/kdepim/; revision=645630
TRUE and FALSE are C-isms, use C++ keywords instead
merge SVN commit 632360 by adridg:
Indentation style is spaces; there's crashes in here occasionally after removing index files, rather peculiar.
svn path=/branches/KDE/3.5/kdepim/; revision=633069
RFC 2231 defines an enhanced encoding for attachment filenames, and thunderbird
apparently implemented this encoding. RFC 2231 allows one field to be split
across multiple numbered entries of the form fieldname*0=....;
fieldname*1=...; fieldname*2=...; or fieldname*0=....; fieldname*1=...; fieldname*2=...;
All these entries first need to be concatenated to form the full value of the field.
Here's a real-life example:
--------------060807060608070200030605
Content-Type: application/vnd.ms-excel;
name*0*=ISO-8859-15''%41%46%42%D6%20%42%65%73%65%74%7A%75%6E%67%73%6C%69;
name*1*=%73%74%65%20%53%74%61%6E%64%20%32%30%30%36%2D%31%32%2D%31%39%2E;
name*2*=%78%6C%73
Content-Transfer-Encoding: base64
Content-Disposition: inline;
filename*0*=ISO-8859-15''%41%46%42%D6%20%42%65%73%65%74%7A%75%6E%67%73%6C;
filename*1*=%69%73%74%65%20%53%74%61%6E%64%20%32%30%30%36%2D%31%32%2D%31;
filename*2*=%39%2E%78%6C%73
As a result, KMail shows %39%2E%78%6C%73 as the file name in both the message
preview panel as well as in the mime tree.
With this patch, KMail correctly shows the proper filename.
The patch adds one static method to collect all parts of rfc 2231-encoded
params into one single string. That method is then used in two different
places for the name and the filename props.
One minor problem remains, though: As the mime library does not have support
for rfc2231 encoded attachments, the message is not shown with the attachment
icon in the message list.
BUG:108091
BUG:113100
svn path=/branches/KDE/3.5/kdepim/; revision=622052
Suppose headers charset from content-type header if headers not
properly encoded. If content-type charset is "us-ascii", use "utf-8"
instead. Write maildir and mbox indexes in right encoding.
BUGS:98079
svn path=/branches/KDE/3.5/kdepim/; revision=614058
Backporting lots of stuff from 3.5
Better KPaintInfo struct.
New helper methods from 3.5
Changes to context menu in mainwidget.
TODO: test painting of the leftmost column on a different
machine.
#1 Check if ToDo Icon is present or not.
#2 Check if the painting is borked or not.
svn path=/branches/kdepim/proko2/kdepim/; revision=556100
- kmail/imapaccountbase.cpp:1102
If line 1092 gets executed and also 1102, then the second crashes.
- kmail/kmmsgdict.cpp:248
If folder is NULL as indicated by line 244, then line 248 crashes.
- kmail/kmmsgdict.cpp:214
If folder is NULL as indicated by line 208, then line 214,225, crashes.
- kmail/renamejob.cpp:64
If storage is NULL as indicated by line 57, then line 62 crashes.
Lines where the operator preference between & and == leads to an error.
- kmail/kmmsgbase.cpp:873
- kmail/kmfolderimap.cpp:876
If f is NULL as indicated by line 869, then line 876 crashes.
- kmail/kmsender.cpp:362
If sentFolder is NULL as indicated by line 340, then line 362, 367
crashes.
Thanks to Christoph for working on this.
svn path=/branches/KDE/3.5/kdepim/; revision=530119
by a clear directive, that Ignored overrides New and Unread.
This is implemented in the isRead() and related methods.
BUG:97314
svn path=/branches/KDE/3.5/kdepim/; revision=463672
stripped of their old UID, by making sure the sernum mechanim is not
used for the complete flag, but there is a real bool per msgbase. This
one was fixed in trunk a while ago already ...
svn path=/branches/kdepim/proko2/kdepim/; revision=455461
objects. I've left the MessageProperty implementation, since the
attribute is transient, in a way. Hm. Opinions?
svn path=/trunk/KDE/kdepim/; revision=430877
of KMsgBase and into KMMessage, they are exclusively used on those and
don't make sense for MsgBase objects. Implement them using boolean
bits instead of the MessageProperty map, as discussed a while ago on
kmail-devel.
svn path=/trunk/KDE/kdepim/; revision=430849
here: http://lists.kde.org/?l=kmail-devel&m=111945756024656&w=2
I've changed the KMMsgDict::instance() to return a pointer instead of a
reference, compared to the patch I posted, after valid criticism from
Marc that the pattern is generally used with a pointer, in KDE, so it's
better not to surprise people here.
svn path=/trunk/KDE/kdepim/; revision=428560
lead to a slow down when loading messages (and they weren't doing anything
then, since getMsgSerNum()==0).
svn path=/branches/KDE_3_3_BRANCH/kdepim/; revision=361959
when simply opening mail folders) : don't look for the serial numbers
of messages that haven't been inserted into a folder yet, it can't find one,
and it's slow every time. Note that assign() is only called on construction
(or soon after), never on totally-unrelated instances.
svn path=/trunk/kdepim/; revision=361937
You don't need getMsg anymore for the UID and LOD can check the size without loading the header.
I updated the online imap folder but dimap should also use the new code.
svn path=/trunk/kdepim/; revision=288206
compilation flags :)
(I knew --diable-debug makes a difference, but I wasn't really aware it flies
for users ;)
svn path=/trunk/kdepim/; revision=270960
This should fix a bug with ad hoc filters crashing when they move a message
to a different folder.
And also fix the bug/limitation that the move to folder action has to
come last in the list of filter actions for a filter.
This commit doesn't really use the action scheduler, code to use the
action scheduler in kmheaders and kmcommands is commented out.
I've been testing this code for a few weeks now. The changes to the
assignment operators in the kmmessage and kmmsgbase classes are the
changes I'm most concerned about here.
svn path=/trunk/kdepim/; revision=264912