The storage needs to be open before remove is called, otherwise
it will not unregister the corresponding serial numbers from
the message dict, since its message list is empty, and the .ids
file contents are not loaded. That can lead to lookups in the
dict returning stale pointers to the folder later.
svn path=/branches/kdepim/enterprise/kdepim/; revision=700851
keeping the msginfo pointer around in the message object, and restoring it on
unGet. Should help with a whole class of crashes around filtering, searching
etc. Original patch by Ingo and Andreas, with some fixes and memleak plugs
in corner cases by me. We'll testdrive this a while in enterprise branch, let's
see how it behaves.
CCMAIL: a.gungl@gmx.de
CCMAIL: ingo@kde.org
svn path=/branches/kdepim/enterprise/kdepim/; revision=694327
kmail. Add the ability to use a configurable color for the
folder name and size when it is close to a configurable quota
threshold (provided the folder has quota info in the first
place). Implement size retrieval for mbox and maildir storage.
(prokde35 w1-6)
svn path=/branches/kdepim/enterprise/kdepim/; revision=669156
SVN commit 627641 by winterz:
Fix for the grave bug "kmail crash when I make a CTRL + J in inbox"
BUGS: 140660
svn path=/branches/kdepim/enterprise/kdepim/; revision=665658
This obviously reintroduces issue661, "forwarding emails can produce bad signature", which will have to be fixed another way once I get more infos about it.
Also remove getMsgString from all folder classes, since it's now unused; getDwString is used instead.
svn path=/branches/kdepim/enterprise/kdepim/; revision=650094
branches/work/kdepim-3.5.5+.
These contain the following features from the enterprise branch:
- (nearly) all folders can be copyied or moved now
- dnd of one or multiple folders
- copy/cut/paste actions for one or multiple folders
- dnd of messages from the search result window to the folder tree
- copy/cut/paste actions for messages (in the header view and search
result window)
svn path=/branches/KDE/3.5/kdepim/; revision=648059
- copying/moving of folders with drag&drop
- copy/cut/paste actions for folders and messages
svn path=/branches/kdepim/enterprise/kdepim/; revision=633254
(readFolderIds() returned -1, so invalidateFolder() was called,
which calls open/close, and close() calls updateIndex()+writeConfig() when mAutoCreateIndex is true.)
This should fix the frequent loss of folder settings.
CCMAIL: kmail-devel@kde.org
svn path=/branches/KDE/3.5/kdepim/; revision=531267
sed 's/59 Temple Place - Suite 330, Boston, MA 02111-1307/51 Franklin Street, Fifth Floor, Boston, MA 02110-1301/'
PS: I didn't touch the kalarm dir, since david seems to update the address himself, and I don't want to create conflicts for him.
CCMAIL:lists@astrojar.org.uk
svn path=/trunk/KDE/kdepim/; revision=437921
the helper function crlf2lf there, which was formerly a class static in
FolderStorage. Remove the now obsolete forward Folder -> Folderstorage
and port all users.
svn path=/trunk/KDE/kdepim/; revision=435216
were "saved" to kmailrc, but kmailrc wasn't synced, so in case of a kmail crash, X crash, power failure, kernel oops...
the settings would be lost, and on the next kmail restart very strange errors would happen when syncing
(can't create folder, folder already there, folder missing, etc.)
The solution: sync(). But while being at it I implemented buffering of sync requests
which was a TODO in kmkernel, but did it in GlobalSettings as Till suggested;
which in turn means we need our own GlobalSettings inheriting GlobalSettingsBase,
and the code lacked ::self()-> in many places to allow that.
svn path=/branches/kdepim/proko2/kdepim/; revision=432536
propagate that as an icon change to the foldertree, which makes sure
that it has the current type, before rendering the icon. All this to
make the right icon appear on newly downloaded folders.
svn path=/branches/kdepim/proko2/kdepim/; revision=431511
it, if there is no physical folder yet. Code creating (instantiating)
KMFolders does not need to care. Remove the ugly "bool imap" parameter
from create() and do proper reimplementation instead. Remove create()
forward from KMFolder -> FolderStorage.
This fixes "no such file or folder" warnings when creating or syncing
down new folders.
In case you missed it, today is Zack's birthday, so show the man some
love, will ya?
svn path=/trunk/KDE/kdepim/; revision=430989
handling and index handling.
o Make it possible to have folders that optionally have no index
and/or don't export their serial numbers to the message dict. This
was partly possible before, but relying on all kinds of implicit (and
often wrong) assumptions as to the presence and state of various
datastructures and files on disk.
o [TRUE|FALSE] => [true|false] (sorry about mixing this in)
o group a bunch of bools and use a bit for each to save memory
o remove index related forwards folder -> folderstorage
o api dox additions
Fixed the crashes with local and maildir accounts in the process, I
think.
BUG: 108386
svn path=/trunk/KDE/kdepim/; revision=430817
right way to fix it, though, it would be better to have an explicit
"this is a folder without an index and without exported serial numbers"
flag of some kind. Ingo do you agree?
CCMAIL: kmail-devel@kde.org
svn path=/trunk/KDE/kdepim/; revision=429482
here: http://lists.kde.org/?l=kmail-devel&m=111945756024656&w=2
I've changed the KMMsgDict::instance() to return a pointer instead of a
reference, compared to the patch I posted, after valid criticism from
Marc that the pattern is generally used with a pointer, in KDE, so it's
better not to surprise people here.
svn path=/trunk/KDE/kdepim/; revision=428560
o remove access to the reverse per folder message dict entries from the
folder interface. It's in FolderStorage and accessed through there
svn path=/trunk/KDE/kdepim/; revision=427075
mDlg->folderTree()->mainWidget()->headers()->reset();
and use a signal/slot connection between the folder and the header
svn path=/trunk/KDE/kdepim/; revision=424283
to somewhere else in the tree. Works for all source folder types but not
for online imap or search target folders. Part of this is the result of
a merge of the "Move folder to" functionality in HEAD since some of the
infrastructure can be shared. The "move to" part is disabled, though,
since it appears to be somewhat buggy and lose metainformation, such
as folder types, for example. ContentsType (mail, event, etc) information
is retained for the copies. A few const correctness fixes here and there.
svn path=/branches/proko2/kdepim/; revision=404928
remain stable during the lifetime of a message. In other words, don't
crash when changing the subject header of a message which is part of
the current subject threading trees. Pfew, this one was a bugger to fix.
BUGS: 94043
svn path=/trunk/kdepim/; revision=390027
dialog and include it in the RMB menu of the foldertree. To make the check if the menu
should be shown a bit easier the folderstorage got a new "isMoveable()" function.
I noticed that moving of imap folders crashes again when the messages are moved (sigh)
but this is not related so I'll fix it afterwards.
svn path=/trunk/kdepim/; revision=385541
folder was get'ed for every single mail. Now the folderstorage has an
addMsg( QPtrList<KMMessage> ) method and the imapjob can handle put operations
with a msgList. And the thingy has a nice progressitem now.
svn path=/trunk/kdepim/; revision=385105
Add folder RMB menu entry "Assign shortcut" which brings up a dialog to
select a Keyboard shortcut for the folder. Once the folder has a shortcut
you can also assign an icon to it and put it in your toolbar, since its just
a KAction under the hood. Shouldn't be hard to make it possible to create
the action without assigning a key shortcut, but that can come later, and
I'm not sure it's even needed.
The dialog must be the worst looking piece of gui on the planet, but I
promise to beautify it with a little help from my friends asap.
So after all these years away from mutt I can switch to my Inbox with one
keystroke again. Yeah!
svn path=/trunk/kdepim/; revision=353222
Thomas Moenicke
Pradeepto Bhattacharya
Till Adam
Allen Winter
David Faure
Volker Krause
Stephan Kulow
Albert Astals Cid
Andreas Gungl
Ingo Klcker
Szombathelyi Gyrgy
Reinhold Kainhofer
Thomas Zander
Carsten Burghardt
Bo Thorsen