When deleting an account, there may be jobs live on that account that aren't automatically cleaned up. Make them safe in places where they lookup the account.
svn path=/trunk/KDE/kdepim/; revision=645403
didn't read far enough down into the commit logs.. this is the way
Till wanted to fix the crash in slotNextMessage() as commented on by monur.
svn path=/trunk/KDE/kdepim/; revision=537488
530060:
--------------
Fix the following problems as indicated by Christoph Bartoschek in kde-pim:
- kmail/imapjob.cpp:240
- kmail/imapjob.cpp:262 (similar)
If account is NULL as indicated by line 226, then line 240 crashes.
- kmail/imapjob.cpp:104
If msg_parent is NULL as indicated by line 90, then line 104 crashes.
530074:
--------------
Second batch of fixes related to Christoph Bartoschek's report in kde-pim:
- kmail/kmfoldercachedimap.cpp:1749
If the if conditions in line 1741 and 1745 are both false, then line 1749 crashes.
- kmail/kmfoldertree.cpp:1480
If fti is NULL as indicated by line 1475, then line 1480 crashes.
- kmail/kmfoldertree.cpp:164
If mFolder is NULL as indicated by line 154, then line 154, 160 crash.
- kmail/kmfoldertree.cpp:143
If mFolder is NULL as indicated by line 136, then line 143 crashes.
- kmail/kmfoldertree.cpp:1549
If folder is NULL as indicated by line 1537, then line 1549 crashes.
The last bug is only partially fixed, the whole KMFolderTree::slotUpdateCounts(KMFolder * folder)
function could use a rewrite.
530119:
------------
Third batch of fixes related to Christoph Bartoschek's email in kde-pim:
- kmail/imapaccountbase.cpp:1102
If line 1092 gets executed and also 1102, then the second crashes.
- kmail/kmmsgdict.cpp:248
If folder is NULL as indicated by line 244, then line 248 crashes.
- kmail/kmmsgdict.cpp:214
If folder is NULL as indicated by line 208, then line 214,225, crashes.
- kmail/renamejob.cpp:64
If storage is NULL as indicated by line 57, then line 62 crashes.
Lines where the operator preference between & and == leads to an error.
- kmail/kmmsgbase.cpp:873
- kmail/kmfolderimap.cpp:876
If f is NULL as indicated by line 869, then line 876 crashes.
- kmail/kmsender.cpp:362
If sentFolder is NULL as indicated by line 340, then line 362, 367
crashes.
Thanks to Christoph for working on this.
svn path=/trunk/KDE/kdepim/; revision=532932
- kmail/imapjob.cpp:240
- kmail/imapjob.cpp:262 (similar)
If account is NULL as indicated by line 226, then line 240 crashes.
- kmail/imapjob.cpp:104
If msg_parent is NULL as indicated by line 90, then line 104 crashes.
svn path=/branches/KDE/3.5/kdepim/; revision=530060
the helper function crlf2lf there, which was formerly a class static in
FolderStorage. Remove the now obsolete forward Folder -> Folderstorage
and port all users.
svn path=/trunk/KDE/kdepim/; revision=435216
We do not need any other msgHeaderChanged calls as I see it.
The searchcommand was actually a bit buggy: the local search part of combined imap-local
searches was simply ignored when a message was updated. This is fixed now. Happy searching.
svn path=/trunk/KDE/kdepim/; revision=425074
previously not, three individual searches of the mail are triggered,
from updateAttachementState, updateSignatureState and
updateEncryptionState. Unfortunately they are precisely triggered from
ImapJob::slotGetMessageData which calls msg->fromByteArray with the data
it received from the server as a result of the message being fetched
after selection. During that fromByteArray the message has no UID
header, since the raw mail returned from the server doesn't, and
therefore KMMessage::UID() returns 0, which causes the first (and only
the first) of the three searches mentioned above to fail. The others
succeed, since they are executed asynchronously and already find
the restored uid in KMMessage::UID() when to get to asking for it. This
results in the message being removed from the search folder and
immediately re-added, which makes imap based search folders virtually
unusable.
Should only be a problem in trunk, I think, since only there are search
folders hooked up to messageHeaderChanged(). Right, Carsten?
Now I can read my kdepim commits search folder again. Rainy Saturday well
spent, I guess. Back to Kolab. ;)
CCMAIL: burghardt@kde.org
svn path=/trunk/KDE/kdepim/; revision=422163
For several messages the progress shows only the overall status but this can only
be changed in the progressmanager api which is probably a past-3.4 task.
CCMAIL: 97920@bugs.kde.org
svn path=/trunk/kdepim/; revision=391417
folder was get'ed for every single mail. Now the folderstorage has an
addMsg( QPtrList<KMMessage> ) method and the imapjob can handle put operations
with a msgList. And the thingy has a nice progressitem now.
svn path=/trunk/kdepim/; revision=385105
Stephan Kulow
Allen Winter
Will Stephenson
Mathias Soeken
Rafael Fernndez Lpez
Till Adam
Ingo Klcker
Laurent Montel
David Faure
Reinhold Kainhofer
Ismail Onur Filiz
Chusslove Illich
Andreas Gungl
Volker Krause
Tom Albers
Carsten Burghardt