Check "\"<foo@kde.com>\" <foo@kde.com>" it's not a potential phishing email.

Thanks David to signal me it
wilder-work
Montel Laurent 11 years ago
parent a00110bdf1
commit fbf510ba68
  1. 2
      editor/potentialphishingemail/autotests/potentialphishingemailjobtest.cpp
  2. 4
      editor/potentialphishingemail/potentialphishingemailjob.cpp
  3. 2
      editor/potentialphishingemail/potentialphishingemailwarning.cpp

@ -53,6 +53,8 @@ void PotentialPhishingEmailJobTest::shouldReturnPotentialPhishingEmails_data()
QTest::newRow("EmailInWhiteList") << (QStringList() << email) << (QStringList() << email) << false;
QTest::newRow("NotAllEmailInWhiteList") << (QStringList() << email << QLatin1String("\"c@kde.org\" <dd@kde.org>")) << (QStringList() << email) << true;
QTest::newRow("EmailInWhiteListWithSpace") << (QStringList() << QLatin1String(" \"bla@kde.org\" <foo@kde.org> ")) << (QStringList() << email) << false;
QTest::newRow("EmailWithSameNameAndDisplayName") << (QStringList() << QLatin1String("\"<foo@kde.com>\" <foo@kde.com>")) << (QStringList() << email) << false;
QTest::newRow("EmailWithSameNameAndDisplayNameWithSpace") << (QStringList() << QLatin1String(" \"<foo@kde.com>\" <foo@kde.com> ")) << (QStringList() << email) << false;
}
void PotentialPhishingEmailJobTest::shouldReturnPotentialPhishingEmails()

@ -60,6 +60,9 @@ bool PotentialPhishingEmailJob::start()
KPIMUtils::extractEmailAddressAndName( addr, temail, tname ); // ignore return value
// which is always false
if (tname.contains(QLatin1String("@"))) { //Potential address
if (tname.startsWith(QLatin1Char('<')) && tname.endsWith(QLatin1Char('>'))) {
tname = tname.mid(1,tname.length()-2);
}
if (temail != tname) {
mPotentialPhisingEmails.append(addr);
}
@ -70,4 +73,3 @@ bool PotentialPhishingEmailJob::start()
deleteLater();
return true;
}

@ -35,7 +35,7 @@ PotentialPhishingEmailWarning::PotentialPhishingEmailWarning(QWidget *parent)
setWordWrap(true);
//Add i18n in kf5
setText(QLatin1String("Some address mail seems a potential phishing email <a href=\"phishingdetails\">(Details...)</a>"));
setText(QLatin1String("Some email address seems a potential phishing email <a href=\"phishingdetails\">(Details...)</a>"));
connect(this, SIGNAL(linkActivated(QString)), SLOT(slotShowDetails(QString)));
//Add i18n in kf5

Loading…
Cancel
Save