diff --git a/editor/kmcomposewin.cpp b/editor/kmcomposewin.cpp index fa48af5b8..81d0506d1 100644 --- a/editor/kmcomposewin.cpp +++ b/editor/kmcomposewin.cpp @@ -2992,7 +2992,6 @@ void KMComposeWin::slotCheckSendNow() PotentialPhishingEmailJob *job = new PotentialPhishingEmailJob(this); KConfigGroup group( KSharedConfig::openConfig(), "PotentialPhishing"); const QStringList whiteList = group.readEntry("whiteList", QStringList()); - qDebug()<<" whiteList"<setEmailWhiteList(whiteList); QStringList lst; lst << mComposerBase->to(); @@ -3007,15 +3006,11 @@ void KMComposeWin::slotCheckSendNow() void KMComposeWin::slotPotentialPhishingEmailsFound(const QStringList &list) { -#if 1 - slotCheckSendNowStep2(); -#else if (list.isEmpty()) { slotCheckSendNowStep2(); } else { mPotentialPhishingEmailWarning->setPotentialPhisingEmail(list); } -#endif } bool KMComposeWin::checkRecipientNumber() const diff --git a/editor/potentialphishingemail/autotests/potentialphishingemailjobtest.cpp b/editor/potentialphishingemail/autotests/potentialphishingemailjobtest.cpp index 896ab8433..b848f307d 100644 --- a/editor/potentialphishingemail/autotests/potentialphishingemailjobtest.cpp +++ b/editor/potentialphishingemail/autotests/potentialphishingemailjobtest.cpp @@ -52,6 +52,7 @@ void PotentialPhishingEmailJobTest::shouldReturnPotentialPhishingEmails_data() const QString email = QLatin1String("\"bla@kde.org\" "); QTest::newRow("EmailInWhiteList") << (QStringList() << email) << (QStringList() << email) << false; QTest::newRow("NotAllEmailInWhiteList") << (QStringList() << email << QLatin1String("\"c@kde.org\" ")) << (QStringList() << email) << true; + QTest::newRow("EmailInWhiteListWithSpace") << (QStringList() << QLatin1String(" \"bla@kde.org\" ")) << (QStringList() << email) << false; } void PotentialPhishingEmailJobTest::shouldReturnPotentialPhishingEmails() diff --git a/editor/potentialphishingemail/potentialphishingdetaildialog.cpp b/editor/potentialphishingemail/potentialphishingdetaildialog.cpp index 7091015a7..ab57fa3db 100644 --- a/editor/potentialphishingemail/potentialphishingdetaildialog.cpp +++ b/editor/potentialphishingemail/potentialphishingdetaildialog.cpp @@ -87,15 +87,18 @@ void PotentialPhishingDetailDialog::slotSave() { KConfigGroup group( KSharedConfig::openConfig(), "PotentialPhishing"); QStringList potentialPhishing = group.readEntry("whiteList", QStringList()); + bool emailsAdded = false; for (int i=0; i < mListWidget->count(); ++i) { QListWidgetItem *item = mListWidget->item(i); if (item->checkState() == Qt::Checked) { QString email = item->text(); if (!potentialPhishing.contains(email)) { potentialPhishing << email; + emailsAdded = true; } } } - group.writeEntry( "whiteList", potentialPhishing); + if (emailsAdded) + group.writeEntry( "whiteList", potentialPhishing); accept(); }