From e82ad02975d1003aafe54cd3c027e7b207cf1576 Mon Sep 17 00:00:00 2001
From: Laurent Montel <montel@kde.org>
Date: Mon, 18 May 2020 08:16:07 +0200
Subject: [PATCH] Initialize variable in header

---
 src/job/fillcomposerjob.cpp     |  1 -
 src/job/fillcomposerjob.h       | 11 ++++-------
 src/job/handleclickedurljob.cpp |  2 --
 src/job/newmessagejob.cpp       |  1 -
 src/job/newmessagejob.h         |  2 +-
 src/job/savedraftjob.h          |  2 +-
 6 files changed, 6 insertions(+), 13 deletions(-)

diff --git a/src/job/fillcomposerjob.cpp b/src/job/fillcomposerjob.cpp
index af1db8dc9..e9eda342d 100644
--- a/src/job/fillcomposerjob.cpp
+++ b/src/job/fillcomposerjob.cpp
@@ -29,7 +29,6 @@
 
 FillComposerJob::FillComposerJob(QObject *parent)
     : QObject(parent)
-    , mMsg(nullptr)
 {
 }
 
diff --git a/src/job/fillcomposerjob.h b/src/job/fillcomposerjob.h
index e69a4dbb2..ed32cf163 100644
--- a/src/job/fillcomposerjob.h
+++ b/src/job/fillcomposerjob.h
@@ -26,9 +26,6 @@
 struct FillComposerJobSettings
 {
     FillComposerJobSettings()
-        : mIdentity(0)
-        , mForceShowWindow(false)
-        , mHidden(false)
     {
     }
 
@@ -68,9 +65,9 @@ struct FillComposerJobSettings
     QString mAttachParamValue;
     QByteArray mAttachContDisp;
     QByteArray mAttachCharset;
-    unsigned int mIdentity;
-    bool mForceShowWindow;
-    bool mHidden;
+    unsigned int mIdentity = 0;
+    bool mForceShowWindow = false;
+    bool mHidden = false;
 };
 
 class FillComposerJob : public QObject
@@ -86,7 +83,7 @@ private:
     Q_DISABLE_COPY(FillComposerJob)
     void slotOpenComposer();
     FillComposerJobSettings mSettings;
-    KMime::Message::Ptr mMsg;
+    KMime::Message::Ptr mMsg = nullptr;
 };
 
 #endif // FILLCOMPOSERJOB_H
diff --git a/src/job/handleclickedurljob.cpp b/src/job/handleclickedurljob.cpp
index 70e976e46..04bc02bd6 100644
--- a/src/job/handleclickedurljob.cpp
+++ b/src/job/handleclickedurljob.cpp
@@ -29,8 +29,6 @@
 
 HandleClickedUrlJob::HandleClickedUrlJob(QObject *parent)
     : QObject(parent)
-    , mIdentity(0)
-    , mMsg(nullptr)
 {
 }
 
diff --git a/src/job/newmessagejob.cpp b/src/job/newmessagejob.cpp
index 0fb43e492..7654dca26 100644
--- a/src/job/newmessagejob.cpp
+++ b/src/job/newmessagejob.cpp
@@ -28,7 +28,6 @@
 
 NewMessageJob::NewMessageJob(QObject *parent)
     : QObject(parent)
-    , mMsg(nullptr)
 {
 }
 
diff --git a/src/job/newmessagejob.h b/src/job/newmessagejob.h
index e0f2ad3bf..0a2af7664 100644
--- a/src/job/newmessagejob.h
+++ b/src/job/newmessagejob.h
@@ -67,7 +67,7 @@ private:
     NewMessageJobSettings mNewMessageJobSettings;
     Akonadi::Collection mCollection;
     QUrl mAttachURL;
-    KMime::Message::Ptr mMsg;
+    KMime::Message::Ptr mMsg = nullptr;
 };
 
 #endif // NEWMESSAGEJOB_H
diff --git a/src/job/savedraftjob.h b/src/job/savedraftjob.h
index 0d8e1fc30..60e9ebdee 100644
--- a/src/job/savedraftjob.h
+++ b/src/job/savedraftjob.h
@@ -36,7 +36,7 @@ public:
 
 private:
     void slotStoreDone(KJob *job);
-    KMime::Message::Ptr mMsg;
+    KMime::Message::Ptr mMsg = nullptr;
     Akonadi::Collection mCollection;
 };