From bd6d72f744b76ded030f5812b2ecdcdf2b499032 Mon Sep 17 00:00:00 2001 From: Laurent Montel Date: Mon, 26 Aug 2019 13:39:06 +0200 Subject: [PATCH] QString::remove operates on the same object, no need to reassign --- src/identity/xfaceconfigurator.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/identity/xfaceconfigurator.cpp b/src/identity/xfaceconfigurator.cpp index c594f6353..2af77b14f 100644 --- a/src/identity/xfaceconfigurator.cpp +++ b/src/identity/xfaceconfigurator.cpp @@ -276,7 +276,7 @@ void XFaceConfigurator::slotUpdateXFace() if (!str.isEmpty()) { if (str.startsWith(QLatin1String("x-face:"), Qt::CaseInsensitive)) { - str = str.remove(QStringLiteral("x-face:"), Qt::CaseInsensitive); + str.remove(QStringLiteral("x-face:"), Qt::CaseInsensitive); mTextEdit->editor()->setPlainText(str); } KXFace xf;