Fix some warning found by clazy

agents/archivemailagent/archivemailkernel.h

@@ -34,6 +34,7 @@ class JobScheduler;
 
 class ArchiveMailKernel : public QObject, public MailCommon::IKernel, public MailCommon::ISettings
 {
+    Q_OBJECT
 public:
     explicit ArchiveMailKernel(QObject *parent = nullptr);
 

agents/mailfilteragent/dummykernel.h

@@ -14,6 +14,7 @@ class FolderCollectionMonitor;
 
 class DummyKernel : public QObject, public MailCommon::IKernel, public MailCommon::ISettings
 {
+    Q_OBJECT
 public:
     explicit DummyKernel(QObject *parent = nullptr);
 

agents/sendlateragent/autotests/sendlaterinfotest.cpp

@@ -25,7 +25,8 @@
 #include <KSharedConfig>
 #include <QStandardPaths>
 
-SendLaterInfoTest::SendLaterInfoTest()
+SendLaterInfoTest::SendLaterInfoTest(QObject *parent)
+    : QObject(parent)
 {
     QStandardPaths::setTestModeEnabled(true);
 }

agents/sendlateragent/autotests/sendlaterinfotest.h

@@ -26,7 +26,7 @@ class SendLaterInfoTest : public QObject
 {
     Q_OBJECT
 public:
-    SendLaterInfoTest();
+    explicit SendLaterInfoTest(QObject *parent = nullptr);
 
 private Q_SLOTS:
     void shouldHaveDefaultValue();

agents/unifiedmailboxagent/unifiedmailbox.cpp

@@ -137,12 +137,12 @@ void UnifiedMailbox::attachManager(UnifiedMailboxManager *manager)
     if (mManager != manager) {
         if (manager) {
             // Force that we start monitoring all the collections
-            for (auto source : mSources) {
+            for (const auto source : qAsConst(mSources)) {
                 manager->mMonitor.setCollectionMonitored(Akonadi::Collection{source});
                 manager->mSourceToBoxMap.insert({ source, this });
             }
         } else {
-            for (auto source : mSources) {
+            for (const auto source : qAsConst(mSources)) {
                 mManager->mMonitor.setCollectionMonitored(Akonadi::Collection{source}, false);
                 mManager->mSourceToBoxMap.erase(source);
             }

src/autotests/displaymessageformatactionmenutest.cpp

@@ -23,7 +23,8 @@
 #include <KToggleAction>
 #include <QSignalSpy>
 Q_DECLARE_METATYPE(MessageViewer::Viewer::DisplayFormatMessage)
-DisplayMessageFormatActionMenuTest::DisplayMessageFormatActionMenuTest()
+DisplayMessageFormatActionMenuTest::DisplayMessageFormatActionMenuTest(QObject *parent)
+    : QObject(parent)
 {
     qRegisterMetaType<MessageViewer::Viewer::DisplayFormatMessage >();
 }

src/autotests/displaymessageformatactionmenutest.h

@@ -24,7 +24,7 @@ class DisplayMessageFormatActionMenuTest : public QObject
 {
     Q_OBJECT
 public:
-    DisplayMessageFormatActionMenuTest();
+    explicit DisplayMessageFormatActionMenuTest(QObject *parent = nullptr);
 private Q_SLOTS:
     void shouldHaveDefaultValue();
     void shouldEmitSignalWhenClickOnSubMenu();

src/editor/kmcomposerwin.cpp

@@ -362,7 +362,7 @@ KMComposerWin::KMComposerWin(const KMime::Message::Ptr &aMsg, bool lastSignState
     mRichTextEditorwidget = new KPIMTextEdit::RichTextEditorWidget(composerEditorNg, mCryptoStateIndicatorWidget);
 
     //Don't use new connect api here. It crashs
-    connect(composerEditorNg, SIGNAL(textChanged()), this, SLOT(slotEditorTextChanged()));
+    connect(composerEditorNg, &QTextEdit::textChanged, this, &KMComposerWin::slotEditorTextChanged);
     connect(composerEditorNg, &KMComposerEditorNg::selectionChanged, this, &KMComposerWin::slotSelectionChanged);
     //connect(editor, &KMComposerEditor::textChanged, this, &KMComposeWin::slotEditorTextChanged);
     mComposerBase->setEditor(composerEditorNg);

src/identity/identitydialog.cpp

@@ -975,7 +975,7 @@ void IdentityDialog::unregisterSpecialCollection(qint64 colId)
     // resource set as well.
     auto fetch = new Akonadi::CollectionFetchJob(Akonadi::Collection(colId), Akonadi::CollectionFetchJob::Base, this);
     connect(fetch, &Akonadi::CollectionFetchJob::collectionsReceived,
-            this, [this](const Akonadi::Collection::List &cols) {
+            this, [](const Akonadi::Collection::List &cols) {
             if (cols.count() != 1) {
                 return;
             }

src/kmreaderwin.cpp

@@ -290,13 +290,13 @@ QString KMReaderWin::newFeaturesMD5()
 void KMReaderWin::displaySplashPage(const QString &templateName, const QVariantHash &_data)
 {
     QVariantHash data = _data;
-    if (!data.contains(QLatin1String("icon"))) {
+    if (!data.contains(QStringLiteral("icon"))) {
         data[QStringLiteral("icon")] = QStringLiteral("kmail");
     }
-    if (!data.contains(QLatin1String("name"))) {
+    if (!data.contains(QStringLiteral("name"))) {
         data[QStringLiteral("name")] = i18n("KMail");
     }
-    if (!data.contains(QLatin1String("subtitle"))) {
+    if (!data.contains(QStringLiteral("subtitle"))) {
         data[QStringLiteral("subtitle")] = i18n("The KDE Mail Client");
     }
 

src/kontactplugin/summary/kcmkontactsummary.cpp

@@ -76,6 +76,7 @@ public:
     }
 
 private:
+    Q_DISABLE_COPY(PluginItem)
     KPluginInfo mInfo;
 };
 

src/kontactplugin/summary/summaryview_part.cpp

@@ -435,7 +435,7 @@ void SummaryViewPart::slotConfigure()
     dlg->setModal(true);
 
     QStringList modules = configModules();
-    modules.prepend(QLatin1String("kcmkontactsummary.desktop"));
+    modules.prepend(QStringLiteral("kcmkontactsummary.desktop"));
     connect(dlg.data(), QOverload<>::of(&KCMultiDialog::configCommitted),
             this, &SummaryViewPart::updateWidgets);
 

src/searchdialog/incompleteindexdialog.cpp

@@ -203,7 +203,7 @@ QList<qlonglong> IncompleteIndexDialog::collectionsToReindex() const
 
 void IncompleteIndexDialog::waitForIndexer()
 {
-    mIndexer = new QDBusInterface(PimCommon::MailUtil::indexerServiceName(), QLatin1String("/"),
+    mIndexer = new QDBusInterface(PimCommon::MailUtil::indexerServiceName(), QStringLiteral("/"),
                                   QStringLiteral("org.freedesktop.Akonadi.Indexer"),
                                   QDBusConnection::sessionBus(), this);
 

src/sieveimapinterface/kmailsieveimapinstanceinterface.h

@@ -29,6 +29,8 @@ public:
     ~KMailSieveImapInstanceInterface() override = default;
 
     QVector<KSieveUi::SieveImapInstance> sieveImapInstances() override;
+private:
+    Q_DISABLE_COPY(KMailSieveImapInstanceInterface)
 };
 
 #endif // KMAILSIEVEIMAPINSTANCEINTERFACE_H