Trying to validate SMTP input fields when the user is adding

a sendmail transport is a really bad idea and causes KMail
to crash.

Shame on me

Conclusion is that the nr of new KMail users using sendmail
transports must equal 0 in trunk, since none of them would be able to
add a transport of type sendmail and no bugs has been logged.

svn path=/trunk/KDE/kdepim/; revision=425933
wilder-work
Matt Douhan 21 years ago
parent cc449a1c03
commit a6065b70b3
  1. 8
      kmtransport.cpp

@ -778,7 +778,6 @@ void KMTransportDialog::slotSmtpCapabilities( const QStringList & capaNormal,
delete mServerTest;
mServerTest = 0;
}
bool KMTransportDialog::sanityCheckSmtpInput()
{
// FIXME: add additional checks for all fields that needs it
@ -794,9 +793,12 @@ bool KMTransportDialog::sanityCheckSmtpInput()
void KMTransportDialog::slotOk()
{
if( !sanityCheckSmtpInput() ) {
return;
if (mTransportInfo->type != "sendmail") {
if( !sanityCheckSmtpInput() ) {
return;
}
}
saveSettings();
accept();
}

Loading…
Cancel
Save