Add #warning about broken shortcuts.

This needs better support from KKeySequenceWidget.

svn path=/trunk/KDE/kdepim/; revision=696960
wilder-work
Thomas McGuire 19 years ago
parent b3c5f5fff7
commit 8c37f8e109
  1. 8
      configuredialog.cpp
  2. 9
      customtemplates.cpp
  3. 8
      foldershortcutdialog.cpp
  4. 8
      kmfilterdlg.cpp

@ -2497,6 +2497,14 @@ void AppearancePage::MessageTagTab::slotEmitChangeCheck()
slotEmitChanged();
}
#ifdef __GNUC__
#warning FIXME: Shortcut Handling broken
// Shortcut handling is broken for custom templates, tags and filters.
// The code assumes that the key sequence widget's shortcut is NOT already
// set when this function is called, which is no longer the case with the
// new KKeySequenceWidget.
// This needs better support from KKeySequenceWidget. --tmcguire
#endif
void AppearancePage::MessageTagTab::slotShortcutCaptured( const QKeySequence &sc )
{
QKeySequence mySc(sc);

@ -342,7 +342,14 @@ void CustomTemplates::slotTypeActivated( int index )
//btw, all the problems with KShortcut that you have are because KShortcut is a subclass of
//QList<QKeySequence>. I have contacted Simon Hausmann who did this. I reworked the API, but
//the list thing wasn't me. Really :) -- ahartmetz
#ifdef __GNUC__
#warning FIXME: Shortcut Handling broken
// Shortcut handling is broken for custom templates, tags and filters.
// The code assumes that the key sequence widget's shortcut is NOT already
// set when this function is called, which is no longer the case with the
// new KKeySequenceWidget.
// This needs better support from KKeySequenceWidget. --tmcguire
#endif
void CustomTemplates::slotShortcutCaptured( const QKeySequence &shortcut )
{
bool assign = true;

@ -88,6 +88,14 @@ FolderShortcutDialog::~FolderShortcutDialog()
{
}
#ifdef __GNUC__
#warning FIXME: Shortcut Handling broken
// Shortcut handling is broken for custom templates, tags and filters.
// The code assumes that the key sequence widget's shortcut is NOT already
// set when this function is called, which is no longer the case with the
// new KKeySequenceWidget.
// This needs better support from KKeySequenceWidget. --tmcguire
#endif
void FolderShortcutDialog::slotCapturedShortcut( const QKeySequence& sc )
{
if ( sc.isEmpty() ) {

@ -526,6 +526,14 @@ void KMFilterDlg::slotConfigureShortcutButtonToggled( bool aChecked )
}
}
#ifdef __GNUC__
#warning FIXME: Shortcut Handling broken
// Shortcut handling is broken for custom templates, tags and filters.
// The code assumes that the key sequence widget's shortcut is NOT already
// set when this function is called, which is no longer the case with the
// new KKeySequenceWidget.
// This needs better support from KKeySequenceWidget. --tmcguire
#endif
void KMFilterDlg::slotCapturedShortcutChanged( const QKeySequence& ks )
{
if ( !ks.isEmpty() && !( kmkernel->getKMMainWidget()->shortcutIsValid( ks ) ) ) {

Loading…
Cancel
Save