From 6cae2b068686d39b1336eca6c27e17eb850875fa Mon Sep 17 00:00:00 2001
From: Montel Laurent <montel@kde.org>
Date: Tue, 27 Jan 2015 09:01:42 +0100
Subject: [PATCH] Add more unittest

---
 .../potentialphishingemailjobtest.cpp         | 19 +++++++++++++++++++
 .../autotests/potentialphishingemailjobtest.h |  2 ++
 .../potentialphishingemailjob.cpp             |  5 +++--
 3 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/editor/potentialphishingemail/autotests/potentialphishingemailjobtest.cpp b/editor/potentialphishingemail/autotests/potentialphishingemailjobtest.cpp
index a3eb97cb0..47746c36a 100644
--- a/editor/potentialphishingemail/autotests/potentialphishingemailjobtest.cpp
+++ b/editor/potentialphishingemail/autotests/potentialphishingemailjobtest.cpp
@@ -22,6 +22,7 @@
 #include "../potentialphishingemailjob.h"
 #include <qtest_kde.h>
 #include <QStringList>
+#include <QSignalSpy>
 
 PotentialPhishingEmailJobTest::PotentialPhishingEmailJobTest(QObject *parent)
     : QObject(parent)
@@ -60,4 +61,22 @@ void PotentialPhishingEmailJobTest::shouldReturnPotentialPhishingEmails()
 
 }
 
+void PotentialPhishingEmailJobTest::shouldEmitSignal()
+{
+    PotentialPhishingEmailJob *job = new PotentialPhishingEmailJob;
+    QSignalSpy spy(job, SIGNAL(potentialPhisingEmailsFound(QStringList)));
+    job->setEmails((QStringList() << QLatin1String("\"bla@kde.org\" <foo@kde.org>")));
+    job->start();
+    QCOMPARE(spy.count(), 1);
+}
+
+void PotentialPhishingEmailJobTest::shouldNotEmitSignalWhenPotentialPhishingNotFound()
+{
+    PotentialPhishingEmailJob *job = new PotentialPhishingEmailJob;
+    QSignalSpy spy(job, SIGNAL(potentialPhisingEmailsFound(QStringList)));
+    job->setEmails((QStringList() << QLatin1String("<foo@kde.org>")));
+    job->start();
+    QCOMPARE(spy.count(), 0);
+}
+
 QTEST_KDEMAIN(PotentialPhishingEmailJobTest, NoGUI)
diff --git a/editor/potentialphishingemail/autotests/potentialphishingemailjobtest.h b/editor/potentialphishingemail/autotests/potentialphishingemailjobtest.h
index ade03249d..c44bdac1b 100644
--- a/editor/potentialphishingemail/autotests/potentialphishingemailjobtest.h
+++ b/editor/potentialphishingemail/autotests/potentialphishingemailjobtest.h
@@ -34,6 +34,8 @@ private Q_SLOTS:
     void shouldNotStartIfNoEmails();
     void shouldReturnPotentialPhishingEmails_data();
     void shouldReturnPotentialPhishingEmails();
+    void shouldEmitSignal();
+    void shouldNotEmitSignalWhenPotentialPhishingNotFound();
 };
 
 #endif // POTENTIALPHISHINGEMAILJOBTEST_H
diff --git a/editor/potentialphishingemail/potentialphishingemailjob.cpp b/editor/potentialphishingemail/potentialphishingemailjob.cpp
index bcbbdd4ec..8ee05b42d 100644
--- a/editor/potentialphishingemail/potentialphishingemailjob.cpp
+++ b/editor/potentialphishingemail/potentialphishingemailjob.cpp
@@ -59,8 +59,9 @@ bool PotentialPhishingEmailJob::start()
             }
         }
     }
-
-    Q_EMIT potentialPhisingEmailsFound(mPotentialPhisingEmails);
+    if (!mPotentialPhisingEmails.isEmpty()) {
+        Q_EMIT potentialPhisingEmailsFound(mPotentialPhisingEmails);
+    }
     deleteLater();
     return true;
 }