diff --git a/kmmainwidget.cpp b/kmmainwidget.cpp index 7ff02bca2..0430e564c 100644 --- a/kmmainwidget.cpp +++ b/kmmainwidget.cpp @@ -1590,7 +1590,6 @@ void KMMainWidget::slotDelayedRemoveFolder(KJob *job) const Akonadi::Collection::Id id = fetchJob->property("collectionId").toLongLong(); Akonadi::Collection col = MailCommon::Util::updatedCollection(CommonKernel->collectionFromId(id)); - QDir dir; QString str; QString title; QString buttonLabel; diff --git a/manageshowcollectionproperties.cpp b/manageshowcollectionproperties.cpp index 707abece7..9ed4076d1 100644 --- a/manageshowcollectionproperties.cpp +++ b/manageshowcollectionproperties.cpp @@ -36,6 +36,16 @@ ManageShowCollectionProperties::ManageShowCollectionProperties(KMMainWidget *mai : QObject(parent), mMainWidget(mainWidget) { + mPages = QStringList() << QLatin1String("MailCommon::CollectionGeneralPage") + << QLatin1String("KMail::CollectionViewPage") + << QLatin1String("Akonadi::CachePolicyPage") + << QLatin1String("KMail::CollectionTemplatesPage") + << QLatin1String("MailCommon::CollectionExpiryPage") + << QLatin1String("PimCommon::CollectionAclPage") + << QLatin1String("KMail::CollectionMailingListPage") + << QLatin1String("KMail::CollectionQuotaPage") + << QLatin1String("KMail::CollectionShortcutPage") + << QLatin1String("KMail::CollectionMaintenancePage"); } @@ -69,11 +79,12 @@ void ManageShowCollectionProperties::showCollectionProperties(const QString &pag if (!mMainWidget->currentFolder()) { return; } - - if (mHashDialogBox.contains(mMainWidget->currentFolder()->collection().id())) { - if (mHashDialogBox.value(mMainWidget->currentFolder()->collection().id())) { - mHashDialogBox.value(mMainWidget->currentFolder()->collection().id())->activateWindow(); - mHashDialogBox.value(mMainWidget->currentFolder()->collection().id())->raise(); + Akonadi::Collection::Id id = mMainWidget->currentFolder()->collection().id(); + if (mHashDialogBox.contains(id)) { + QPointer dlg = mHashDialogBox.value(id); + if (dlg) { + dlg->activateWindow(); + dlg->raise(); return; } } @@ -94,7 +105,7 @@ void ManageShowCollectionProperties::showCollectionProperties(const QString &pag Akonadi::CollectionAttributesSynchronizationJob *sync = new Akonadi::CollectionAttributesSynchronizationJob(mMainWidget->currentFolder()->collection()); - sync->setProperty("collectionId", mMainWidget->currentFolder()->collection().id()); + sync->setProperty("collectionId", id); sync->setProperty("pageToShow", pageToShow); // note for dialog later sync->setProperty("progressItem", QVariant::fromValue(progressItem)); connect(sync, SIGNAL(result(KJob*)), @@ -180,18 +191,7 @@ void ManageShowCollectionProperties::slotCollectionPropertiesFinished(KJob *job) const Akonadi::Collection collection = fetch->collections().first(); - const QStringList pages = QStringList() << QLatin1String("MailCommon::CollectionGeneralPage") - << QLatin1String("KMail::CollectionViewPage") - << QLatin1String("Akonadi::CachePolicyPage") - << QLatin1String("KMail::CollectionTemplatesPage") - << QLatin1String("MailCommon::CollectionExpiryPage") - << QLatin1String("PimCommon::CollectionAclPage") - << QLatin1String("KMail::CollectionMailingListPage") - << QLatin1String("KMail::CollectionQuotaPage") - << QLatin1String("KMail::CollectionShortcutPage") - << QLatin1String("KMail::CollectionMaintenancePage"); - - QPointer dlg = new Akonadi::CollectionPropertiesDialog(collection, pages, mMainWidget); + QPointer dlg = new Akonadi::CollectionPropertiesDialog(collection, mPages, mMainWidget); dlg->setWindowTitle(i18nc("@title:window", "Properties of Folder %1", collection.name())); const QString pageToShow = fetch->property("pageToShow").toString(); diff --git a/manageshowcollectionproperties.h b/manageshowcollectionproperties.h index b933cd709..ec924d020 100644 --- a/manageshowcollectionproperties.h +++ b/manageshowcollectionproperties.h @@ -54,6 +54,7 @@ private: private: QHash > mHashDialogBox; + QStringList mPages; KMMainWidget *mMainWidget; };