From 67da93b67154269a40bcd236f55df31d7dd0d06a Mon Sep 17 00:00:00 2001
From: Montel Laurent <montel@kde.org>
Date: Tue, 10 Mar 2015 08:35:50 +0100
Subject: [PATCH] Add unittest

---
 mailmerge/tests/CMakeLists.txt                |  1 +
 .../tests/selectattachmentdialogtest.cpp      | 44 +++++++++++++++++++
 mailmerge/tests/selectattachmentdialogtest.h  | 33 ++++++++++++++
 mailmerge/widgets/selectattachmentdialog.cpp  |  4 +-
 4 files changed, 81 insertions(+), 1 deletion(-)
 create mode 100644 mailmerge/tests/selectattachmentdialogtest.cpp
 create mode 100644 mailmerge/tests/selectattachmentdialogtest.h

diff --git a/mailmerge/tests/CMakeLists.txt b/mailmerge/tests/CMakeLists.txt
index be2b1363f..614a70a8b 100644
--- a/mailmerge/tests/CMakeLists.txt
+++ b/mailmerge/tests/CMakeLists.txt
@@ -40,4 +40,5 @@ endmacro()
 kmail_mailmerge(addressbookwidgettest.cpp "../widgets/selectattachmentdialog.cpp")
 kmail_mailmerge(csvwidgettest.cpp "../widgets/csvwidget.cpp")
 kmail_mailmerge(mailmergedialogtest.cpp "../mailmergedialog.cpp")
+kmail_mailmerge(selectattachmentdialogtest.cpp "../widgets/selectattachmentdialog.cpp")
 
diff --git a/mailmerge/tests/selectattachmentdialogtest.cpp b/mailmerge/tests/selectattachmentdialogtest.cpp
new file mode 100644
index 000000000..54d387c60
--- /dev/null
+++ b/mailmerge/tests/selectattachmentdialogtest.cpp
@@ -0,0 +1,44 @@
+/*
+  Copyright (c) 2015 Montel Laurent <montel@kde.org>
+
+  This program is free software; you can redistribute it and/or modify it
+  under the terms of the GNU General Public License, version 2, as
+  published by the Free Software Foundation.
+
+  This program is distributed in the hope that it will be useful, but
+  WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+  General Public License for more details.
+
+  You should have received a copy of the GNU General Public License along
+  with this program; if not, write to the Free Software Foundation, Inc.,
+  51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+*/
+
+
+#include "selectattachmentdialogtest.h"
+#include "../widgets/selectattachmentdialog.h"
+#include <KUrlRequester>
+#include <QLabel>
+#include <qtest_kde.h>
+SelectAttachmentDialogTest::SelectAttachmentDialogTest(QObject *parent)
+    : QObject(parent)
+{
+
+}
+
+SelectAttachmentDialogTest::~SelectAttachmentDialogTest()
+{
+
+}
+
+void SelectAttachmentDialogTest::shouldHaveDefaultValue()
+{
+    MailMerge::SelectAttachmentDialog dlg;
+    QLabel *lab = qFindChild<QLabel *>(&dlg, QLatin1String("selectattachment_label"));
+    QVERIFY(lab);
+    KUrlRequester *urlRequester = qFindChild<KUrlRequester *>(&dlg, QLatin1String("urlrequester"));
+    QVERIFY(urlRequester);
+}
+
+QTEST_KDEMAIN(SelectAttachmentDialogTest, GUI)
diff --git a/mailmerge/tests/selectattachmentdialogtest.h b/mailmerge/tests/selectattachmentdialogtest.h
new file mode 100644
index 000000000..8d75934f5
--- /dev/null
+++ b/mailmerge/tests/selectattachmentdialogtest.h
@@ -0,0 +1,33 @@
+/*
+  Copyright (c) 2015 Montel Laurent <montel@kde.org>
+
+  This program is free software; you can redistribute it and/or modify it
+  under the terms of the GNU General Public License, version 2, as
+  published by the Free Software Foundation.
+
+  This program is distributed in the hope that it will be useful, but
+  WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+  General Public License for more details.
+
+  You should have received a copy of the GNU General Public License along
+  with this program; if not, write to the Free Software Foundation, Inc.,
+  51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+*/
+
+#ifndef SELECTATTACHMENTDIALOGTEST_H
+#define SELECTATTACHMENTDIALOGTEST_H
+
+#include <QObject>
+
+class SelectAttachmentDialogTest : public QObject
+{
+    Q_OBJECT
+public:
+    explicit SelectAttachmentDialogTest(QObject *parent = 0);
+    ~SelectAttachmentDialogTest();
+private Q_SLOTS:
+    void shouldHaveDefaultValue();
+};
+
+#endif // SELECTATTACHMENTDIALOGTEST_H
diff --git a/mailmerge/widgets/selectattachmentdialog.cpp b/mailmerge/widgets/selectattachmentdialog.cpp
index aff12a803..3cced1b43 100644
--- a/mailmerge/widgets/selectattachmentdialog.cpp
+++ b/mailmerge/widgets/selectattachmentdialog.cpp
@@ -30,12 +30,14 @@ SelectAttachmentDialog::SelectAttachmentDialog(QWidget *parent)
     setCaption(i18n("Attachment"));
     setButtons(Ok|Cancel);
 
-    QWidget *mainWidget = new QWidget;
+    QWidget *mainWidget = new QWidget(this);
     QVBoxLayout *vbox = new QVBoxLayout;
     mainWidget->setLayout(vbox);
     QLabel *lab = new QLabel(i18n("Select attachment:"));
+    lab->setObjectName(QLatin1String("selectattachment_label"));
     vbox->addWidget(lab);
     mUrlRequester = new KUrlRequester;
+    mUrlRequester->setObjectName(QLatin1String("urlrequester"));
     mUrlRequester->setMode(KFile::LocalOnly|KFile::ExistingOnly);
     vbox->addWidget(mUrlRequester);
     setMainWidget(mainWidget);