From 704fdba37be1e690e7a91b443304c22b47b2bfb5 Mon Sep 17 00:00:00 2001 From: Milian Wolff Date: Thu, 30 Apr 2015 15:44:05 +0200 Subject: [PATCH] Do not query the row count repeatedly. The compiler is not smart enough to hoist this call out of the loop. But we can expect that the row count will not change during a call to filterAcceptsRow. --- src/krecursivefilterproxymodel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/krecursivefilterproxymodel.cpp b/src/krecursivefilterproxymodel.cpp index 7e72e10..8219ef4 100644 --- a/src/krecursivefilterproxymodel.cpp +++ b/src/krecursivefilterproxymodel.cpp @@ -301,7 +301,7 @@ bool KRecursiveFilterProxyModel::filterAcceptsRow(int sourceRow, const QModelInd Q_ASSERT(source_index.isValid()); bool accepted = false; - for (int row = 0; row < sourceModel()->rowCount(source_index); ++row) { + for (int row = 0, rows = sourceModel()->rowCount(source_index); row < rows; ++row) { if (filterAcceptsRow(row, source_index)) { accepted = true; break;