From bfaec73f91c4fe9de2f58891ebdf53c6ef3fb8ea Mon Sep 17 00:00:00 2001 From: Michael Pyne Date: Sun, 15 May 2005 05:54:46 +0000 Subject: [PATCH] And in this instance, Perl did do what I meant, except when kdesvn-build was running on Thiago's system. So, change 'unless scalar @dirs' to the wordier 'if scalar @dirs == 0', and change the while loop into a for loop. Actually this change restores this part of the code to the way it was before the apidox patch, where I was experimenting with do { ... } while and gave it up when Perl told me that it wasn't really a loop, and I didn't undo my changes *exactly*, which broke kdesvn-build elsewhere (but not here for some reason). svn path=/trunk/KDE/kdesdk/scripts/kdesvn-build; revision=414019 --- kdesvn-build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kdesvn-build b/kdesvn-build index ffc16ff..c900bca 100755 --- a/kdesvn-build +++ b/kdesvn-build @@ -654,8 +654,8 @@ sub safe_make (@) print "\t$description...\n"; } - push (@dirs, "") unless scalar @dirs; - while (my $subdir = shift @dirs) + push (@dirs, "") if scalar @dirs == 0; + for my $subdir (@dirs) { # Some subdirectories shouldn't have make run within them. next unless is_subdir_buildable($module, $subdir);