From 6c584c6a84fa5537a9d3b5f0180fbb0a84470f29 Mon Sep 17 00:00:00 2001 From: Michael Pyne Date: Sat, 23 Sep 2017 20:58:44 -0400 Subject: [PATCH] Avoid referencing source dir after it may be removed. This "last-build-rev" persistent option is probably more appropriate for Module.pm anyways, since there is already a similar "last-install-rev" check in there. --- modules/ksb/Application.pm | 1 - modules/ksb/Module.pm | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/ksb/Application.pm b/modules/ksb/Application.pm index af60c77..4a57578 100644 --- a/modules/ksb/Application.pm +++ b/modules/ksb/Application.pm @@ -1383,7 +1383,6 @@ sub _buildSingleModule $$startTimeRef = time; if ($module->build()) { - $module->setPersistentOption('last-build-rev', $module->currentScmRevision()); $fail_count = 0; } else { diff --git a/modules/ksb/Module.pm b/modules/ksb/Module.pm index d6aa249..c3ccd81 100644 --- a/modules/ksb/Module.pm +++ b/modules/ksb/Module.pm @@ -425,6 +425,8 @@ sub build return 0; } + $self->setPersistentOption('last-build-rev', $self->currentScmRevision()); + # TODO: This should be a simple phase to run. if ($self->getOption('run-tests')) {