From aa4c85ce989d28e9c3d51cb1e8d5259bd6b6d079 Mon Sep 17 00:00:00 2001 From: Michael Pyne Date: Mon, 29 Oct 2012 13:44:12 -0400 Subject: [PATCH 1/2] http: Use proper HTTP syntax for user agent string. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As noted by Nicolás Alvarez. --- kdesrc-build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kdesrc-build b/kdesrc-build index 8a1555c..ec90046 100755 --- a/kdesrc-build +++ b/kdesrc-build @@ -863,7 +863,7 @@ EOF # Trailing space adds the appropriate LWP info since the resolver is not # my custom coding anymore. - $ua->agent("kdesrc-build $versionNum "); + $ua->agent("kdesrc-build/$versionNum "); if ($proxy) { whisper ("Using proxy $proxy for FTP, HTTP downloads"); From 4b419b4aec1c970af843acf00c5070afa90e067f Mon Sep 17 00:00:00 2001 From: Michael Pyne Date: Sat, 3 Nov 2012 20:36:17 -0400 Subject: [PATCH 2/2] Fix git fetching so that it actually downloads. My reading of the git-fetch manpage left me with the idea that adding the '-t' (for --tag) option would additionally cause all tags to be fetched from the given repository. The manpage doesn't actually say this though, and git apparently instead downloads just the tags (and needed objects), so this change has caused master branches around the kdesrc-build world to stop updating. :( The idea behind this had been to ensure that if the 'tag' option were used in kdesrc-build that git would have the most up-to-date list of tags available, but I guess we'll just have to go back to crossing-our-fingers and hoping git already knows about the tag for now. --- kdesrc-build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kdesrc-build b/kdesrc-build index ec90046..b55657b 100755 --- a/kdesrc-build +++ b/kdesrc-build @@ -2812,7 +2812,7 @@ EOF # Download updated objects. This also updates remote heads so do this # before we start comparing branches and such. info ("Downloading updates for g[$module]"); - if (0 != log_command($module, 'git-fetch', ['git', 'fetch', '-t', $remoteName])) { + if (0 != log_command($module, 'git-fetch', ['git', 'fetch', $remoteName])) { die "Unable to perform git fetch for $remoteName, which should be $cur_repo"; }