From 0e7abfd3a799a48366cc6ef6fc63bc7c3636ded2 Mon Sep 17 00:00:00 2001 From: Michael Pyne Date: Mon, 17 Mar 2014 00:12:40 -0400 Subject: [PATCH] Give better error message if guessing a module name guesses too many. What we really want is for this to actually allow many modules I suppose, but for now you'll need to use the config file with module-sets to get the same effect. --- modules/ksb/Application.pm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/modules/ksb/Application.pm b/modules/ksb/Application.pm index ab4f243..5e06ada 100644 --- a/modules/ksb/Application.pm +++ b/modules/ksb/Application.pm @@ -492,10 +492,15 @@ sub _resolveSelectorsIntoModules } else { my $set = ksb::ModuleSet::KDEProjects->new($ctx, "guessed_from_cmdline"); + my $searchItem = $guessedModule->name(); $set->setModulesToFind($guessedModule->name()); my @results = _expandModuleSets($ctx, $modNewRef, $set); - $guessedModule = shift @results; + $guessedModule = first { "$_" eq "$searchItem" } @results; + if (!$guessedModule) { + # This is a misfeature, I know. This should support whole sets too. + croak_runtime ("$searchItem doesn't match a single module, it matches many."); + } } } }