From 0cf9e1bb0384b181f0191850cf2b3dfc9ff53072 Mon Sep 17 00:00:00 2001 From: Michael Pyne Date: Sat, 15 Feb 2014 20:59:35 -0500 Subject: [PATCH] git: Fix order-of-operations error with exception handling. BUG:331155 FIXED-IN:1.16 --- modules/ksb/Updater/Git.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ksb/Updater/Git.pm b/modules/ksb/Updater/Git.pm index a198fd5..2abd421 100644 --- a/modules/ksb/Updater/Git.pm +++ b/modules/ksb/Updater/Git.pm @@ -93,7 +93,7 @@ sub clone my $result = eval { $self->installGitSnapshot() }; - if (my $e = had_an_exception() || !$result) { + if ((my $e = had_an_exception()) || !$result) { warning($e->message()) if $e; if (0 != log_command($module, 'git-clone', ['git', 'clone', @args])) { croak_runtime("Failed to make initial clone of $module");