This reverts commit b9fb89a31c.
This plugin was removed due to the underlying library being deprecated
and removed from some distributions. However:
* the gnome-keyring library is still available in Fedora Rawhide,
* the plugin is optional, and the availability of the library is
automatically detected, so having the plugin available will not hurt
users who do not have access to the underlying library, as Falkon will
just be built without the optional plugin then,
* distribution packagers can put the plugin into an optional subpackage
(which I have always done in Fedora to begin with),
* a replacement plugin using libsecret (the upstream replacement for
libgnome-keyring) is still not available, and
* perhaps most importantly: not having the plugin available leaves users
with no easy way to access their existing saved passwords (due to no
libsecret plugin being available), which is IMHO not acceptable.
Required for cmake to search for QtWebEngine in a seperate prefix, for example when building flatpaks, where Qt is in /usr but QtWebEngine is in /app since org.kde.Sdk 5.13.
Use the generic redirect commits.kde.org insteaf of:
- projects.kde.org, which has been obsolete for a while;
- cgit.kde.org, which is not a future-proof URL anyway.
Summary:
Use the new ShareUrl support from Purpose to share pages. ATM only sending the page via KDE Connect and Email is supported, but more can be added easily by extending Purpose.
{F6449845}
Depends on D17285
Bug: 393543
Test Plan: Send page to phone via KDE Connect
Reviewers: #falkon, drosca
Reviewed By: #falkon, drosca
Subscribers: drosca, falkon
Tags: #falkon
Differential Revision: https://phabricator.kde.org/D17286
QtWebEngine can be newer than the rest of Qt (e.g., on Fedora 27).
This fixes the version check in WebView::savePageAs to use a macro
defined in config.h.cmake based on the version of QtWebEngineWidgets
rather than relying on QT_VERSION, which is the version of QtCore.
Reviewed By: drosca
Differential Revision: https://phabricator.kde.org/D12833
CCBUG: 391300
When there are mixed gettext and qt translations, they get downloaded
to separate po and poqm folders, so it is no longer needed to handle
it manually.
Summary:
Extract the strings: one main catalog and a catalog for each plugin.
Also use the ECM macro to install the translations.
Ref T6858
Reviewers: #falkon, drosca
Reviewed By: #falkon, drosca
Subscribers: drosca
Tags: #falkon
Maniphest Tasks: T6858
Differential Revision: https://phabricator.kde.org/D8049
Summary:
The current cmake files search for gnome keyring unconditionally, which
on source-based distros would lead to a hard dependency on the package.
Hence, it would be a good idea to introduce an option to deactivate this
if necessary.
Reviewers: #falkon, drosca
Reviewed By: #falkon, drosca
Subscribers: heikobecker, drosca
Differential Revision: https://phabricator.kde.org/D8038
Adriaan de Groot
Kevin Kofler
Jonah Brüchert
Luigi Toscano
David Rosca
Nicolas Fella
Anmol Gautam
Tobias C. Berner
Jonathan Riddell
Razi Alavizadeh
Heiko Becker