diff --git a/src/lib/plugins/speeddial.cpp b/src/lib/plugins/speeddial.cpp
index a3777bedf..bc400dcdd 100644
--- a/src/lib/plugins/speeddial.cpp
+++ b/src/lib/plugins/speeddial.cpp
@@ -82,7 +82,7 @@ void SpeedDial::saveSettings()
{
ENSURE_LOADED;
- if (m_webPages.isEmpty()) {
+ if (m_pages.isEmpty()) {
return;
}
@@ -103,7 +103,7 @@ SpeedDial::Page SpeedDial::pageForUrl(const QUrl &url)
const QString urlString = url.toString();
- foreach (const Page &page, m_webPages) {
+ foreach (const Page &page, m_pages) {
if (page.url == urlString) {
return page;
}
@@ -116,18 +116,11 @@ QUrl SpeedDial::urlForShortcut(int key)
{
ENSURE_LOADED;
- if (key < 0 || m_webPages.count() <= key) {
+ if (key < 0 || m_pages.count() <= key) {
return QUrl();
}
- return QUrl::fromEncoded(m_webPages.at(key).url.toUtf8());
-}
-
-void SpeedDial::addWebPage(QWebEnginePage *page)
-{
- if (!m_pages.contains(page)) {
- m_pages.append(page);
- }
+ return QUrl::fromEncoded(m_pages.at(key).url.toUtf8());
}
void SpeedDial::addPage(const QUrl &url, const QString &title)
@@ -142,13 +135,9 @@ void SpeedDial::addPage(const QUrl &url, const QString &title)
page.title = escapeTitle(title);
page.url = escapeUrl(url.toString());
- m_webPages.append(page);
+ m_pages.append(page);
m_regenerateScript = true;
- foreach (QWebEnginePage *page, pages()) {
- page->triggerAction(QWebEnginePage::Reload);
- }
-
emit pagesChanged();
}
@@ -161,13 +150,9 @@ void SpeedDial::removePage(const Page &page)
}
removeImageForUrl(page.url);
- m_webPages.removeAll(page);
+ m_pages.removeAll(page);
m_regenerateScript = true;
- foreach (QWebEnginePage *page, pages()) {
- page->triggerAction(QWebEnginePage::Reload);
- }
-
emit pagesChanged();
}
@@ -217,11 +202,12 @@ QString SpeedDial::initialScript()
m_regenerateScript = false;
m_initialScript.clear();
- foreach (const Page &page, m_webPages) {
+ foreach (const Page &page, m_pages) {
QString imgSource = m_thumbnailsDir + QCryptographicHash::hash(page.url.toUtf8(), QCryptographicHash::Md4).toHex() + ".png";
if (!QFile(imgSource).exists()) {
- imgSource = "qrc:html/loading.gif";
+ //imgSource = "qrc:html/loading.gif";
+ imgSource = "qrc:html/broken-page.png";
if (page.url.isEmpty()) {
imgSource.clear();
@@ -244,7 +230,7 @@ void SpeedDial::changed(const QString &allPages)
}
const QStringList entries = allPages.split(QLatin1String("\";"), QString::SkipEmptyParts);
- m_webPages.clear();
+ m_pages.clear();
foreach (const QString &entry, entries) {
if (entry.isEmpty()) {
@@ -260,7 +246,7 @@ void SpeedDial::changed(const QString &allPages)
page.url = tmp.at(0).mid(5);
page.title = tmp.at(1).mid(7);
- m_webPages.append(page);
+ m_pages.append(page);
}
m_regenerateScript = true;
@@ -388,28 +374,11 @@ QString SpeedDial::escapeUrl(QString url) const
return url;
}
-QList
SpeedDial::pages()
-{
- QList list;
-
- for (int i = 0; i < m_pages.count(); i++) {
- QWebEnginePage *page = m_pages.at(i).data();
- if (!page || page->url().toString() != QLatin1String("qupzilla:speeddial")) {
- m_pages.removeAt(i);
- i--;
- continue;
- }
- list.append(page);
- }
-
- return list;
-}
-
QString SpeedDial::generateAllPages()
{
QString allPages;
- foreach (const Page &page, m_webPages) {
+ foreach (const Page &page, m_pages) {
const QString string = QString("url:\"%1\"|title:\"%2\";").arg(page.url, page.title);
allPages.append(string);
}
diff --git a/src/lib/plugins/speeddial.h b/src/lib/plugins/speeddial.h
index eb7f42481..905aa9b2f 100644
--- a/src/lib/plugins/speeddial.h
+++ b/src/lib/plugins/speeddial.h
@@ -52,7 +52,6 @@ public:
Page pageForUrl(const QUrl &url);
QUrl urlForShortcut(int key);
- void addWebPage(QWebEnginePage *page);
void addPage(const QUrl &url, const QString &title);
void removePage(const Page &page);
@@ -88,7 +87,6 @@ private:
QString escapeTitle(QString string) const;
QString escapeUrl(QString url) const;
- QList pages();
QString generateAllPages();
QString m_initialScript;
@@ -99,8 +97,7 @@ private:
int m_sizeOfSpeedDials;
int m_sdcentered;
- QList > m_pages;
- QList m_webPages;
+ QList m_pages;
AutoSaver* m_autoSaver;
bool m_loaded;
diff --git a/src/lib/tools/scripts.cpp b/src/lib/tools/scripts.cpp
index cc6f55605..26b242a7d 100644
--- a/src/lib/tools/scripts.cpp
+++ b/src/lib/tools/scripts.cpp
@@ -17,6 +17,7 @@
* ============================================================ */
#include "scripts.h"
+#include "qztools.h"
QString Scripts::setCss(const QString &css)
{
@@ -32,3 +33,17 @@ QString Scripts::setCss(const QString &css)
style.replace(QL1S("\n"), QL1S("\\n"));
return source.arg(style);
}
+
+QString Scripts::setupWebChannel()
+{
+ QString source = QL1S("(function() {"
+ "%1"
+ "var channel = new QWebChannel(qt.webChannelTransport, function(channel) {"
+ "window.external = channel.objects.qz_object;"
+ "var event = new Event('qz_external_created');"
+ "document.dispatchEvent(event);"
+ "});"
+ "})()");
+
+ return source.arg(QzTools::readAllFileContents(QSL(":/html/qwebchannel.js")));
+}
diff --git a/src/lib/tools/scripts.h b/src/lib/tools/scripts.h
index f87ce6d22..82389a995 100644
--- a/src/lib/tools/scripts.h
+++ b/src/lib/tools/scripts.h
@@ -27,6 +27,7 @@ class QUPZILLA_EXPORT Scripts
{
public:
static QString setCss(const QString &css);
+ static QString setupWebChannel();
};
#endif // SCRIPTS_H
diff --git a/src/lib/webengine/javascript/externaljsobject.cpp b/src/lib/webengine/javascript/externaljsobject.cpp
index 0000b5c56..ad7dedd94 100644
--- a/src/lib/webengine/javascript/externaljsobject.cpp
+++ b/src/lib/webengine/javascript/externaljsobject.cpp
@@ -23,7 +23,6 @@
ExternalJsObject::ExternalJsObject(QObject* parent)
: QObject(parent)
- , m_onSpeedDial(false)
{
}
@@ -40,14 +39,5 @@ int ExternalJsObject::IsSearchProviderInstalled(const QString &engineURL)
QObject* ExternalJsObject::speedDial() const
{
-#if QTWEBENGINE_DISABLED
- return m_onSpeedDial ? mApp->plugins()->speedDial() : 0;
-#else
- return 0;
-#endif
-}
-
-void ExternalJsObject::setOnSpeedDial(bool on)
-{
- m_onSpeedDial = on;
+ return mApp->plugins()->speedDial();
}
diff --git a/src/lib/webengine/javascript/externaljsobject.h b/src/lib/webengine/javascript/externaljsobject.h
index 3e75f8a21..3c2db0a46 100644
--- a/src/lib/webengine/javascript/externaljsobject.h
+++ b/src/lib/webengine/javascript/externaljsobject.h
@@ -23,7 +23,7 @@
class ExternalJsObject : public QObject
{
Q_OBJECT
- Q_PROPERTY(QObject* speedDial READ speedDial)
+ Q_PROPERTY(QObject* speedDial READ speedDial CONSTANT)
public:
explicit ExternalJsObject(QObject* parent = 0);
@@ -32,13 +32,8 @@ public slots:
void AddSearchProvider(const QString &engineUrl);
int IsSearchProviderInstalled(const QString &engineURL);
- QObject* speedDial() const;
-
-public:
- void setOnSpeedDial(bool on);
-
private:
- bool m_onSpeedDial;
+ QObject* speedDial() const;
};
diff --git a/src/lib/webengine/webpage.cpp b/src/lib/webengine/webpage.cpp
index 6193034d2..e10da9082 100644
--- a/src/lib/webengine/webpage.cpp
+++ b/src/lib/webengine/webpage.cpp
@@ -66,6 +66,9 @@
#include
#include
#include
+#include
+
+#include
QString WebPage::s_lastUploadLocation = QDir::homePath();
QUrl WebPage::s_lastUnsupportedUrl;
@@ -87,38 +90,9 @@ WebPage::WebPage(QObject* parent)
connect(this, &QWebEnginePage::featurePermissionRequested, this, &WebPage::featurePermissionRequested);
connect(this, &QWebEnginePage::windowCloseRequested, this, &WebPage::windowCloseRequested);
-#if QTWEBENGINE_DISABLED
- m_javaScriptEnabled = QWebEngineSettings::globalSettings()->testAttribute(QWebEngineSettings::JavascriptEnabled);
-
- m_networkProxy = new NetworkManagerProxy(this);
- m_networkProxy->setPrimaryNetworkAccessManager(mApp->networkManager());
- m_networkProxy->setPage(this);
- setNetworkAccessManager(m_networkProxy);
-
- setForwardUnsupportedContent(true);
- setPluginFactory(new WebPluginFactory(this));
- history()->setMaximumItemCount(20);
-
- connect(this, SIGNAL(unsupportedContent(QNetworkReply*)), this, SLOT(handleUnsupportedContent(QNetworkReply*)));
- connect(this, SIGNAL(printRequested(QWebFrame*)), this, SLOT(printFrame(QWebFrame*)));
-
- frameCreated(mainFrame());
- connect(this, SIGNAL(frameCreated(QWebFrame*)), this, SLOT(frameCreated(QWebFrame*)));
-
- connect(this, SIGNAL(databaseQuotaExceeded(QWebFrame*,QString)),
- this, SLOT(dbQuotaExceeded(QWebFrame*)));
-
- connect(mainFrame(), SIGNAL(javaScriptWindowObjectCleared()), this, SLOT(addJavaScriptObject()));
-
-#if QTWEBKIT_FROM_2_3
- connect(this, SIGNAL(applicationCacheQuotaExceeded(QWebSecurityOrigin*,quint64,quint64)),
- this, SLOT(appCacheQuotaExceeded(QWebSecurityOrigin*,quint64)));
-#elif QTWEBKIT_FROM_2_2
- connect(this, SIGNAL(applicationCacheQuotaExceeded(QWebSecurityOrigin*,quint64)),
- this, SLOT(appCacheQuotaExceeded(QWebSecurityOrigin*,quint64)));
-#endif
-
-#endif
+ QWebChannel *channel = new QWebChannel(this);
+ channel->registerObject(QSL("qz_object"), new ExternalJsObject(this));
+ setWebChannel(channel);
}
WebPage::~WebPage()
@@ -1091,7 +1065,7 @@ bool WebPage::extension(Extension extension, const ExtensionOption* option, Exte
}
#endif
-bool WebPage::javaScriptPrompt(QUrl securityOrigin, const QString &msg, const QString &defaultValue, QString* result)
+bool WebPage::javaScriptPrompt(const QUrl &securityOrigin, const QString &msg, const QString &defaultValue, QString* result)
{
#ifndef NONBLOCK_JS_DIALOGS
return QWebEnginePage::javaScriptPrompt(securityOrigin, msg, defaultValue, result);
@@ -1135,7 +1109,7 @@ bool WebPage::javaScriptPrompt(QUrl securityOrigin, const QString &msg, const QS
#endif
}
-bool WebPage::javaScriptConfirm(QUrl securityOrigin, const QString &msg)
+bool WebPage::javaScriptConfirm(const QUrl &securityOrigin, const QString &msg)
{
#ifndef NONBLOCK_JS_DIALOGS
return QWebEnginePage::javaScriptConfirm(securityOrigin, msg);
@@ -1175,7 +1149,7 @@ bool WebPage::javaScriptConfirm(QUrl securityOrigin, const QString &msg)
#endif
}
-void WebPage::javaScriptAlert(QUrl securityOrigin, const QString &msg)
+void WebPage::javaScriptAlert(const QUrl &securityOrigin, const QString &msg)
{
Q_UNUSED(securityOrigin)
@@ -1228,6 +1202,28 @@ void WebPage::javaScriptAlert(QUrl securityOrigin, const QString &msg)
#endif
}
+void WebPage::javaScriptConsoleMessage(QWebEnginePage::JavaScriptConsoleMessageLevel level, const QString &message, int lineNumber, const QString &sourceID)
+{
+ switch (level) {
+ case InfoMessageLevel:
+ std::cout << "I";
+ break;
+
+ case WarningMessageLevel:
+ std::cout << "W";
+ break;
+
+ case ErrorMessageLevel:
+ std::cout << "E";
+ break;
+
+ default:
+ break;
+ }
+
+ std::cout << " " << lineNumber << ": " << message.toStdString() << " (" << sourceID.toStdString() << ")" << std::endl;
+}
+
void WebPage::setJavaScriptEnabled(bool enabled)
{
#if QTWEBENGINE_DISABLED
diff --git a/src/lib/webengine/webpage.h b/src/lib/webengine/webpage.h
index cfa6345c8..76abd614c 100644
--- a/src/lib/webengine/webpage.h
+++ b/src/lib/webengine/webpage.h
@@ -57,9 +57,10 @@ public:
void setSSLCertificate(const QSslCertificate &cert);
QSslCertificate sslCertificate();
- bool javaScriptPrompt(QUrl securityOrigin, const QString &msg, const QString &defaultValue, QString* result);
- bool javaScriptConfirm(QUrl securityOrigin, const QString &msg);
- void javaScriptAlert(QUrl securityOrigin, const QString &msg);
+ bool javaScriptPrompt(const QUrl &securityOrigin, const QString &msg, const QString &defaultValue, QString* result) Q_DECL_OVERRIDE;
+ bool javaScriptConfirm(const QUrl &securityOrigin, const QString &msg) Q_DECL_OVERRIDE;
+ void javaScriptAlert(const QUrl &securityOrigin, const QString &msg) Q_DECL_OVERRIDE;
+ void javaScriptConsoleMessage(JavaScriptConsoleMessageLevel level, const QString &message, int lineNumber, const QString &sourceID);
void setJavaScriptEnabled(bool enabled);