NavigationBar: Only reload layout when settings changes

src/lib/navigation/navigationbar.cpp

@@ -187,8 +187,6 @@ NavigationBar::NavigationBar(BrowserWindow* window)
     connect(buttonAddTab, SIGNAL(middleMouseClicked()), m_window->tabWidget(), SLOT(addTabFromClipboard()));
     connect(m_exitFullscreen, SIGNAL(clicked(bool)), m_window, SLOT(toggleFullScreen()));
 
-    connect(mApp, &MainApplication::settingsReloaded, this, &NavigationBar::loadSettings);
-
     addWidget(backNextWidget, QSL("button-backforward"), tr("Back and Forward buttons"));
     addWidget(m_reloadStop, QSL("button-reloadstop"), tr("Reload button"));
     addWidget(buttonHome, QSL("button-home"), tr("Home button"));

src/lib/navigation/navigationbarconfigdialog.cpp

@@ -81,7 +81,10 @@ void NavigationBarConfigDialog::saveSettings()
     settings.setValue(QSL("ShowSearchBar"), ui->showSearchBar->isChecked());
     settings.endGroup();
 
-    mApp->reloadSettings();
+    const auto windows = mApp->windows();
+    for (BrowserWindow *window : windows) {
+        window->navigationBar()->loadSettings();
+    }
 }
 
 void NavigationBarConfigDialog::resetToDefaults()

src/lib/preferences/preferences.cpp

@@ -33,7 +33,6 @@
 #include "networkmanager.h"
 #include "desktopnotificationsfactory.h"
 #include "desktopnotification.h"
-#include "navigationbar.h"
 #include "thememanager.h"
 #include "acceptlanguage.h"
 #include "qztools.h"