From 94e6b98450e1361717ab6380ee9641bcef171fb3 Mon Sep 17 00:00:00 2001 From: David Rosca Date: Tue, 6 Feb 2018 14:20:42 +0100 Subject: [PATCH] TabModel: Check return value of beginMoveRows --- src/lib/tabwidget/tabmodel.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/lib/tabwidget/tabmodel.cpp b/src/lib/tabwidget/tabmodel.cpp index f3ef96f15..409e3a4b5 100644 --- a/src/lib/tabwidget/tabmodel.cpp +++ b/src/lib/tabwidget/tabmodel.cpp @@ -266,7 +266,10 @@ void TabModel::tabRemoved(int index) void TabModel::tabMoved(int from, int to) { - beginMoveRows(QModelIndex(), from, from, QModelIndex(), to > from ? to + 1 : to); + if (!beginMoveRows(QModelIndex(), from, from, QModelIndex(), to > from ? to + 1 : to)) { + qWarning() << "Invalid beginMoveRows" << from << (to > from ? to + 1 : to); + return; + } m_tabs.insert(to, m_tabs.takeAt(from)); endMoveRows(); }