From 925e3496d99ddae59bead00463745b401583d9b1 Mon Sep 17 00:00:00 2001
From: David Rosca <nowrep@gmail.com>
Date: Sat, 30 Dec 2017 16:11:07 +0100
Subject: [PATCH] LocationCompleterModel: Don't set tab position to view/search
 item

---
 src/lib/navigation/completer/locationcompletermodel.cpp | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/lib/navigation/completer/locationcompletermodel.cpp b/src/lib/navigation/completer/locationcompletermodel.cpp
index d3daa3670..7b4656d45 100644
--- a/src/lib/navigation/completer/locationcompletermodel.cpp
+++ b/src/lib/navigation/completer/locationcompletermodel.cpp
@@ -141,7 +141,9 @@ void LocationCompleterModel::setTabPosition(QStandardItem* item) const
 {
     Q_ASSERT(item);
 
-    if (!qzSettings->showSwitchTab) {
+    item->setData(-1, TabPositionTabRole);
+
+    if (!qzSettings->showSwitchTab || item->data(VisitSearchItemRole).toBool()) {
         return;
     }
 
@@ -159,10 +161,6 @@ void LocationCompleterModel::setTabPosition(QStandardItem* item) const
             }
         }
     }
-
-    // Tab wasn't found
-    item->setData(QVariant::fromValue<void*>(static_cast<void*>(0)), TabPositionWindowRole);
-    item->setData(-1, TabPositionTabRole);
 }
 
 void LocationCompleterModel::refreshTabPositions() const