opensearch: port foreach -> range-based for

Signed-off-by: Juraj Oravec <sgd.orava@gmail.com>

src/lib/opensearch/opensearchengine.cpp

@@ -644,8 +644,10 @@ void OpenSearchEngine::suggestionsObtained()
 
     QStringList out;
 
-    foreach (const QVariant &v, list.at(1).toList())
+    const auto items = list.at(1).toList();
+    for (const QVariant &v : items) {
         out.append(v.toString());
+    }
 
     emit suggestions(out);
 }

src/lib/opensearch/searchenginesdialog.cpp

@@ -221,7 +221,8 @@ void SearchEnginesDialog::reloadEngines()
     ui->treeWidget->clear();
     const SearchEngine defaultEngine = mApp->searchEnginesManager()->defaultEngine();
 
-    foreach (const SearchEngine &en, m_manager->allEngines()) {
+    const auto engines = m_manager->allEngines();
+    for (const SearchEngine &en : engines) {
         QTreeWidgetItem* item = new QTreeWidgetItem();
         setEngine(item, en);
         changeItemToDefault(item, en == defaultEngine);

src/lib/opensearch/searchenginesmanager.cpp

@@ -119,7 +119,7 @@ SearchEngine SearchEnginesManager::engineForShortcut(const QString &shortcut)
         return returnEngine;
     }
 
-    foreach (const Engine &en, m_allEngines) {
+    for (const Engine &en : qAsConst(m_allEngines)) {
         if (en.shortcut == shortcut) {
             returnEngine = en;
             break;
@@ -217,7 +217,7 @@ void SearchEnginesManager::engineChangedImage()
         return;
     }
 
-    foreach (Engine e, m_allEngines) {
+    for (Engine e : qAsConst(m_allEngines)) {
         if (e.name == engine->name() &&
             e.url.contains(engine->searchUrl("%s").toString()) &&
             !engine->image().isNull()
@@ -280,7 +280,7 @@ void SearchEnginesManager::addEngineFromForm(const QVariantMap &formData, WebVie
     query.addQueryItem(inputName, QSL("SEARCH"));
 
     const QVariantList &inputs = formData.value(QSL("inputs")).toList();
-    foreach (const QVariant &pair, inputs) {
+    for (const QVariant &pair : inputs) {
         const QVariantList &list = pair.toList();
         if (list.size() != 2)
             continue;
@@ -496,7 +496,7 @@ void SearchEnginesManager::saveSettings()
     QSqlQuery query(SqlDatabase::instance()->database());
     query.exec("DELETE FROM search_engines");
 
-    foreach (const Engine &en, m_allEngines) {
+    for (const Engine &en : qAsConst(m_allEngines)) {
         query.prepare("INSERT INTO search_engines (name, icon, url, shortcut, suggestionsUrl, suggestionsParameters, postData) VALUES (?, ?, ?, ?, ?, ?, ?)");
         query.addBindValue(en.name);
         query.addBindValue(iconToBase64(en.icon));