From 514097ef4c3abf1a7e233976f2d09567e6ffad34 Mon Sep 17 00:00:00 2001 From: David Rosca Date: Sat, 20 Apr 2019 14:08:44 +0200 Subject: [PATCH] BookmarksManager: Don't allow to create bookmark without parent BUG: 406433 FIXED-IN: 3.1.1 --- src/lib/bookmarks/bookmarksmanager.cpp | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/lib/bookmarks/bookmarksmanager.cpp b/src/lib/bookmarks/bookmarksmanager.cpp index acbb2f158..6e4620fc9 100644 --- a/src/lib/bookmarks/bookmarksmanager.cpp +++ b/src/lib/bookmarks/bookmarksmanager.cpp @@ -107,9 +107,9 @@ void BookmarksManager::createContextMenu(const QPoint &pos) QAction* actNewPrivateWindow = menu.addAction(IconProvider::privateBrowsingIcon(), tr("Open in new private window")); menu.addSeparator(); - menu.addAction(tr("New Bookmark"), this, SLOT(addBookmark())); - menu.addAction(tr("New Folder"), this, &BookmarksManager::addFolder); - menu.addAction(tr("New Separator"), this, &BookmarksManager::addSeparator); + QAction *actNewBookmark = menu.addAction(tr("New Bookmark"), this, SLOT(addBookmark())); + QAction *actNewFolder = menu.addAction(tr("New Folder"), this, &BookmarksManager::addFolder); + QAction *actNewSeparator = menu.addAction(tr("New Separator"), this, &BookmarksManager::addSeparator); menu.addSeparator(); QAction* actDelete = menu.addAction(QIcon::fromTheme(QSL("edit-delete")), tr("Delete")); @@ -138,6 +138,12 @@ void BookmarksManager::createContextMenu(const QPoint &pos) actNewPrivateWindow->setDisabled(true); } + if (!m_selectedBookmark) { + actNewBookmark->setDisabled(true); + actNewFolder->setDisabled(true); + actNewSeparator->setDisabled(true); + } + menu.exec(pos); }