From 15bb39689ccce6f3be625f6bab9cfd0c52bd7db7 Mon Sep 17 00:00:00 2001
From: David Rosca <nowrep@gmail.com>
Date: Wed, 15 Oct 2014 22:50:19 +0200
Subject: [PATCH] Remove History::optimizeHistory() function

It is no longer needed, this function was little confusing
as it actually only executed VACUUM.
Instead, execute VACUUM after clearing all history in
History::clearHistory()
---
 src/lib/history/history.cpp        | 10 ++++------
 src/lib/history/history.h          |  2 +-
 src/lib/history/historymanager.cpp |  1 -
 3 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/src/lib/history/history.cpp b/src/lib/history/history.cpp
index b38af7f53..000492ede 100644
--- a/src/lib/history/history.cpp
+++ b/src/lib/history/history.cpp
@@ -241,15 +241,13 @@ bool History::optimizeHistory()
     return query.exec("VACUUM");
 }
 
-bool History::clearHistory()
+void History::clearHistory()
 {
     QSqlQuery query;
-    if (query.exec("DELETE FROM history")) {
-        emit resetHistory();
-        return true;
-    }
+    query.exec(QSL("DELETE FROM history"));
+    query.exec(QSL("VACUUM"));
 
-    return false;
+    emit resetHistory();
 }
 
 void History::setSaving(bool state)
diff --git a/src/lib/history/history.h b/src/lib/history/history.h
index 046e6b387..40f2753c0 100644
--- a/src/lib/history/history.h
+++ b/src/lib/history/history.h
@@ -62,7 +62,7 @@ public:
 
     QVector<HistoryEntry> mostVisited(int count);
 
-    bool clearHistory();
+    void clearHistory();
     bool optimizeHistory();
     bool isSaving();
     void setSaving(bool state);
diff --git a/src/lib/history/historymanager.cpp b/src/lib/history/historymanager.cpp
index 126bbbfa9..f0d71a23b 100644
--- a/src/lib/history/historymanager.cpp
+++ b/src/lib/history/historymanager.cpp
@@ -81,7 +81,6 @@ void HistoryManager::clearHistory()
     }
 
     mApp->history()->clearHistory();
-    mApp->history()->optimizeHistory();
 }
 
 void HistoryManager::search(const QString &searchText)