From 0b982ab78864085a399bd2a38835792822d01445 Mon Sep 17 00:00:00 2001 From: Jacopo De Simoi Date: Wed, 19 Aug 2020 07:46:25 -0400 Subject: [PATCH] Use show/hide in methods This is the usual wording in Qt --- src/lib/webengine/webpage.cpp | 4 ++-- src/lib/webengine/webpage.h | 4 ++-- src/lib/webengine/webview.cpp | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/lib/webengine/webpage.cpp b/src/lib/webengine/webpage.cpp index 42701368a..f4f5af16b 100644 --- a/src/lib/webengine/webpage.cpp +++ b/src/lib/webengine/webpage.cpp @@ -690,11 +690,11 @@ void WebPage::javaScriptConsoleMessage(JavaScriptConsoleMessageLevel level, cons std::cout << qPrintable(sourceID) << ":" << lineNumber << " " << qPrintable(message); } -void WebPage::getLinkMarkers() { +void WebPage::showLinkMarkers() { runJavaScript("Marker.generateMarker('a, input, button, [class*=\"btn\"], [aria-haspopup], [role=\"button\"], textarea, select, summary, [class=\"gap\"], [ng-click]')"); } -void WebPage::clearLinkMarkers() { +void WebPage::hideLinkMarkers() { runJavaScript("document.querySelector('.eaf-marker-container').remove();"); runJavaScript("document.querySelector('.eaf-style').remove();"); } diff --git a/src/lib/webengine/webpage.h b/src/lib/webengine/webpage.h index a86b47f79..a67c303a0 100644 --- a/src/lib/webengine/webpage.h +++ b/src/lib/webengine/webpage.h @@ -77,8 +77,8 @@ public: static void addSupportedScheme(const QString &scheme); static void removeSupportedScheme(const QString &scheme); - void getLinkMarkers(); - void clearLinkMarkers(); + void showLinkMarkers(); + void hideLinkMarkers(); Q_SIGNALS: void privacyChanged(bool status); diff --git a/src/lib/webengine/webview.cpp b/src/lib/webengine/webview.cpp index 0768e669b..b7d33f60a 100644 --- a/src/lib/webengine/webview.cpp +++ b/src/lib/webengine/webview.cpp @@ -1206,10 +1206,10 @@ void WebView::_keyReleaseEvent(QKeyEvent *event) break; case Qt::Key_F: if (!m_followLink) { - page()->getLinkMarkers(); + page()->showLinkMarkers(); m_followLink = true; } else { - page()->clearLinkMarkers(); + page()->hideLinkMarkers(); m_followLink = false; } event->accept();