Fix leaking QWebEngineUrlRequestJob reply

BUG: 403129
FIXED-IN: 3.1.0
remotes/origin/downloadmanager
David Rosca 7 years ago
parent 1c4a8ddd6f
commit 0389da311c
No known key found for this signature in database
GPG Key ID: EBC3FC294452C6D8
  1. 2
      src/lib/network/schemehandlers/extensionschemehandler.cpp
  2. 2
      src/lib/network/schemehandlers/falkonschemehandler.cpp
  3. 1
      src/plugins/KDEFrameworksIntegration/kioschemehandler.cpp

@ -24,7 +24,7 @@
// ExtensionSchemeHandler
void ExtensionSchemeHandler::setReply(QWebEngineUrlRequestJob *job, const QByteArray &contentType, const QByteArray &content)
{
QBuffer *buffer = new QBuffer();
QBuffer *buffer = new QBuffer(job);
buffer->open(QIODevice::ReadWrite);
buffer->write(content);
buffer->seek(0);

@ -55,7 +55,7 @@ void FalkonSchemeHandler::requestStarted(QWebEngineUrlRequestJob *job)
knownPages << "about" << "start" << "speeddial" << "config" << "restore";
if (knownPages.contains(job->requestUrl().path()))
job->reply(QByteArrayLiteral("text/html"), new FalkonSchemeReply(job));
job->reply(QByteArrayLiteral("text/html"), new FalkonSchemeReply(job, job));
else
job->fail(QWebEngineUrlRequestJob::UrlInvalid);
}

@ -57,6 +57,7 @@ void KIOSchemeHandler::requestStarted(QWebEngineUrlRequestJob *job)
qWarning() << "Error:" << reply->errorString();
job->fail(QWebEngineUrlRequestJob::RequestFailed);
} else {
reply->setParent(job);
job->reply(reply->header(QNetworkRequest::ContentTypeHeader).toByteArray(), reply);
}
});

Loading…
Cancel
Save